Bug 2097685: Remove the container at exit

[elfosardo]

Fix an issue when the agent container keeps restarting indefinitely
if failed to start.

[openshift-ci]

@elfosardo: This pull request references Bugzilla bug 2097685, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.11.0) matches configured target release for branch (4.11.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

Details

In response to this:

Bug 2097685: Remove the container at exit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[derekhiggins]

/lgtm

[elfosardo]

@derekhiggins sorry forgot to change the tests!

[derekhiggins]

/lgtm

[elfosardo]

/test e2e-metal-ipi

[openshift-ci]

@elfosardo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[dtantsur]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [dtantsur]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@elfosardo: All pull requests linked via external trackers have merged:

• openshift/image-customization-controller#55

Bugzilla bug 2097685 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2097685: Remove the container at exit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[elfosardo]

we will backport this to 4.10 after #54 merges

[elfosardo]

/cherry-pick release-4.10

[openshift-cherrypick-robot]

@elfosardo: #55 failed to apply on top of branch "release-4.10":

Applying: Remove the container at exit
Using index info to reconstruct a base tree...
M	pkg/ignition/service_config.go
M	pkg/ignition/service_config_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/ignition/service_config_test.go
CONFLICT (content): Merge conflict in pkg/ignition/service_config_test.go
Auto-merging pkg/ignition/service_config.go
CONFLICT (content): Merge conflict in pkg/ignition/service_config.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Remove the container at exit
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.