Set Proxy variables for all systemd services #39
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
zaneb
force-pushed
the
proxy-default-env
branch
3 times, most recently
from
1623245 to
6f22457
Compare
openshift-ci
bot
added
the
needs-rebase
openshift-ci
bot
removed
the
needs-rebase
| }) | ||
| } | ||
|
|
||
| config.Storage.Files = append(config.Storage.Files, ignitionFileEmbed( |
There was a problem hiding this comment.
Let's please only create this file if there are settings to apply. We're working on integration with the assisted service, I'd like to be able to minimize the impact on them (e.g. if they have their own default environment).
There was a problem hiding this comment.
If there is a conflict, better that we have to deal with it all the time IMHO. Test coverage for proxy variables is notoriously poor.
There was a problem hiding this comment.
I'm not sure I get it... why do we need to create this file when no proxy settings are provided?
There was a problem hiding this comment.
We don't, but if creating it causes a bug then we don't want to find out only when it is used in the field, which is how we've found bugs with the proxy config in the past.
Currently the IPA service is the only one that needs the proxy settings, but in the interests of future flexibility, do what the installer bootstrap does and set the proxy environment variables by default in all systemd services. By default, podman containers will get passed any proxy environment variables that exist in the environment when the container is started: https://docs.podman.io/en/latest/markdown/podman-run.1.html#http-proxy
Too many strings make the ignition.New() method hard to read.
zaneb
force-pushed
the
proxy-default-env
branch
from
f72735b to
4a0f6af
Compare
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
lifecycle/stale
|
@zaneb: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
bot
added
lifecycle/rotten
|
@zaneb: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
3 participants
Currently the IPA service is the only one that needs the proxy settings, but in the interests of future flexibility, do what the installer bootstrap does and set the proxy environment variables by default in all systemd services.