Bug 2038272: Improve error reporting #28
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
| size, err := f.getBaseImage(initramfs).Size() | ||
| if err != nil { | ||
| return "", err | ||
| return "", InvalidBaseImageError{cause: err} |
There was a problem hiding this comment.
For completeness, we could add a check to make sure that in addition to there being no errors, the size is also not zero.
openshift-ci
bot
added
the
needs-rebase
If the address for Ironic is not available (e.g. if the metal3 Pod is not running) then the CBO will start the controller with an empty IRONIC_BASE_URL. In this case we don't want it to crashloop, but rather start and update the CRDs to indicate that the images are not available.
Enforce the early checking for a valid publish address base URL by requiring a URL object as the input to NewImageHandler().
If the network data is in an invalid format, report the error from nmstatectl and flag an error in the image CR.
If the base image cannot be read, this is not a transient error but a reason to mark the image as in error.
openshift-ci
bot
removed
the
needs-rebase
|
/retitle Bug 2038272: Improve error reporting |
openshift-ci
bot
changed the title
openshift-ci
bot
added
bugzilla/severity-medium
|
@zaneb: This pull request references Bugzilla bug 2038272, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (augol@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest-required |
|
/lgtm |
|
/retest-required |
|
@zaneb: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@zaneb: All pull requests linked via external trackers have merged: Bugzilla bug 2038272 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
Report errors through the CRD when they are related to the input or the configuration (i.e. are not transient).