Support embedding a custom registries.conf file #20
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required |
|
|
||
| func (env *EnvInputs) RegistriesConf() (data []byte, err error) { | ||
| if env.RegistriesConfPath == "" { | ||
| return |
There was a problem hiding this comment.
not a fan of these naked returns..
There was a problem hiding this comment.
Do we want to set an error here indicating that REGISTRIES_CONF_PATH is not set? It currently fails silently.
There was a problem hiding this comment.
I don't think we have to make it required (it doesn't fail, it just doesn't add a registry file to the ignition).
asalkeld
left a comment
asalkeld
left a comment
There was a problem hiding this comment.
looks good, just a bit sad there is no tests :-(
zaneb
force-pushed
the
registries-conf
branch
from
2c8dd67 to
96f7fb8
Compare
zaneb
changed the title
|
/retest-required |
|
Would it be possible to add tests per Angus' request? |
zaneb
force-pushed
the
registries-conf
branch
from
d1d3c3e to
59405cf
Compare
On the installer bootstrap server, we need to specify a registries.conf file to set up the mirror, since the pull secret is for the mirror registry but the IPA image path points to the release image.
Previously this was limited to just the static server.
zaneb
force-pushed
the
registries-conf
branch
from
59405cf to
fbd5df0
Compare
|
Now with tests. |
|
/retest-required |
|
/lgtm |
5 participants
We need to specify a registries.conf file to set up the mirror, since the pull secret is for the mirror registry but the IPA image path points to the release image.