Added route controller manager #707
Conversation
|
/hold |
| {{ if .MasterPriorityClass }} | ||
| priorityClassName: {{ .MasterPriorityClass }} | ||
| {{ end }} | ||
| terminationGracePeriodSeconds: 90 |
There was a problem hiding this comment.
I assume this will be OK, but please verify that the pod terminates in under 90 seconds.
There was a problem hiding this comment.
Terminated within 3 seconds of it being scaled down
root@instance:/armada-openshift-master/lib/roks4/pki# date; kubectl scale deploy -n master-molecule1 route-controller-manager --replicas 0
Mon Jan 23 17:49:07 UTC 2023
root@instance:/armada-openshift-master# while true; do date; kubectl get pods -A | grep route-controller; sleep 5; done
Mon Jan 23 17:49:04 UTC 2023
master-molecule1 route-controller-manager-878d6dc87-2gmh7 1/1 Running 0 29m
master-molecule1 route-controller-manager-878d6dc87-85gkr 1/1 Running 0 29m
master-molecule1 route-controller-manager-878d6dc87-xbrfd 1/1 Running 0 29m
Mon Jan 23 17:49:10 UTC 2023
Mon Jan 23 17:49:17 UTC 2023
|
@csrwng ptal |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Joseph-Goergen, rtheis The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/remove-hold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@Joseph-Goergen: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/cherry-pick release-4-12 |
|
@rtheis: cannot checkout DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.12 |
|
@rtheis: new pull request created: #714 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
5 participants
Partially based on: openshift/hypershift#1756 and openshift/hypershift#1790