OCPBUGS-120840: remove TechPreviewNoUpgrade from AWS cluster creation args by vismishr · Pull Request #9535 · openshift/hypershift

vismishr · 2026-09-08T09:39:19Z

Summary

Fixes OCPBUGS-120840: control-plane-upgrade test was failing due to TechPreviewNoUpgrade being applied globally to all test clusters.

Root Cause

--feature-set=TechPreviewNoUpgrade was in the global CreateArgs(), affecting ALL clusters including upgrade variants. When upgrade tests run on TechPreview clusters, they expose a CSI snapshot controller CRD storage-version conflict: v1beta2 was removed from spec.versions but still present in status.storedVersions.

Fix

Remove TechPreviewNoUpgrade from global CreateArgs()
Add it only to variants that need TechPreview features: public and karpenter
Keep it off upgrade and karpenter-upgrade variants

Upgrade tests should use stable GA APIs, not preview features.

Testing

Control-plane-upgrade test runs with stable APIs
Public/karpenter tests still get TechPreview features for development testing
No impact on other tests

Fixes: OCPBUGS-120840

Summary by CodeRabbit

Configuration Changes
- AWS-hosted clusters no longer default to the TechPreviewNoUpgrade feature set.
- Clusters created through the public and karpenter variants now use the TechPreviewNoUpgrade feature set.
- Cluster lifecycle behavior is now aligned with the selected cluster specification variant.

…on args The control-plane-upgrade test was failing because it attempted to upgrade a cluster with TechPreviewNoUpgrade enabled. This exposed a pre-existing OCP bug in the CSI snapshot controller CRDs: v1beta2 was removed from spec.versions but still present in status.storedVersions, violating Kubernetes storage-version migration rules. TechPreviewNoUpgrade clusters should not be upgraded — upgrading a TechPreview cluster to a release that has graduated those APIs (removing the preview versions) is out of scope for the control-plane-upgrade test. Removing TechPreviewNoUpgrade from the default CreateArgs ensures the test cluster uses stable API versions that don't change between 4.22 and 5.0, allowing the upgrade to proceed without CRD conflicts. Fixes OCPBUGS-120840.

openshift-merge-bot · 2026-09-08T09:39:21Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

coderabbitai · 2026-09-08T09:39:50Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: 76ff387e-4bc5-4a70-8b8a-aa56354c70fe

📥 Commits

Reviewing files that changed from the base of the PR and between fdb77ab and 32e6f54.

📒 Files selected for processing (1)

test/e2e/v2/lifecycle/aws.go

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

📝 Walkthrough

Walkthrough

AWS cluster creation no longer passes --feature-set=TechPreviewNoUpgrade in the base AWSPlatformConfig.CreateArgs. The public and karpenter cluster spec variants now pass this argument explicitly. No public declarations changed.

Priority: ➖ Normal

Merge Risk: ⚪ Minimal · up to 32e6f

AWS test cluster creation now enables TechPreviewNoUpgrade only for public and Karpenter variants, allowing upgrade variants to use stable APIs. No current merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 11

✅ Passed checks (11 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS: The pull request changes only AWS cluster argument lists in `test/e2e/v2/lifecycle/aws.go`. It removes `--feature-set=TechPreviewNoUpgrade` from `CreateArgs()` and adds it to the `public` and `k…
Test Structure And Quality	✅ Passed	PASS: The PR changes only `test/e2e/v2/lifecycle/aws.go`, moving a cluster creation argument between AWS variants. The diff contains no Ginkgo `It`, `BeforeEach`, `AfterEach`, `Eventually`, or `Consis…
Topology-Aware Scheduling Compatibility	✅ Passed	PASS — The PR changes only `test/e2e/v2/lifecycle/aws.go`. It moves `--feature-set=TechPreviewNoUpgrade` from `AWSPlatformConfig.CreateArgs()` to the `public` and `karpenter` cluster variants. The dif…
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS: The pull request changes only `test/e2e/v2/lifecycle/aws.go`. It removes a cluster creation argument and adds `TechPreviewNoUpgrade` to existing `public` and `karpenter` variants. The diff adds …
No-Weak-Crypto	✅ Passed	PASS: The complete PR diff changes only `test/e2e/v2/lifecycle/aws.go`. It removes and adds `--feature-set=TechPreviewNoUpgrade` arguments. It introduces no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, c…
Container-Privileges	✅ Passed	PASS. The PR changes only `test/e2e/v2/lifecycle/aws.go`. It moves `--feature-set=TechPreviewNoUpgrade` from `CreateArgs()` to the `public` and `karpenter` cluster variants. The diff introduces no con…
No-Sensitive-Data-In-Logs	✅ Passed	The complete PR diff changes only `test/e2e/v2/lifecycle/aws.go`: it adds the non-sensitive constant `--feature-set=TechPreviewNoUpgrade` to two variants and removes it from default arguments. It adds…
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the primary change: removing TechPreviewNoUpgrade from AWS cluster creation arguments. It accurately reflects the changeset.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

openshift-ci-robot · 2026-09-08T09:43:00Z

@vismishr: This pull request references Jira Issue OCPBUGS-120840, which is invalid:

expected the bug to target the "5.1.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Fixes OCPBUGS-120840: control-plane-upgrade test was failing when attempting to upgrade a TechPreviewNoUpgrade cluster due to CSI snapshot controller CRD storage-version conflicts.

Root Cause

The test cluster was created with --feature-set=TechPreviewNoUpgrade, which enables v1beta2 API versions for the CSI snapshot CRDs in the 4.22 base cluster. When upgrading to 5.0, the payload ships the snapshot CRDs without v1beta2, violating Kubernetes' storage-version migration rules (can't remove v1beta2 from spec.versions if data is stored in v1beta2).

Fix

Remove TechPreviewNoUpgrade from the default AWS cluster creation arguments. TechPreview clusters should not be tested during upgrades — the test should use stable GA APIs that don't change between versions.

Testing

Allows the control-plane-upgrade test to proceed without CRD conflicts

Test cluster will use stable API versions (v1 only) that are consistent between 4.22 and 5.0

Fixes: OCPBUGS-120840

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

codecov · 2026-09-08T09:49:09Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.38%. Comparing base (c7ba91a) to head (32e6f54).
⚠️ Report is 53 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9535      +/-   ##
==========================================
+ Coverage   47.21%   47.38%   +0.17%     
==========================================
  Files         791      793       +2     
  Lines       99517    99813     +296     
==========================================
+ Hits        46989    47301     +312     
+ Misses      49366    49349      -17     
- Partials     3162     3163       +1

see 24 files with indirect coverage changes

Flag	Coverage Δ
cmd-support	`40.96% <ø> (+0.02%)`	⬆️
cpo-hostedcontrolplane	`50.50% <ø> (+0.15%)`	⬆️
cpo-other	`48.38% <ø> (+0.68%)`	⬆️
hypershift-operator	`57.57% <ø> (+0.13%)`	⬆️
other	`34.70% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

celebdor · 2026-09-09T16:09:09Z

/jira refresh

openshift-ci-robot · 2026-09-09T16:09:16Z

@celebdor: This pull request references Jira Issue OCPBUGS-120840, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (5.1.0) matches configured target version for branch (5.1.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jparrill · 2026-09-09T16:17:46Z

/approve

jparrill · 2026-09-09T16:17:55Z

/verified by E2E passing

openshift-ci-robot · 2026-09-09T16:18:08Z

@jparrill: This PR has been marked as verified by E2E passing.

Details

In response to this:

/verified by E2E passing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ironcladlou · 2026-09-09T17:25:49Z

This removes it from all hosted clusters being tested, not just upgrade tests. Under what circumstances should the flag be enabled? Because with this PR it's no longer enabled for any tests at all

csrwng · 2026-09-09T17:54:46Z

We should narrow the scope to only the cluster that will be used for an upgrade test and not all clusters

csrwng · 2026-09-09T18:19:39Z

 				// Enables Karpenter-based node provisioning (AutoNode)
 				"--auto-node",
 				// Required for karpenter to reach the hosted cluster API server from the mgmt cluster
 				"--endpoint-access=PublicAndPrivate",


"--feature-set=TechPreviewNoUpgrade"

csrwng · 2026-09-09T18:19:50Z

 		{
 			Variant: "public",
 			ExtraArgs: append(extraArgs, []string{
 				"--public-only",


"--feature-set=TechPreviewNoUpgrade",

Remove TechPreviewNoUpgrade from global CreateArgs() and add it only to variants that need it (public, karpenter). Keep it off upgrade variants so the control-plane-upgrade test can use stable GA APIs. The control-plane-upgrade test was failing because it attempted to upgrade a cluster with TechPreviewNoUpgrade enabled, which exposed a CSI snapshot controller CRD storage-version conflict: v1beta2 was removed from spec.versions but still present in status.storedVersions. Upgrade tests should use stable APIs, not preview features. TechPreview feature testing is scoped to public and karpenter variants. Fixes OCPBUGS-120840.

openshift-ci-robot · 2026-09-09T18:25:03Z

@vismishr: This pull request references Jira Issue OCPBUGS-120840, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (5.1.0) matches configured target version for branch (5.1.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

Summary

Fixes OCPBUGS-120840: control-plane-upgrade test was failing due to TechPreviewNoUpgrade being applied globally to all test clusters.

Root Cause

--feature-set=TechPreviewNoUpgrade was in the global CreateArgs(), affecting ALL clusters including upgrade variants. When upgrade tests run on TechPreview clusters, they expose a CSI snapshot controller CRD storage-version conflict: v1beta2 was removed from spec.versions but still present in status.storedVersions.

Fix

Remove TechPreviewNoUpgrade from global CreateArgs()

Add it only to variants that need TechPreview features: public and karpenter

Keep it off upgrade and karpenter-upgrade variants

Upgrade tests should use stable GA APIs, not preview features.

Testing

Control-plane-upgrade test runs with stable APIs

Public/karpenter tests still get TechPreview features for development testing

No impact on other tests

Fixes: OCPBUGS-120840

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-bot · 2026-09-09T18:30:37Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aks-5-0
/test e2e-aws-5-0
/test e2e-aks
/test e2e-aws
/test e2e-aws-upgrade-hypershift-operator
/test e2e-kubevirt-aws-ovn-reduced
/test e2e-v2-aws
/test e2e-v2-azure-self-managed
/test e2e-v2-gke

openshift-ci · 2026-09-09T18:30:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, jparrill, vismishr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~test/e2e/OWNERS~~ [csrwng,jparrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

csrwng · 2026-09-09T18:46:52Z

/test images

csrwng · 2026-09-09T19:24:06Z

/test okd-scos-images

jparrill · 2026-09-09T20:00:52Z

/test okd-scos-images

jparrill · 2026-09-09T20:01:01Z

/verified by E2E passing

openshift-ci-robot · 2026-09-09T20:01:14Z

@jparrill: This PR has been marked as verified by E2E passing.

Details

In response to this:

/verified by E2E passing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-bot · 2026-09-09T21:44:00Z

/retest-required

Remaining retests: 0 against base HEAD 9cfe825 and 2 for PR HEAD 32e6f54 in total

cwbotbot · 2026-09-09T21:50:03Z

Test Results

e2e-aws

Status: ✅ PASS
Started: 2026-09-09T22:46:34Z
View Job
View Job History

e2e-aks

Status: ✅ PASS
Started: 2026-09-09T18:31:39Z
View Job
View Job History

openshift-merge-bot · 2026-09-09T22:46:02Z

/retest-required

Remaining retests: 0 against base HEAD eccc3ed and 1 for PR HEAD 32e6f54 in total

openshift-ci · 2026-09-10T02:26:56Z

@vismishr: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2026-09-10T02:30:26Z

@vismishr: Jira Issue Verification Checks: Jira Issue OCPBUGS-120840
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-120840 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Summary

Fixes OCPBUGS-120840: control-plane-upgrade test was failing due to TechPreviewNoUpgrade being applied globally to all test clusters.

Root Cause

--feature-set=TechPreviewNoUpgrade was in the global CreateArgs(), affecting ALL clusters including upgrade variants. When upgrade tests run on TechPreview clusters, they expose a CSI snapshot controller CRD storage-version conflict: v1beta2 was removed from spec.versions but still present in status.storedVersions.

Fix

Remove TechPreviewNoUpgrade from global CreateArgs()

Add it only to variants that need TechPreview features: public and karpenter

Keep it off upgrade and karpenter-upgrade variants

Upgrade tests should use stable GA APIs, not preview features.

Testing

Control-plane-upgrade test runs with stable APIs

Public/karpenter tests still get TechPreview features for development testing

No impact on other tests

Fixes: OCPBUGS-120840

Summary by CodeRabbit

Configuration Changes

AWS-hosted clusters no longer default to the TechPreviewNoUpgrade feature set.

Clusters created through the public and karpenter variants now use the TechPreviewNoUpgrade feature set.

Cluster lifecycle behavior is now aligned with the selected cluster specification variant.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci Bot added the do-not-merge/needs-area label Sep 8, 2026

openshift-ci Bot added area/platform/aws PR/issue for AWS (AWSPlatform) platform area/testing Indicates the PR includes changes for e2e testing and removed do-not-merge/needs-area labels Sep 8, 2026

openshift-ci Bot requested review from georgelipceanu and ironcladlou September 8, 2026 09:40

vismishr changed the title ~~fix(test/e2e/v2): remove TechPreviewNoUpgrade from AWS cluster creation args~~ OCPBUGS-120840: remove TechPreviewNoUpgrade from AWS cluster creation args Sep 8, 2026

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 8, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 9, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 9, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2026

csrwng reviewed Sep 9, 2026

View reviewed changes

openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Sep 9, 2026

csrwng approved these changes Sep 9, 2026

View reviewed changes

openshift-ci Bot assigned csrwng Sep 9, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 9, 2026

openshift-merge-bot Bot merged commit f12c528 into openshift:main Sep 10, 2026
46 checks passed

Uh oh!

Conversation

vismishr commented Sep 8, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Root Cause

Fix

Testing

Summary by CodeRabbit

Uh oh!

openshift-merge-bot Bot commented Sep 8, 2026

Uh oh!

coderabbitai Bot commented Sep 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Uh oh!

openshift-ci-robot commented Sep 8, 2026

Summary

Root Cause

Fix

Testing

Uh oh!

codecov Bot commented Sep 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

celebdor commented Sep 9, 2026

Uh oh!

openshift-ci-robot commented Sep 9, 2026

Uh oh!

jparrill commented Sep 9, 2026

Uh oh!

jparrill commented Sep 9, 2026

Uh oh!

openshift-ci-robot commented Sep 9, 2026

Uh oh!

ironcladlou commented Sep 9, 2026

Uh oh!

csrwng commented Sep 9, 2026

Uh oh!

csrwng Sep 9, 2026

Choose a reason for hiding this comment

Uh oh!

csrwng Sep 9, 2026

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Sep 9, 2026

Summary

Root Cause

Fix

Testing

Uh oh!

openshift-merge-bot Bot commented Sep 9, 2026

Uh oh!

openshift-ci Bot commented Sep 9, 2026

Uh oh!

csrwng commented Sep 9, 2026

Uh oh!

csrwng commented Sep 9, 2026

Uh oh!

jparrill commented Sep 9, 2026

Uh oh!

jparrill commented Sep 9, 2026

Uh oh!

openshift-ci-robot commented Sep 9, 2026

Uh oh!

openshift-merge-bot Bot commented Sep 9, 2026

Uh oh!

cwbotbot commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

e2e-aws

e2e-aks

Uh oh!

openshift-merge-bot Bot commented Sep 9, 2026

Uh oh!

openshift-ci Bot commented Sep 10, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Sep 10, 2026

vismishr commented Sep 8, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Sep 8, 2026 •

edited

Loading

codecov Bot commented Sep 8, 2026 •

edited

Loading

cwbotbot commented Sep 9, 2026 •

edited

Loading