Revert "OCPBUGS-98281: Add unit tests for product-cli create cluster commands (#9107)"

[redhat-chai-bot]

PR #9107 introduced fixture-based snapshot tests for product-cli create cluster commands. The fixture YAML files were stale on merge — they captured output that no longer matches current main (a CAPI provider Role resource was removed from rendered output by a concurrent change). This breaks the test / Unit Tests (other) GitHub Actions check for all open PRs.

Reverting to unblock main. The tests can be re-added with updated fixtures.

This reverts commit 161f6d0.

---

@devguyio requested in Slack thread

Summary by CodeRabbit

• Tests
  • Removed legacy cluster creation tests across supported infrastructure providers.
  • Existing command behavior and manifest rendering are no longer covered by these test cases.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@redhat-chai-bot: This pull request references Jira Issue OCPBUGS-98281, which is invalid:

• expected the bug to be open, but it isn't
• expected the vulnerability to target either version "5.0." or "openshift-5.0.", but it targets "4.20.z" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Not a Bug) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

PR #9107 introduced fixture-based snapshot tests for product-cli create cluster commands. The fixture YAML files were stale on merge — they captured output that no longer matches current main (a CAPI provider Role resource was removed from rendered output by a concurrent change). This breaks the test / Unit Tests (other) GitHub Actions check for all open PRs.

Reverting to unblock main. The tests can be re-added with updated fixtures.

This reverts commit 161f6d0.

---

@devguyio requested in Slack thread

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: b8860b13-dd7b-4439-97b0-d542ac0b6858

📥 Commits

Reviewing files that changed from the base of the PR and between 53daedc and 58d5cb4.

⛔ Files ignored due to path filters (5)

• product-cli/cmd/cluster/agent/testdata/zz_fixture_TestCreateCluster_When_minimal_flags_are_provided__it_should_render_correctly.yaml is excluded by !**/testdata/**
• product-cli/cmd/cluster/aws/testdata/zz_fixture_TestCreateCluster_When_minimal_flags_are_provided__it_should_render_correctly.yaml is excluded by !**/testdata/**
• product-cli/cmd/cluster/azure/testdata/zz_fixture_TestCreateCluster_When_minimal_flags_are_provided__it_should_render_correctly.yaml is excluded by !**/testdata/**
• product-cli/cmd/cluster/kubevirt/testdata/zz_fixture_TestCreateCluster_When_minimal_flags_are_provided__it_should_render_correctly.yaml is excluded by !**/testdata/**
• product-cli/cmd/cluster/openstack/testdata/zz_fixture_TestCreateCluster_When_minimal_flags_are_provided__it_should_render_correctly.yaml is excluded by !**/testdata/**

📒 Files selected for processing (5)

• product-cli/cmd/cluster/agent/create_test.go
• product-cli/cmd/cluster/aws/create_test.go
• product-cli/cmd/cluster/azure/create_test.go
• product-cli/cmd/cluster/kubevirt/create_test.go
• product-cli/cmd/cluster/openstack/create_test.go

💤 Files with no reviewable changes (5)

• product-cli/cmd/cluster/kubevirt/create_test.go
• product-cli/cmd/cluster/agent/create_test.go
• product-cli/cmd/cluster/aws/create_test.go
• product-cli/cmd/cluster/azure/create_test.go
• product-cli/cmd/cluster/openstack/create_test.go

---

📝 Walkthrough

Walkthrough

The pull request deletes cluster creation tests for Agent, AWS, Azure, KubeVirt, and OpenStack commands. The removed tests covered command construction, flag registration, inherited flags, expected flag sets, and cluster manifest rendering. Azure-specific imports for credentials, infrastructure setup, filesystem handling, fixtures, and flag parsing were also removed.

Possibly related PRs

• openshift/hypershift#9107: Added the cluster create_test.go tests that this pull request removes.

🚥 Pre-merge checks | ✅ 11

✅ Passed checks (11 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies that the pull request reverts the addition of product-cli create cluster unit tests.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The patch deletes the snapshot tests and fixtures; the surviving Azure test uses only literal, stable t.Run names, with no dynamic Ginkgo title construction.
Test Structure And Quality	✅ Passed	The PR only deletes create tests and fixtures; affected directories contain no Ginkgo constructs, cluster waits, or cluster operations, so this check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	The commit only deletes create tests and snapshot fixtures; it adds no deployment manifests, operator code, controllers, or scheduling constraints.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The commit adds no lines or Ginkgo tests; it only deletes unit tests and fixtures. Remaining cluster tests use Go testing and Gomega, so this check is not applicable.
No-Weak-Crypto	✅ Passed	The PR adds no code or data: the diff is 0 additions and 1,602 deletions, and scans found no MD5, SHA1, DES, RC4, Blowfish, ECB, or crypto API usage.
Container-Privileges	✅ Passed	The PR only deletes test code and YAML fixtures; it adds no privilege-related lines, and no current product-cli files match the listed privilege settings.
No-Sensitive-Data-In-Logs	✅ Passed	The commit adds no lines or logging calls; it only deletes snapshot tests and fixtures, while the retained Azure test contains no sensitive logging.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: redhat-chai-bot
Once this PR has been reviewed and has the lgtm label, please assign akalenyu, awels, bryan-cox, mandre, orenc1, qinqon, stephenfin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bryan-cox]

/close

[openshift-ci]

@bryan-cox: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

@redhat-chai-bot: This pull request references Jira Issue OCPBUGS-98281. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

PR #9107 introduced fixture-based snapshot tests for product-cli create cluster commands. The fixture YAML files were stale on merge — they captured output that no longer matches current main (a CAPI provider Role resource was removed from rendered output by a concurrent change). This breaks the test / Unit Tests (other) GitHub Actions check for all open PRs.

Reverting to unblock main. The tests can be re-added with updated fixtures.

This reverts commit 161f6d0.

---

@devguyio requested in Slack thread

Summary by CodeRabbit

• Tests
• Removed legacy cluster creation tests across supported infrastructure providers.
• Existing command behavior and manifest rendering are no longer covered by these test cases.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.