Skip to content

OCPBUGS-100302: fix(metrics): only report limited support when label … #9185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Aug 3, 2026
+12 −2
Merged

OCPBUGS-100302: fix(metrics): only report limited support when label … #9185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hypershift-operator/controllers/hostedcluster/metrics/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ func collectUpgradingDurationMetric(ch chan<- prometheus.Metric, clk clock.Clock

func collectLimitedSupportMetric(ch chan<- prometheus.Metric, hcluster *hyperv1.HostedCluster, hclusterLabelValues []string) {
limitedSupportValue := 0.0
if _, ok := hcluster.Labels[hyperv1.LimitedSupportLabel]; ok {
if v, ok := hcluster.Labels[hyperv1.LimitedSupportLabel]; ok && v == "true" {
limitedSupportValue = 1.0
}
ch <- prometheus.MustNewConstMetric(
Expand Down
12 changes: 11 additions & 1 deletion hypershift-operator/controllers/hostedcluster/metrics/metrics_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,10 +383,20 @@ func TestReportLimitedSuportEnabled(t *testing.T) {
expected *dto.MetricFamily
}{
{
name: "When limited support label is set, metric is reported as one",
name: "When limited support label is set to true, metric is reported as one",
labels: map[string]string{hyperv1.LimitedSupportLabel: "true"},
expected: wrapExpectedValueAsMetric(1),
},
{
name: "When limited support label is set to false, metric is reported as zero",
labels: map[string]string{hyperv1.LimitedSupportLabel: "false"},
expected: wrapExpectedValueAsMetric(0),
},
{
name: "When limited support label is set to anything unsupported, metric is reported as zero",
labels: map[string]string{hyperv1.LimitedSupportLabel: "foo"},
expected: wrapExpectedValueAsMetric(0),
},
{
name: "When limited support label is not set, metric is reported as zero",
labels: map[string]string{},
Expand Down