Skip to content

CNTRLPLANE-3956: Make EnsureGlobalPullSecret e2e test informing #9167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Jul 29, 2026
Merged

CNTRLPLANE-3956: Make EnsureGlobalPullSecret e2e test informing #9167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion test/e2e/create_cluster_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,6 @@ func TestCreateCluster(t *testing.T) {
e2eutil.EnsureKubeAPIServerAllowedCIDRs(t, ctx, mgtClient, guestConfig, hostedCluster)
}

e2eutil.EnsureGlobalPullSecret(t, ctx, mgtClient, hostedCluster, globalOpts.AdditionalPullSecretFile)
e2eutil.EnsureMetricsForwarderWorking(t, ctx, mgtClient, hostedCluster)

// Verify CPO override image if TEST_CPO_OVERRIDE=1 is set
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/v2/tests/hosted_cluster_pull_secret_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ func RegisterGlobalPullSecretTests(getTestCtx internal.TestContextGetter) {
}

func EnsureGlobalPullSecretTest(getTestCtx internal.TestContextGetter) {
When("an additional pull secret is created in the hosted cluster", func() {
When("an additional pull secret is created in the hosted cluster", Label("Informing"), func() {
It("should propagate it through the global pull secret pipeline and clean up on deletion", func() {
tc := getTestCtx()
if e2eutil.IsLessThan(e2eutil.Version419) {
Expand Down