[TEST ONLY] test(azure): enable Global Pull Secret test in Azure CI - #9105
[TEST ONLY] test(azure): enable Global Pull Secret test in Azure CI #9105mgencur wants to merge 4 commits into
Conversation
Add a dedicated TestGroup for the global-pull-secret label in the Azure parallel test matrix. The test needs its own cluster because it mutates kubelet pull-secret configuration on every worker node via a DaemonSet rollout, which would interfere with other tests running on the same HostedCluster. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…e dummy data Remove the E2E_ADDITIONAL_PULL_SECRET_FILE env var requirement from the Global Pull Secret test. The test only verifies that changing the secret propagates through the pipeline — it never authenticates against a real registry — so a second hardcoded dummy with different content exercises the same update path without requiring CI to provision an external file. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…r under test The NodePool selection loop listed all NodePools in the namespace without filtering by HostedCluster name. When multiple hosted clusters share the same namespace (standard in CI), the test could pick a NodePool belonging to a different cluster, causing the node label selector to match zero nodes in the guest cluster API. Also wrap the UpdatingConfig condition check in Consistently so a brief flip to True is caught rather than missed by a one-shot read. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe global pull-secret E2E test now uses inline Docker configuration payloads, selects a suitable NodePool through Possibly related PRs
Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (10 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/test e2e-azure-v2-self-managed |
openshift-ci
Bot
added
area/platform/azure
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mgencur The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/e2e/v2/lifecycle/azure.go`:
- Around line 362-367: Update the external-oidc lifecycle group’s ClusterFile to
the literal artifact name cluster-name-global-pull-secret so readClusterName can
resolve it, and remove the now-unused external-oidc cluster specification.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 61e3671d-268f-45bb-9710-705bc1a354a3
📒 Files selected for processing (3)
test/e2e/v2/internal/env_vars.gotest/e2e/v2/lifecycle/azure.gotest/e2e/v2/tests/hosted_cluster_pull_secret_test.go
💤 Files with no reviewable changes (1)
- test/e2e/v2/internal/env_vars.go
…secret tests Merge the global-pull-secret TestGroup into external-oidc to reduce the number of HostedClusters in the Azure CI matrix. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
8e74dc2 to
695d294
Compare
|
/test e2e-azure-v2-self-managed |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9105 +/- ##
=======================================
Coverage 44.50% 44.51%
=======================================
Files 774 774
Lines 96980 96997 +17
=======================================
+ Hits 43164 43179 +15
- Misses 50828 50830 +2
Partials 2988 2988 see 2 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
/test e2e-azure-v2-self-managed |
2 similar comments
|
/test e2e-azure-v2-self-managed |
|
/test e2e-azure-v2-self-managed |
|
@mgencur: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
This change incorporated in #9073. Closing. |
1 participant
What this PR does / why we need it:
Related to #9073 .
Test co-locating the test with other tests.
Which issue(s) this PR fixes:
Fixes
Special notes for your reviewer:
Checklist:
Summary by CodeRabbit