Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/docs-build-reusable.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
- uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
- uses: actions/setup-python@5fda3b95a4ea91299a34e894583c3862153e4b97 # v7.0.0
with:
python-version: '3.x'
pip-install: '-r docs/requirements.txt'
Comment on lines +18 to 21

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== workflow snippet =="
cat -n .github/workflows/docs-build-reusable.yaml | sed -n '1,80p'

echo
echo "== search for pip-install usage =="
rg -n "pip-install|setup-python@5fda3b95a4ea91299a34e894583c3862153e4b97" .github/workflows . -g '!**/.git/**'

echo
echo "== pinned action metadata =="
python3 - <<'PY'
import urllib.request
url = "https://raw.githubusercontent.com/actions/setup-python/5fda3b95a4ea91299a34e894583c3862153e4b97/action.yml"
print(urllib.request.urlopen(url, timeout=20).read().decode())
PY

Repository: openshift/hypershift

Length of output: 4226


🏁 Script executed:

#!/bin/bash
set -euo pipefail

python3 - <<'PY'
import ssl, urllib.request
url = "https://raw.githubusercontent.com/actions/setup-python/5fda3b95a4ea91299a34e894583c3862153e4b97/action.yml"
ctx = ssl.create_default_context()
ctx.check_hostname = False
ctx.verify_mode = ssl.CERT_NONE
print(urllib.request.urlopen(url, context=ctx, timeout=20).read().decode())
PY

Repository: openshift/hypershift

Length of output: 2661


🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== docs requirements =="
if [ -f docs/requirements.txt ]; then
  cat -n docs/requirements.txt
else
  echo "docs/requirements.txt not found"
fi

echo
echo "== docs workflow references =="
rg -n "mkdocs|pip install|requirements.txt|setup-python|pip-install|pip-version" .github/workflows docs -g '!**/.git/**'

echo
echo "== workflow files under docs build =="
git ls-files .github/workflows | sed -n '/docs/p'

Repository: openshift/hypershift

Length of output: 3399


Install docs dependencies explicitly

actions/setup-python does not accept pip-install, so line 21 is a no-op. Add a separate python -m pip install -r docs/requirements.txt step before mkdocs build.

🧰 Tools
🪛 zizmor (1.26.1)

[warning] 21-21: usage of GitHub Actions misfeatures (misfeature): installs packages in a brittle manner

(misfeature)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/docs-build-reusable.yaml around lines 18 - 21, Remove the
unsupported pip-install input from the actions/setup-python step and add a
separate shell step running python -m pip install -r docs/requirements.txt
before the mkdocs build step in the workflow.

Expand Down