OCPBUGS-78310: fix(cli): initialize controller-runtime logger in product-cli

[hypershift-jira-solve-ci]

What this PR does / why we need it:

The hcp CLI (product-cli) never called ctrl.SetLogger() before using controller-runtime's client.New() via cmd/util.GetClient(). This caused a noisy [controller-runtime] log.SetLogger(...) was never called warning with a full goroutine stack trace on every hcp create cluster invocation, degrading the customer experience.

This PR adds the same ctrl.SetLogger(zap.New(zap.JSONEncoder(...))) call used by every other binary in the repo (hypershift-operator, control-plane-operator, ignition-server, etc.) to product-cli/main.go, early in main() before any cobra command execution.

Which issue(s) this PR fixes:

Fixes https://redhat.atlassian.net/browse/OCPBUGS-78310

Special notes for your reviewer:

This follows the exact same logger initialization pattern already established in hypershift-operator/main.go, control-plane-operator/main.go, ignition-server/cmd/start.go, and other binaries in this repo. The only binary that was missing it was product-cli.

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

---

Always review AI generated responses prior to use.
Generated with Claude Code via openshift-developer plugin

---

Note: This PR was auto-generated by the jira-agent periodic CI job in response to OCPBUGS-78310. See the full report for token usage, cost breakdown, and detailed phase output.

Summary by CodeRabbit

• Bug Fixes
  • Improved application logging so startup and runtime messages now use a consistent JSON format with standardized RFC3339 timestamps.
  • Added global logger initialization to ensure consistent diagnostic output across the application.
• Tests
  • Added coverage to validate that the logger produces the expected JSON structure and fields.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@hypershift-jira-solve-ci[bot]: This pull request references Jira Issue OCPBUGS-78310, which is invalid:

• expected the bug to target either version "5.0." or "openshift-5.0.", but it targets "4.22.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

What this PR does / why we need it:

The hcp CLI (product-cli) never called ctrl.SetLogger() before using controller-runtime's client.New() via cmd/util.GetClient(). This caused a noisy [controller-runtime] log.SetLogger(...) was never called warning with a full goroutine stack trace on every hcp create cluster invocation, degrading the customer experience.

This PR adds the same ctrl.SetLogger(zap.New(zap.JSONEncoder(...))) call used by every other binary in the repo (hypershift-operator, control-plane-operator, ignition-server, etc.) to product-cli/main.go, early in main() before any cobra command execution.

Which issue(s) this PR fixes:

Fixes https://redhat.atlassian.net/browse/OCPBUGS-78310

Special notes for your reviewer:

This follows the exact same logger initialization pattern already established in hypershift-operator/main.go, control-plane-operator/main.go, ignition-server/cmd/start.go, and other binaries in this repo. The only binary that was missing it was product-cli.

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

---

Always review AI generated responses prior to use.
Generated with Claude Code via openshift-developer plugin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 8d81b766-e0ad-4046-aac3-d42b8ee0e243

📥 Commits

Reviewing files that changed from the base of the PR and between e2efcd9 and 9fa3dee.

📒 Files selected for processing (2)

• product-cli/main.go
• product-cli/main_test.go

🚧 Files skipped from review as they are similar to previous changes (1)

• product-cli/main.go

---

📝 Walkthrough

Walkthrough

product-cli/main.go now builds a zap JSON logger with RFC3339 timestamps and registers it with controller-runtime during startup via ctrl.SetLogger(newLogger()). A new test in product-cli/main_test.go writes a log entry, parses the output as JSON, and checks the timestamp, message, and key fields.

🚥 Pre-merge checks | ✅ 11

✅ Passed checks (11 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: initializing the controller-runtime logger in product-cli.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The only added test uses TestNewLogger with the standard testing package; no Ginkgo titles or dynamic identifiers are present.
Test Structure And Quality	✅ Passed	The new unit test is focused on one logger-configuration behavior, uses no cluster resources or waits, and has clear failure messages; Ginkgo-specific concerns don’t apply.
Topology-Aware Scheduling Compatibility	✅ Passed	Only logger initialization and a unit test were added in product-cli; no manifests, replicas, affinity, selectors, or other scheduling constraints were introduced.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Only a unit test was added; no new Ginkgo/e2e tests or network-facing code were introduced.
No-Weak-Crypto	✅ Passed	Changed files only add controller-runtime logger setup and a logger format test; no weak crypto, custom crypto, or secret comparisons are present.
Container-Privileges	✅ Passed	Diff only touches product-cli Go code/tests; no container/K8s manifests or securityContext fields (privileged, hostPID/network/IPC, SYS_ADMIN, allowPrivilegeEscalation).
No-Sensitive-Data-In-Logs	✅ Passed	The PR only initializes controller-runtime logging and tests JSON formatting; it adds no log statements containing passwords, tokens, PII, or customer data.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[bryan-cox]

/jira refresh

[openshift-ci-robot]

@bryan-cox: This pull request references Jira Issue OCPBUGS-78310, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wewang@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[bryan-cox]

/area cli

[codecov]

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.46%. Comparing base (488ef0e) to head (9fa3dee).
⚠️ Report is 86 commits behind head on main.

Files with missing lines	Patch %	Lines
product-cli/main.go	75.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8955      +/-   ##
==========================================
+ Coverage   43.28%   43.46%   +0.18%     
==========================================
  Files         771      771              
  Lines       95506    95726     +220     
==========================================
+ Hits        41335    41603     +268     
+ Misses      51287    51236      -51     
- Partials     2884     2887       +3     

Files with missing lines	Coverage Δ
product-cli/main.go	16.21% <75.00%> (+16.21%)	⬆️

... and 13 files with indirect coverage changes

Flag	Coverage Δ
cmd-support	37.12% <ø> (+0.45%)	⬆️
cpo-hostedcontrolplane	45.21% <ø> (-0.11%)	⬇️
cpo-other	45.10% <ø> (ø)
hypershift-operator	53.65% <ø> (+0.07%)	⬆️
other	32.12% <75.00%> (+0.42%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[bryan-cox]

Codecov/patch is failing. You need to add unit tests.

[bryan-cox]

/test address-review-comments

[hypershift-jira-solve-ci]

Review agent triggered. View job

[openshift-ci-robot]

@hypershift-jira-solve-ci[bot]: This pull request references Jira Issue OCPBUGS-78310, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wewang@redhat.com), skipping review request.

Details

In response to this:

What this PR does / why we need it:

The hcp CLI (product-cli) never called ctrl.SetLogger() before using controller-runtime's client.New() via cmd/util.GetClient(). This caused a noisy [controller-runtime] log.SetLogger(...) was never called warning with a full goroutine stack trace on every hcp create cluster invocation, degrading the customer experience.

This PR adds the same ctrl.SetLogger(zap.New(zap.JSONEncoder(...))) call used by every other binary in the repo (hypershift-operator, control-plane-operator, ignition-server, etc.) to product-cli/main.go, early in main() before any cobra command execution.

Which issue(s) this PR fixes:

Fixes https://redhat.atlassian.net/browse/OCPBUGS-78310

Special notes for your reviewer:

This follows the exact same logger initialization pattern already established in hypershift-operator/main.go, control-plane-operator/main.go, ignition-server/cmd/start.go, and other binaries in this repo. The only binary that was missing it was product-cli.

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

---

Always review AI generated responses prior to use.
Generated with Claude Code via openshift-developer plugin

---

Note: This PR was auto-generated by the jira-agent periodic CI job in response to OCPBUGS-78310. See the full report for token usage, cost breakdown, and detailed phase output.

Summary by CodeRabbit

• Bug Fixes
• Improved application logging so startup and runtime messages now use a consistent JSON format with standardized RFC3339 timestamps.
• Added global logger initialization to ensure consistent diagnostic output across the application.
• Tests
• Added coverage to validate that the logger produces the expected JSON structure and fields.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aks
/test e2e-aws
/test e2e-aws-upgrade-hypershift-operator
/test e2e-azure-v2-self-managed
/test e2e-kubevirt-aws-ovn-reduced
/test e2e-v2-aws
/test e2e-v2-gke

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, hypershift-jira-solve-ci[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [bryan-cox]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cwbotbot]

Test Results

e2e-aws

• Status: ✅ PASS
• Started: 2026-07-09T02:52:10Z
• View Job
• View Job History

e2e-aks

• Status: ✅ PASS
• Started: 2026-07-10T15:39:38Z
• View Job
• View Job History

[hypershift-jira-solve-ci]

AI Test Failure Analysis

Job: pull-ci-openshift-hypershift-main-e2e-aks | Build: 2074643676700610560 | Cost: $3.1695715 | Failed step: hypershift-azure-run-e2e

View full analysis report

---

_{Generated by hypershift-analyze-e2e-failure post-step using Claude claude-opus-4-6}

[bryan-cox]

/retest

[hypershift-jira-solve-ci]

AI Test Failure Analysis

Job: pull-ci-openshift-hypershift-main-e2e-aks | Build: 2074812071656034304 | Cost: $2.6346174999999996 | Failed step: hypershift-azure-run-e2e

View full analysis report

---

_{Generated by hypershift-analyze-e2e-failure post-step using Claude claude-opus-4-6}

[hypershift-jira-solve-ci]

AI Test Failure Analysis

Job: pull-ci-openshift-hypershift-main-e2e-aws | Build: 2074812071697977344 | Cost: $1.8297952500000005 | Failed step: hypershift-aws-run-e2e-nested

View full analysis report

---

_{Generated by hypershift-analyze-e2e-failure post-step using Claude claude-opus-4-6}

[bryan-cox]

/retest

[hypershift-jira-solve-ci]

The PR only touches product-cli/main.go and product-cli/main_test.go — completely unrelated to the CI step infrastructure failure. This is a transient infrastructure issue.

Now I have all the evidence needed. Here is the final report:

Test Failure Analysis Complete

Job Information

• Prow Job: pull-ci-openshift-hypershift-main-e2e-aks
• Build ID: 2075050302846799872
• Target: e2e-aks
• PR: OCPBUGS-78310: fix(cli): initialize controller-runtime logger in product-cli #8955 (OCPBUGS-78310: fix(cli): initialize controller-runtime logger in product-cli)
• Failed Steps: 1 (hypershift-install, pre phase)

Test Failure Analysis

Error

error: unable to read URL "https://raw.githubusercontent.com/prometheus-operator/prometheus-operator/main/example/prometheus-operator-crd/monitoring.coreos.com_prometheusrules.yaml", server reported 429 Too Many Requests, status code=429

Summary

The e2e-aks job failed during the pre phase at the hypershift-install step due to a transient GitHub rate-limit (HTTP 429 Too Many Requests). The step script fetches Prometheus Operator CRDs directly from raw.githubusercontent.com using oc apply -f <URL>. The first CRD (servicemonitors.yaml) was applied successfully, but the second (prometheusrules.yaml) was rejected by GitHub's CDN with a 429 status. Because the script runs under set -eux with no retry logic, the step immediately aborted. No test code ever executed — the failure occurred before any cluster was provisioned or any HyperShift operator was installed. This failure is completely unrelated to PR #8955, which only modifies product-cli/main.go and product-cli/main_test.go.

Root Cause

The root cause is a transient GitHub raw content CDN rate-limit combined with missing retry logic in the hypershift-install CI step script.

Failure chain:

1. The hypershift-install step (pre phase) runs under set -eux, meaning any non-zero exit code immediately terminates the script.
2. The script issues sequential oc apply -f commands to fetch Prometheus Operator CRDs directly from raw.githubusercontent.com.
3. The first CRD (monitoring.coreos.com_servicemonitors.yaml) downloaded and applied successfully.
4. The second CRD (monitoring.coreos.com_prometheusrules.yaml) was rejected by GitHub with HTTP 429 (Too Many Requests) — likely due to concurrent CI jobs across the OpenShift ecosystem all hitting the same GitHub raw content endpoint.
5. oc apply exited with code 1, and set -e immediately terminated the step.
6. Since this was a pre-phase step, the entire job was aborted — no cluster was ever provisioned, and no actual e2e tests ran.

Why this is not related to PR #8955:

• PR OCPBUGS-78310: fix(cli): initialize controller-runtime logger in product-cli #8955 only changes product-cli/main.go and product-cli/main_test.go (initializing the controller-runtime logger).
• The failure occurred in the CI step infrastructure (hypershift-install-commands.sh in the openshift/release repository), which is entirely outside the scope of this PR.
• The same failure would occur on any PR running the e2e-aks job when GitHub's CDN rate-limits the request.

Recommendations

1. Retest the job — This is a transient infrastructure failure. Simply re-running /test e2e-aks should succeed once GitHub's rate limit resets.

2. Fix the CI step script (openshift/release) — The hypershift-install-commands.sh script should add retry logic around the oc apply -f calls that fetch CRDs from external URLs. A simple retry-with-backoff wrapper (e.g., 3 retries with 10s/30s/60s delays) would make this step resilient to transient CDN rate-limits. This affects the step at: ci-operator/step-registry/hypershift/install/hypershift-install-commands.sh.

3. Consider vendoring CRDs — Instead of fetching CRDs from raw.githubusercontent.com at runtime, consider vendoring the Prometheus Operator CRDs into the repository or the CI step image. This eliminates the external dependency entirely and prevents all rate-limit and network-related failures.

4. No code changes needed in PR OCPBUGS-78310: fix(cli): initialize controller-runtime logger in product-cli #8955 — The PR's changes to product-cli/main.go are correct and unrelated to this failure.

Evidence

Evidence	Detail
Failed step	e2e-aks-hypershift-install (pre phase, 36s duration)
Error message	error: unable to read URL "...monitoring.coreos.com_prometheusrules.yaml", server reported 429 Too Many Requests, status code=429
Successful prior step	oc apply -f ...monitoring.coreos.com_servicemonitors.yaml → customresourcedefinition.apiextensions.k8s.io/servicemonitors.monitoring.coreos.com created
Script exit behavior	set -eux — immediate abort on any failure, no retry logic
CI step reference	hypershift-install in openshift/release
PR #8955 changed files	product-cli/main.go, product-cli/main_test.go (unrelated to CI infra)
Failure timestamp	2026-07-09T03:17:36Z
Phase classification	Pre phase (installation/setup) — no tests executed
Job result reason	executing_graph:step_failed:utilizing_lease:executing_test:utilizing_ip_pool:executing_test:executing_multi_stage_test

---

[enxebre]

/retest

[enxebre]

needs verified label @bryan-cox

[bryan-cox]

/verified by @bryan-cox

See test report here https://bryan-cox.github.io/architectural-artifact-sharing/test-verification-report-ocpbugs-78310/index.html

[openshift-ci-robot]

@bryan-cox: This PR has been marked as verified by @bryan-cox.

Details

In response to this:

/verified by @bryan-cox

See test report here https://bryan-cox.github.io/architectural-artifact-sharing/test-verification-report-ocpbugs-78310/index.html

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@hypershift-jira-solve-ci: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@hypershift-jira-solve-ci[bot]: Jira Issue Verification Checks: Jira Issue OCPBUGS-78310
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-78310 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

What this PR does / why we need it:

The hcp CLI (product-cli) never called ctrl.SetLogger() before using controller-runtime's client.New() via cmd/util.GetClient(). This caused a noisy [controller-runtime] log.SetLogger(...) was never called warning with a full goroutine stack trace on every hcp create cluster invocation, degrading the customer experience.

This PR adds the same ctrl.SetLogger(zap.New(zap.JSONEncoder(...))) call used by every other binary in the repo (hypershift-operator, control-plane-operator, ignition-server, etc.) to product-cli/main.go, early in main() before any cobra command execution.

Which issue(s) this PR fixes:

Fixes https://redhat.atlassian.net/browse/OCPBUGS-78310

Special notes for your reviewer:

This follows the exact same logger initialization pattern already established in hypershift-operator/main.go, control-plane-operator/main.go, ignition-server/cmd/start.go, and other binaries in this repo. The only binary that was missing it was product-cli.

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

---

Always review AI generated responses prior to use.
Generated with Claude Code via openshift-developer plugin

---

Note: This PR was auto-generated by the jira-agent periodic CI job in response to OCPBUGS-78310. See the full report for token usage, cost breakdown, and detailed phase output.

Summary by CodeRabbit

• Bug Fixes
• Improved application logging so startup and runtime messages now use a consistent JSON format with standardized RFC3339 timestamps.
• Added global logger initialization to ensure consistent diagnostic output across the application.
• Tests
• Added coverage to validate that the logger produces the expected JSON structure and fields.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.