Skip to content

ARO-24037: gate cloud config on hash to prevent serving stale content - #8946

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
twolff-gh:fix-ignition-cloud-config-hash-gate
Jul 20, 2026
Merged

openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
twolff-gh:fix-ignition-cloud-config-hash-gate

fix(control-plane-operator): validate cloud config hash in ignition s…

077d180
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 20, 2026 in 1s

44.15% (+0.01%) compared to 3eefe36

View this Pull Request on Codecov

44.15% (+0.01%) compared to 3eefe36

Details

Codecov Report

❌ Patch coverage is 80.18868% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.15%. Comparing base (3eefe36) to head (077d180).
⚠️ Report is 57 commits behind head on main.

Files with missing lines Patch % Lines
...ition-server/controllers/tokensecret_controller.go 73.33% 5 Missing and 3 partials ⚠️
...erator/controllers/nodepool/nodepool_controller.go 74.07% 6 Missing and 1 partial ⚠️
hypershift-operator/controllers/nodepool/token.go 57.14% 2 Missing and 1 partial ⚠️
...ition-server/controllers/local_ignitionprovider.go 77.77% 2 Missing ⚠️
ignition-server/cmd/run_local_ignitionprovider.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8946      +/-   ##
==========================================
+ Coverage   44.13%   44.15%   +0.01%     
==========================================
  Files         772      779       +7     
  Lines       96260    98056    +1796     
==========================================
+ Hits        42488    43294     +806     
- Misses      50826    51729     +903     
- Partials     2946     3033      +87     
Files with missing lines Coverage Δ
hypershift-operator/controllers/nodepool/config.go 84.29% <100.00%> (+0.95%) ⬆️
ignition-server/controllers/cache.go 100.00% <ø> (ø)
support/util/util.go 46.07% <100.00%> (+4.02%) ⬆️
ignition-server/cmd/run_local_ignitionprovider.go 0.00% <0.00%> (ø)
...ition-server/controllers/local_ignitionprovider.go 39.53% <77.77%> (+0.50%) ⬆️
hypershift-operator/controllers/nodepool/token.go 82.15% <57.14%> (-0.56%) ⬇️
...erator/controllers/nodepool/nodepool_controller.go 44.43% <74.07%> (+1.08%) ⬆️
...ition-server/controllers/tokensecret_controller.go 67.82% <73.33%> (+8.64%) ⬆️

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.