Skip to content

Remove address-review-comments GHA workflow - #8942

Closed
bryan-cox wants to merge 1 commit into
openshift:mainfrom
bryan-cox:remove-address-review-comments-gha
Closed

Remove address-review-comments GHA workflow#8942
bryan-cox wants to merge 1 commit into
openshift:mainfrom
bryan-cox:remove-address-review-comments-gha

Conversation

@bryan-cox

@bryan-cox bryan-cox commented Jul 6, 2026

Copy link
Copy Markdown
Member

Summary

  • Removes the /address-review-comments GitHub Actions workflow — the on-demand GHA slash command for addressing PR review comments
  • Updates documentation to remove references to the GHA-based trigger and the periodic-review-agent
  • Regenerates aggregated-docs.md

The Prow presubmit (/test address-review-comments) and its step registry are unaffected — Alberto is converting it to use gangway.

The reusable-claude-on-pr.yaml shared workflow is kept (still used by /rebase and /restructure-commits).

Test plan

  • Docs build succeeds
  • No broken references in documentation

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated workflow and CI docs to remove references to an automated review-comment handling flow.
    • Simplified delivery diagrams and guidance so review feedback now moves directly into testing or human review.
    • Removed the related slash command from the command reference and trimmed obsolete agent limitations.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci openshift-ci Bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. do-not-merge/needs-area labels Jul 6, 2026
…-agent references

Remove the `/address-review-comments` slash command workflow and all
references to the periodic-review-agent CI job:

- Delete .github/workflows/address-review-comments.yaml
- Remove `/address-review-comments` from PR slash commands table
- Remove periodic-review-agent and address-review-comments rows from
  AI-assisted jobs overview
- Remove entire "Review Agent" section from ai-assisted-ci-jobs.md
- Remove "Triggering Review Agent On-Demand" section
- Update Limitations to remove review-agent rate limits
- Remove `/utils:address-reviews` from agentic-sdlc.md flowcharts
  and tables
- Regenerate aggregated-docs.md

The address-review presubmit workflow still exists for automated
review comment handling on agent-created PRs.
@openshift-ci
openshift-ci Bot requested review from Nirshal and jparrill July 6, 2026 17:47
@openshift-ci openshift-ci Bot added area/ai Indicates the PR includes changes related to AI - Claude agents, Cursor rules, etc. area/api Indicates the PR includes changes for the API area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/documentation Indicates the PR includes changes for documentation area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release area/platform/aws PR/issue for AWS (AWSPlatform) platform area/platform/azure PR/issue for Azure (AzurePlatform) platform area/platform/gcp PR/issue for GCP (GCPPlatform) platform area/platform/ibmcloud PR/issue for IBMCloud (IBMCloudPlatform) platform area/platform/kubevirt PR/issue for KubeVirt (KubevirtPlatform) platform area/platform/none PR/issue for None (NonePlatform) platform - user-supplied infrastructure area/platform/openstack PR/issue for OpenStack (OpenStackPlatform) platform area/platform/powervs PR/issue for PowerVS (PowerVSPlatform) platform area/testing Indicates the PR includes changes for e2e testing and removed do-not-merge/needs-area labels Jul 6, 2026
@bryan-cox
bryan-cox force-pushed the remove-address-review-comments-gha branch from 1db8a70 to cce79d6 Compare July 6, 2026 17:48
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2026
@bryan-cox bryan-cox closed this Jul 6, 2026
@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 5bb8a463-a30e-4bda-a215-4f345dcf0c2f

📥 Commits

Reviewing files that changed from the base of the PR and between dda6055 and cce79d6.

⛔ Files ignored due to path filters (1)
  • docs/content/reference/aggregated-docs.md is excluded by !docs/content/reference/aggregated-docs.md
📒 Files selected for processing (4)
  • .github/workflows/address-review-comments.yaml
  • docs/content/how-to/agentic-sdlc.md
  • docs/content/how-to/ci/ai-assisted-ci-jobs.md
  • docs/content/how-to/ci/github-actions.md

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting


📝 Walkthrough

Walkthrough

This PR removes the address-review-comments GitHub Actions workflow along with all associated documentation. The workflow file .github/workflows/address-review-comments.yaml is deleted. Documentation in agentic-sdlc.md is updated to remove the address-feedback step from the Phase 2 Delivery and Hands-off Delivery diagrams and tables. The ai-assisted-ci-jobs.md file has its Review Agent section, overview table rows, and rate-limit bullets updated to drop Review Agent references. The github-actions.md PR Slash Commands table no longer lists the /address-review-comments command.

Possibly related PRs

  • openshift/hypershift#8934: Modifies the same .github/workflows/address-review-comments.yaml file's prompt/behavior that this PR removes entirely.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2026
@hypershift-jira-solve-ci

Copy link
Copy Markdown
Contributor

I now have the full picture. Here is the analysis:

Test Failure Analysis Complete

Job Information

  • Prow Job: pull-ci-openshift-hypershift-main-images
  • Build ID: 2074188246279000064
  • Target: images
  • PR: Remove address-review-comments GHA workflow #8942Remove address-review-comments GHA workflow
  • Job State: failure
  • Duration: 12 seconds (17:46:29Z – 17:46:41Z)
  • Tide Status: error — Not mergeable. PR has a merge conflict.

Test Failure Analysis

Error

CONFLICT (modify/delete): .github/workflows/address-review-comments.yaml deleted in 1db8a70 and modified in HEAD.
CONFLICT (content): Merge conflict in .github/workflows/reusable-claude-on-pr.yaml
CONFLICT (content): Merge conflict in docs/content/how-to/ci/github-actions.md
CONFLICT (content): Merge conflict in docs/content/reference/aggregated-docs.md
Automatic merge failed; fix conflicts and then commit the result.
# Error: exit status 1

Summary

The ci/prow/images job and all other Prow jobs on PR #8942 failed during the git clone/merge phase — before any code was built or tested. The PR's original commit (1db8a70) was based on a version of main that did not include recently-merged PR #8934 (CNTRLPLANE-3771: fix /rebase GHA workflow for fork PRs), which modified three of the same files. When Prow attempted to merge the PR branch into current main (dda6055), git detected 4 merge conflicts across workflow and docs files. The branch was subsequently force-pushed at 17:48:21Z with a rebased commit (cce79d6), resolving the conflicts. New CI jobs are now running on the updated commit. The tide error state on the old commit accurately reported "Not mergeable. PR has a merge conflict." On the new commit, tide now reports the PR needs lgtm and jira/valid-reference labels — standard merge-gating requirements, not failures.

Root Cause

Git merge conflicts caused by concurrent PRs modifying the same files.

PR #8942 was created at 17:44:28Z on 2026-07-06 with commit 1db8a70, branched from a version of main that predated PR #8934. PR #8934 (CNTRLPLANE-3771: fix /rebase GHA workflow for fork PRs) was merged into main at 16:51:20Z — approximately 53 minutes before PR #8942 was opened. PR #8934 modified:

  • .github/workflows/address-review-comments.yaml
  • .github/workflows/reusable-claude-on-pr.yaml
  • .github/workflows/rebase.yaml
  • .github/workflows/restructure-commits.yaml

PR #8942 deletes .github/workflows/address-review-comments.yaml and modifies .github/workflows/reusable-claude-on-pr.yaml, docs/content/how-to/ci/github-actions.md, and docs/content/reference/aggregated-docs.md. The overlapping changes to address-review-comments.yaml (delete vs. modify) and reusable-claude-on-pr.yaml (both modified) produced irreconcilable merge conflicts.

The 4 specific conflicts were:

  1. .github/workflows/address-review-comments.yaml — PR Remove address-review-comments GHA workflow #8942 deletes it; PR CNTRLPLANE-3771: fix /rebase GHA workflow for fork PRs #8934 modified it on main (modify/delete conflict)
  2. .github/workflows/reusable-claude-on-pr.yaml — both PRs modified this file (content conflict)
  3. docs/content/how-to/ci/github-actions.md — content conflict with changes on main
  4. docs/content/reference/aggregated-docs.md — content conflict with changes on main

The PR author resolved the issue by force-pushing a rebased commit (cce79d6) at 17:48:21Z. New Prow CI jobs have been triggered on the rebased commit and are currently pending.

Recommendations
  1. No action needed for the merge conflict — the author already force-pushed a rebased commit (cce79d6) that resolves all 4 conflicts. New CI jobs are running.
  2. Address remaining tide requirements — the PR currently needs lgtm and jira/valid-reference labels before tide will merge it. Get a reviewer to /lgtm and either associate a JIRA ticket or get the jira/valid-reference label applied.
  3. Monitor new CI runs — the ci/prow/images, ci/prow/okd-scos-images, and ci/prow/verify-deps jobs are currently pending on the new commit. These should pass now that the merge conflicts are resolved, as the PR only removes a GHA workflow file and updates documentation.
Evidence
Evidence Detail
Failed job pull-ci-openshift-hypershift-main-images build 2074188246279000064 — failed in 12s during clone phase
Failure phase Git merge (pre-build) — git merge --no-ff 1db8a70 into main at dda6055
Conflicting files .github/workflows/address-review-comments.yaml (delete/modify), .github/workflows/reusable-claude-on-pr.yaml (content), docs/content/how-to/ci/github-actions.md (content), docs/content/reference/aggregated-docs.md (content)
Concurrent PR PR #8934 merged at 16:51:20Z modified address-review-comments.yaml and reusable-claude-on-pr.yaml
Tide status (old commit) error"Not mergeable. PR has a merge conflict."
Tide status (new commit) pending — needs lgtm and jira/valid-reference labels (normal merge gating)
Force push Branch force-pushed at 17:48:21Z with rebased commit cce79d60f859
Aborted jobs ci/prow/security, ci/prow/verify-deps, ci/prow/okd-scos-images, ci/prow/e2e-aws-override, ci/prow/e2e-aks-override — all aborted by trigger plugin after the force push
New CI status 3 jobs (images, okd-scos-images, verify-deps) triggered on new commit — currently pending

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ai Indicates the PR includes changes related to AI - Claude agents, Cursor rules, etc. area/api Indicates the PR includes changes for the API area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/documentation Indicates the PR includes changes for documentation area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release area/platform/aws PR/issue for AWS (AWSPlatform) platform area/platform/azure PR/issue for Azure (AzurePlatform) platform area/platform/gcp PR/issue for GCP (GCPPlatform) platform area/platform/ibmcloud PR/issue for IBMCloud (IBMCloudPlatform) platform area/platform/kubevirt PR/issue for KubeVirt (KubevirtPlatform) platform area/platform/none PR/issue for None (NonePlatform) platform - user-supplied infrastructure area/platform/openstack PR/issue for OpenStack (OpenStackPlatform) platform area/platform/powervs PR/issue for PowerVS (PowerVSPlatform) platform area/testing Indicates the PR includes changes for e2e testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant