CNTRLPLANE-3696: Remove stale TODO about ImagePullPolicy in DNS operator

[hypershift-jira-solve-ci]

What this PR does / why we need it:

Removes a stale TODO comment in the DNS operator that asked to enforce ImagePullPolicy in component defaults. This enforcement is already handled by enforceImagePullPolicy in the controlplane-component framework, making the TODO outdated and misleading.

Which issue(s) this PR fixes:

Fixes https://redhat.atlassian.net/browse/CNTRLPLANE-3696

Special notes for your reviewer:

This is a comment-only change with no functional impact.

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

---

Always review AI generated responses prior to use.
Generated with Claude Code via openshift-developer plugin

---

Note: This PR was auto-generated by the jira-agent periodic CI job in response to CNTRLPLANE-3696. See the full report for token usage, cost breakdown, and detailed phase output.

Summary by CodeRabbit

• Chores
  • Cleaned up an internal comment in the DNS operator deployment handling.
  • No user-facing behavior changed; existing image pull settings remain the same.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@hypershift-jira-solve-ci[bot]: This pull request references CNTRLPLANE-3696 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:

Removes a stale TODO comment in the DNS operator that asked to enforce ImagePullPolicy in component defaults. This enforcement is already handled by enforceImagePullPolicy in the controlplane-component framework, making the TODO outdated and misleading.

Which issue(s) this PR fixes:

Fixes https://redhat.atlassian.net/browse/CNTRLPLANE-3696

Special notes for your reviewer:

This is a comment-only change with no functional impact.

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

---

Always review AI generated responses prior to use.
Generated with Claude Code via openshift-developer plugin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 43385a15-af69-40a5-bb5a-e1df6848e1fc

📥 Commits

Reviewing files that changed from the base of the PR and between d174956 and 9f2b6fe.

📒 Files selected for processing (1)

• control-plane-operator/controllers/hostedcontrolplane/v2/dnsoperator/deployment.go

💤 Files with no reviewable changes (1)

• control-plane-operator/controllers/hostedcontrolplane/v2/dnsoperator/deployment.go

---

📝 Walkthrough

Walkthrough

This change removes a single inline TODO comment from the adaptDeployment function in the DNS operator deployment controller. The comment previously noted a need to enforce ImagePullPolicy in component defaults. No functional or logic changes were made; the existing ImagePullPolicy = PullIfNotPresent assignment and related container setup remain unchanged.

Compact metadata

• Files changed: 1
• Lines changed: +0/-1
• Estimated review effort: Low

Related issues: None specified

Related PRs: None specified

Suggested labels: cleanup, low-risk

Suggested reviewers: None specified

Poem
A rabbit hopped through lines of code,
Found a TODO on a well-worn road,
"This task is done," it gave a nod,
And swept the comment, tidy and odd,
One less note for future eyes to plod.

🚥 Pre-merge checks | ✅ 11

✅ Passed checks (11 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the comment-only change removing the stale DNS operator TODO.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	No test definitions were changed; the only modified file is deployment.go and it contains no Ginkgo titles.
Test Structure And Quality	✅ Passed	Only a comment-only change in production code was modified; no Ginkgo test code was added or altered, so the test-quality check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	The PR only deletes a stale TODO comment in dnsoperator/deployment.go; the deployment logic and scheduling behavior are unchanged.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Only a comment was removed in deployment.go; no new Ginkgo e2e tests or networking code were added, so the IPv6/disconnected check is not applicable.
No-Weak-Crypto	✅ Passed	The only code change removes a TODO comment; the file contains no weak-crypto APIs, custom crypto, or secret comparisons.
Container-Privileges	✅ Passed	Comment-only diff in deployment.go; no privilege-related K8s fields or securityContext changes were introduced.
No-Sensitive-Data-In-Logs	✅ Passed	Comment-only diff; no logging was added, and the dnsoperator package search found no log calls exposing sensitive data.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[enxebre]

/approve
/lgtm

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aks
/test e2e-aws
/test e2e-aws-upgrade-hypershift-operator
/test e2e-azure-v2-self-managed
/test e2e-kubevirt-aws-ovn-reduced
/test e2e-v2-aws
/test e2e-v2-gke

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre, hypershift-jira-solve-ci[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [enxebre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[celebdor]

/verified by celebdor visually
/override "ci/prow/e2e-aks"
/override "ci/prow/e2e-aws"
/override "ci/prow/e2e-aws-upgrade-hypershift-operator"
/override "ci/prow/e2e-azure-v2-self-managed"
/override "ci/prow/e2e-kubevirt-aws-ovn-reduced"
/override "ci/prow/e2e-v2-aws"
/override "ci/prow/e2e-v2-gke"

[openshift-ci-robot]

@celebdor: This PR has been marked as verified by celebdor visually.

Details

In response to this:

/verified by celebdor visually
/override "ci/prow/e2e-aks"
/override "ci/prow/e2e-aws"
/override "ci/prow/e2e-aws-upgrade-hypershift-operator"
/override "ci/prow/e2e-azure-v2-self-managed"
/override "ci/prow/e2e-kubevirt-aws-ovn-reduced"
/override "ci/prow/e2e-v2-aws"
/override "ci/prow/e2e-v2-gke"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@celebdor: Overrode contexts on behalf of celebdor: ci/prow/e2e-aks, ci/prow/e2e-aws, ci/prow/e2e-aws-upgrade-hypershift-operator, ci/prow/e2e-azure-v2-self-managed, ci/prow/e2e-kubevirt-aws-ovn-reduced, ci/prow/e2e-v2-aws, ci/prow/e2e-v2-gke

Details

In response to this:

/verified by celebdor visually
/override "ci/prow/e2e-aks"
/override "ci/prow/e2e-aws"
/override "ci/prow/e2e-aws-upgrade-hypershift-operator"
/override "ci/prow/e2e-azure-v2-self-managed"
/override "ci/prow/e2e-kubevirt-aws-ovn-reduced"
/override "ci/prow/e2e-v2-aws"
/override "ci/prow/e2e-v2-gke"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.27%. Comparing base (488ef0e) to head (9f2b6fe).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8923      +/-   ##
==========================================
- Coverage   43.28%   43.27%   -0.01%     
==========================================
  Files         771      771              
  Lines       95506    95505       -1     
==========================================
- Hits        41335    41334       -1     
  Misses      51287    51287              
  Partials     2884     2884              

Files with missing lines	Coverage Δ
...rs/hostedcontrolplane/v2/dnsoperator/deployment.go	100.00% <ø> (ø)

Flag	Coverage Δ
cmd-support	36.67% <ø> (ø)
cpo-hostedcontrolplane	45.31% <ø> (-0.01%)	⬇️
cpo-other	45.10% <ø> (ø)
hypershift-operator	53.58% <ø> (ø)
other	31.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[openshift-ci]

@hypershift-jira-solve-ci[bot]: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[hypershift-jira-solve-ci]

AI Test Failure Analysis

Job: pull-ci-openshift-hypershift-main-e2e-aws | Build: 2073062850233896960 | Cost: $2.4697369999999994 | Failed step: hypershift-aws-run-e2e-nested

View full analysis report

---

_{Generated by hypershift-analyze-e2e-failure post-step using Claude claude-opus-4-6}

[hypershift-jira-solve-ci]

AI Test Failure Analysis

Job: pull-ci-openshift-hypershift-main-e2e-aks | Build: 2073062850208731136 | Cost: $3.089591499999999 | Failed step: hypershift-azure-run-e2e

View full analysis report

---

_{Generated by hypershift-analyze-e2e-failure post-step using Claude claude-opus-4-6}