NO-JIRA: chore: update github actions runner image to go 1.26.4 - #8888
Conversation
this is necessary to enable linting support for an PR upgrading hypershift images to golang 1.26.
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
Skipping CI for Draft Pull Request. |
📝 WalkthroughWalkthroughThis change updates the default value of the Compact metadata:
Related issues:
Suggested labels: dependencies, ci Suggested reviewers: N/A Poem: 🚥 Pre-merge checks | ✅ 10 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (10 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8888 +/- ##
=======================================
Coverage 43.28% 43.28%
=======================================
Files 771 771
Lines 95503 95503
=======================================
Hits 41335 41335
Misses 51284 51284
Partials 2884 2884
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
/lgtm @bryan-cox @csrwng Any concerns with upgrading this go version? |
|
@cblecker: This PR has been marked to be verified later by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Scheduling tests matching the |
Test Resultse2e-aws
Failed TestsTotal failed tests: 4
e2e-aks
|
|
Now I have all the evidence. Here is the final analysis: Test Failure Analysis CompleteJob Information
Test Failure AnalysisErrorSummaryAll three failures are unrelated to PR #8888 (which only updates the GitHub Actions runner image to Go 1.26.4 — a CI-only change with no product code modifications). The e2e-v2-gke failure is purely a post-phase teardown issue where API credentials expired before the cluster could be destroyed. The e2e-aws failure is a Karpenter-specific kubelet TLS error during the kubelet config propagation test. The e2e-kubevirt failures are pre-existing compliance test failures against CDI's Root Causee2e-v2-gke — Infrastructure/credential issue (post-phase only): e2e-aws — Karpenter kubelet TLS error: e2e-kubevirt-aws-ovn-reduced — CDI importer-prime pod compliance failures: Recommendations
Evidence
|
|
/retitle NO-JIRA: chore: update github actions runner image to go 1.26.4 |
|
@BraeTroutman: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/override ci/prow/e2e-aws |
|
@bryan-cox: Overrode contexts on behalf of bryan-cox: ci/prow/e2e-aws DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/e2e-kubevirt-aws-ovn-reduced |
|
@bryan-cox: Overrode contexts on behalf of bryan-cox: ci/prow/e2e-kubevirt-aws-ovn-reduced, ci/prow/e2e-v2-gke DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BraeTroutman, bryan-cox The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@BraeTroutman: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
this is necessary to enable linting support for an PR upgrading hypershift images to golang 1.26.
What this PR does / why we need it:
bumps the go minor version of the github actions image to make use of 1.26.4
this is a necessary prerequisite to upgrading the project go version to 1.26.4, as golangci lint built in the actions image must be built using a greater or equal golang version.
Which issue(s) this PR fixes:
Fixes #8823
Special notes for your reviewer:
Checklist:
Summary by CodeRabbit