NO-JIRA: Add missing verify targets to GitHub Actions workflow

[enxebre]

Summary

• Add verify-api-deps, verify-crd-schema, and verify-docs-nav to the verify-reusable.yaml GitHub Actions workflow so they run on PRs instead of only in Prow
• Enable full git history fetch (fetch-depth: 0) needed by verify-crd-schema for CRD schema comparison against the base branch
• Fix docs/mkdocs.yml nav ordering (Cluster Capabilities before Common) caught by verify-docs-nav
• Add guidance in CONTRIBUTING.md that new Makefile CI targets must have a matching GitHub Actions workflow step

Test plan

• make verify-docs-nav passes locally after the mkdocs.yml fix
• GH Actions verify workflow runs the three new steps on this PR

🤖 Generated with Claude Code

Summary by CodeRabbit

• Documentation

  • Updated the contributor guide with clearer PR submission and CI expectations.
  • Adjusted the documentation navigation order for easier browsing.

• Chores

  • Expanded automated verification to use full repository history and run additional checks during validation.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@enxebre: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

• Add verify-api-deps, verify-crd-schema, and verify-docs-nav to the verify-reusable.yaml GitHub Actions workflow so they run on PRs instead of only in Prow
• Enable full git history fetch (fetch-depth: 0) needed by verify-crd-schema for CRD schema comparison against the base branch
• Fix docs/mkdocs.yml nav ordering (Cluster Capabilities before Common) caught by verify-docs-nav
• Add guidance in CONTRIBUTING.md that new Makefile CI targets must have a matching GitHub Actions workflow step

Test plan

• make verify-docs-nav passes locally after the mkdocs.yml fix
• GH Actions verify workflow runs the three new steps on this PR

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: a551a70b-9a80-42ba-b10e-aab7c1b68d1f

📥 Commits

Reviewing files that changed from the base of the PR and between 73da66e and b951545.

📒 Files selected for processing (3)

• .github/workflows/verify-reusable.yaml
• CONTRIBUTING.md
• docs/mkdocs.yml

---

📝 Walkthrough

Walkthrough

The reusable verify workflow gains full git history (fetch-depth: 0) and a conditional git fetch of github.base_ref, then adds three new verification steps: make verify-api-deps, make verify-crd-schema, and make verify-docs-nav. CONTRIBUTING.md adds a commit-format requirement and a note that new CI-facing make targets must be mirrored into the GitHub Actions workflow. In docs/mkdocs.yml, the "Cluster Capabilities" nav entry is moved before the "Common" subgroup under "How-to guides."

🚥 Pre-merge checks | ✅ 11

✅ Passed checks (11 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly reflects the main change: adding missing verify targets to the GitHub Actions workflow.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	No changed Ginkgo titles were introduced; the modified tests use static table-driven t.Run names only.
Test Structure And Quality	✅ Passed	PR only changes workflow/docs/CONTRIBUTING; no Ginkgo test code was added or modified, so this quality check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	PR only changes workflow/docs/CONTRIBUTING files; no deployment manifests, controllers, or scheduling constraints were modified.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added; the diff only adds unit tests/docs/workflow changes, and I found no IPv4-only or external-connectivity assumptions in test code.
No-Weak-Crypto	✅ Passed	Touched files are workflow/docs only, and scans found no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or custom crypto usage.
Container-Privileges	✅ Passed	PR only changes a workflow/docs/nav; targeted scan found no privileged:true, hostPID/Network/IPC, SYS_ADMIN, runAsUser:0, or allowPrivilegeEscalation:true in touched files.
No-Sensitive-Data-In-Logs	✅ Passed	No new log statements or debug output exposing secrets/PII were added; the only echoed data is git status in the workflow.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [enxebre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.19%. Comparing base (80f3425) to head (b951545).
⚠️ Report is 37 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8870      +/-   ##
==========================================
+ Coverage   43.12%   43.19%   +0.07%     
==========================================
  Files         767      767              
  Lines       94912    94914       +2     
==========================================
+ Hits        40933    41001      +68     
+ Misses      51128    51050      -78     
- Partials     2851     2863      +12     

see 3 files with indirect coverage changes

Flag	Coverage Δ
cmd-support	36.43% <ø> (+<0.01%)	⬆️
cpo-hostedcontrolplane	45.31% <ø> (+<0.01%)	⬆️
cpo-other	45.10% <ø> (ø)
hypershift-operator	53.53% <ø> (+0.25%)	⬆️
other	31.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ironcladlou]

Would it be easier to ensure that all the verify steps run consistently in all environments if they were wrapped in a single execution target/script? e.g. I would expect there to be a single make verify that does every run element in this list so that there's no chance of future additions to the verification flow becoming mismatched in local/PR/prow execution flows

[celebdor]

/lgtm
/verified by "later Unit tests GHA"

[openshift-ci-robot]

@celebdor: This PR has been marked as verified by "later Unit tests GHA".

Details

In response to this:

/lgtm
/verified by "later Unit tests GHA"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

Pipeline controller notification

No second-stage tests were triggered for this PR.

This can happen when:

• The changed files don't match any pipeline_run_if_changed patterns
• All files match pipeline_skip_if_only_changed patterns
• No pipeline-controlled jobs are defined for the main branch

Use /test ? to see all available tests.

[openshift-ci]

@enxebre: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.