-
Notifications
You must be signed in to change notification settings - Fork 566
ci(deps): bump actions/checkout from 6.0.2 to 7.0.0 #8780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -12,7 +12,7 @@ jobs: | |||||||||||||||
| update-registry: | ||||||||||||||||
| runs-on: arc-runner-set | ||||||||||||||||
| steps: | ||||||||||||||||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||||||||||||||||
| - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 | ||||||||||||||||
| with: | ||||||||||||||||
| token: ${{ secrets.COMMUNITY_FORK_TOKEN }} | ||||||||||||||||
|
Comment on lines
+15
to
17
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔒 Security & Privacy | 🟠 Major | ⚡ Quick win 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
git ls-files .github/workflows/update-ci-job-registry.yaml
wc -l .github/workflows/update-ci-job-registry.yaml
cat -n .github/workflows/update-ci-job-registry.yamlRepository: openshift/hypershift Length of output: 2759 🏁 Script executed: #!/bin/bash
set -euo pipefail
# Show any nearby references to COMMUNITY_FORK_TOKEN, GH_TOKEN, git push, and checkout credential settings.
rg -n -C 3 'COMMUNITY_FORK_TOKEN|GH_TOKEN|persist-credentials|git push|actions/checkout' .github/workflows/update-ci-job-registry.yaml .github/workflows -g '*.yaml'Repository: openshift/hypershift Length of output: 19971 Avoid persisting Proposed checkout change - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
token: ${{ secrets.COMMUNITY_FORK_TOKEN }}
+ persist-credentials: false📝 Committable suggestion
Suggested change
🧰 Tools🪛 zizmor (1.26.1)[warning] 15-17: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false (artipacked) 🤖 Prompt for AI AgentsSources: Path instructions, Linters/SAST tools |
||||||||||||||||
|
|
||||||||||||||||
|
|
||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add
persist-credentials: falseto prevent credential leakage via artifacts.This step checks out the repository using a secret token (
COMMUNITY_FORK_TOKEN) but does not disable credential persistence. By default, GitHub Actions persists credentials to artifacts, creating a risk of secret exposure. Although this workflow requires the token for the subsequent push, credentials should not persist beyond the current job execution.Per the coding guideline on least privilege and the static analysis warning, add
persist-credentials: falseto the checkout configuration.🔐 Proposed fix to disable credential persistence
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 with: fetch-depth: 0 token: ${{ secrets.COMMUNITY_FORK_TOKEN }} + persist-credentials: false📝 Committable suggestion
🧰 Tools
🪛 zizmor (1.25.2)
[warning] 21-24: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false
(artipacked)
🤖 Prompt for AI Agents
Sources: Coding guidelines, Linters/SAST tools