ci(deps): bump actions/create-github-app-token from 2.2.2 to 3.2.0 - #8779
ci(deps): bump actions/create-github-app-token from 2.2.2 to 3.2.0#8779dependabot[bot] wants to merge 1 commit into
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
📝 WalkthroughWalkthroughThe reusable workflow Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dependabot[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/reusable-claude-on-pr.yaml (1)
65-73:⚠️ Potential issue | 🟡 MinorReplace deprecated
app-idinput withclient-id.The
app-idinput is deprecated in v3.2.0 and should be replaced withclient-id. Update line 70 from:app-id: ${{ secrets.JIRA_SOLVE_CI_APP_ID }}to:
client-id: ${{ secrets.JIRA_SOLVE_CI_APP_ID }}The
repositoriesinput at line 73 currently uses the short repository name (hypershift). While the action accepts this format, consider updating it to the full repository name (hypershift-community/hypershift) for clarity and explicit intent.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/reusable-claude-on-pr.yaml around lines 65 - 73, Replace the deprecated `app-id` input with `client-id` in the Generate community fork token step that uses the actions/create-github-app-token action. Change the line containing `app-id: ${{ secrets.JIRA_SOLVE_CI_APP_ID }}` to `client-id: ${{ secrets.JIRA_SOLVE_CI_APP_ID }}` to align with the v3.2.0 action specification. Additionally, update the `repositories` input from the short name `hypershift` to the full repository path `hypershift-community/hypershift` for clarity and explicitness.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In @.github/workflows/reusable-claude-on-pr.yaml:
- Around line 65-73: Replace the deprecated `app-id` input with `client-id` in
the Generate community fork token step that uses the
actions/create-github-app-token action. Change the line containing `app-id: ${{
secrets.JIRA_SOLVE_CI_APP_ID }}` to `client-id: ${{ secrets.JIRA_SOLVE_CI_APP_ID
}}` to align with the v3.2.0 action specification. Additionally, update the
`repositories` input from the short name `hypershift` to the full repository
path `hypershift-community/hypershift` for clarity and explicitness.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 5e093436-85de-45a8-8337-5f1744c1f34d
📒 Files selected for processing (1)
.github/workflows/reusable-claude-on-pr.yaml
Bumps [actions/create-github-app-token](https://github.com/actions/create-github-app-token) from 2.2.2 to 3.2.0. - [Release notes](https://github.com/actions/create-github-app-token/releases) - [Changelog](https://github.com/actions/create-github-app-token/blob/main/CHANGELOG.md) - [Commits](actions/create-github-app-token@fee1f7d...bcd2ba4 96da409d3eb1) --- updated-dependencies: - dependency-name: actions/create-github-app-token dependency-version: 3.2.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
d14299c to
27f2ef5
Compare
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/reusable-claude-on-pr.yaml (1)
68-73: Consider migrating from the deprecatedapp-idinput toclient-id.The
actions/create-github-app-token@v3.2.0action maintains backward compatibility with theapp-idinput on line 70, so your workflow will continue to function. However,app-idis now deprecated in favor ofclient-id, which is the preferred input moving forward. Plan to migrate toclient-idin a future update.Additionally, verify that your GitHub App token is configured with appropriate scopes and does not inherit blanket installation permissions, per the least-privilege principle.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/reusable-claude-on-pr.yaml around lines 68 - 73, In the actions/create-github-app-token action step, replace the deprecated app-id input with the client-id input. Change the line that currently specifies app-id: ${{ secrets.JIRA_SOLVE_CI_APP_ID }} to use client-id instead, and ensure the corresponding secret reference (JIRA_SOLVE_CI_APP_ID) is updated if necessary to match your GitHub App's client ID. This aligns with the latest best practices for the action while maintaining the same functionality.Sources: Coding guidelines, Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/workflows/reusable-claude-on-pr.yaml:
- Around line 68-73: In the actions/create-github-app-token action step, replace
the deprecated app-id input with the client-id input. Change the line that
currently specifies app-id: ${{ secrets.JIRA_SOLVE_CI_APP_ID }} to use client-id
instead, and ensure the corresponding secret reference (JIRA_SOLVE_CI_APP_ID) is
updated if necessary to match your GitHub App's client ID. This aligns with the
latest best practices for the action while maintaining the same functionality.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 55397959-7269-488a-97c6-dfab526c03c7
📒 Files selected for processing (1)
.github/workflows/reusable-claude-on-pr.yaml
|
@dependabot[bot]: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Stale PRs are closed after 21d of inactivity. If this PR is still relevant, comment to refresh it or remove the stale label. If this PR is safe to close now please do so with /lifecycle stale |
|
Stale PRs rot after 14d of inactivity. Mark the PR as fresh by commenting If this PR is safe to close now please do so with /lifecycle rotten |
|
Rotten PRs close after 7d of inactivity. Reopen the PR by commenting /close |
|
@openshift-ci[bot]: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps actions/create-github-app-token from 2.2.2 to 3.2.0.
Release notes
Sourced from actions/create-github-app-token's releases.
... (truncated)
Changelog
Sourced from actions/create-github-app-token's changelog.
Commits
bcd2ba4chore(main): release 3.2.0 (#370)f24bbd8fix: validate private-key input (#376)363531bdocs: capitalize Git as a proper noun in README (#374)fd28011docs: update procedure to configure Git (#287)85eb8ddfeat: support full repository names inrepositoriesinput (#372)c9aabb8build(deps-dev): bump yaml from 2.8.3 to 2.8.4 in the development-dependencie...e02e816build(deps-dev): bump undici from 7.24.6 to 8.2.0 (#366)8d835bfbuild(deps-dev): bump esbuild from 0.27.4 to 0.28.0 in the development-depend...952a2a7feat: add support for enterprise-level GitHub Apps (#263)43e5c34fix(deps): bump@actions/corefrom 3.0.0 to 3.0.1 in the production-dependenc...You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Summary by CodeRabbit