OCPBUGS-89352: build(operator): drop hypershift-no-cgo from operator container images by yiraeChristineKim · Pull Request #8756 · openshift/hypershift

yiraeChristineKim · 2026-06-17T16:06:08Z

This is a cherry-pick of PR #8601 onto release-4.22.

What this PR does / why we need it

Remove the hypershift-no-cgo statically compiled binary from Containerfile.operator. The non-FIPS binary causes Enterprise Contract FIPS violations in Konflux builds for MCE.

Fixes: OCPBUGS-89352
Upstream: #8601

Checklist

Subject and description added to both commit and PR
Relevant issues have been referenced

Made with Cursor

Remove the hypershift-no-cgo statically compiled binary and the hcp product CLI from Containerfile.operator, as these are only required in the Konflux build pipeline and not in the operator image itself. Non-Konflux Dockerfiles (Dockerfile, Dockerfile.dev) are unchanged and continue to include hypershift-no-cgo and hcp. Signed-off-by: yiraeChristineKim <yikim@redhat.com> Commit-Message-Assisted-by: Claude (via Claude Code) Co-authored-by: Cursor <cursoragent@cursor.com>

openshift-merge-bot · 2026-06-17T16:06:11Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci · 2026-06-17T16:06:14Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci-robot · 2026-06-17T16:06:15Z

@yiraeChristineKim: This pull request references Jira Issue OCPBUGS-89352, which is invalid:

expected the bug to target the "4.22.0" version, but no target version was set
release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected dependent Jira Issue OCPBUGS-89338 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is New instead
expected dependent Jira Issue OCPBUGS-89338 to target a version in 5.0.0, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is a cherry-pick of PR #8601 onto release-4.22.

What this PR does / why we need it

Remove the hypershift-no-cgo statically compiled binary from Containerfile.operator. The non-FIPS binary causes Enterprise Contract FIPS violations in Konflux builds for MCE.

Fixes: OCPBUGS-89352
Upstream: #8601

Checklist

Subject and description added to both commit and PR

Relevant issues have been referenced

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-06-17T16:06:19Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 59482427-d525-4ea3-8bb7-68a7f72d4a3b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-06-17T16:20:51Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 35.45%. Comparing base (2371dc8) to head (5a84196).
⚠️ Report is 106 commits behind head on release-4.22.

Additional details and impacted files

@@               Coverage Diff                @@
##           release-4.22    #8756      +/-   ##
================================================
+ Coverage         32.17%   35.45%   +3.27%     
================================================
  Files               766      768       +2     
  Lines             91968    93726    +1758     
================================================
+ Hits              29592    33226    +3634     
+ Misses            59843    57787    -2056     
- Partials           2533     2713     +180

see 72 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

yiraeChristineKim · 2026-06-17T16:56:53Z

/ok-to-test

yiraeChristineKim · 2026-06-17T18:19:02Z

/test all

yiraeChristineKim · 2026-06-17T18:20:08Z

/jira refresh

openshift-ci-robot · 2026-06-17T18:20:15Z

@yiraeChristineKim: This pull request references Jira Issue OCPBUGS-89352, which is invalid:

expected dependent Jira Issue OCPBUGS-89338 to target a version in 5.0.0, but it targets "4.17.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

yiraeChristineKim · 2026-06-17T18:21:09Z

/jira refresh

openshift-ci-robot · 2026-06-17T18:21:14Z

@yiraeChristineKim: This pull request references Jira Issue OCPBUGS-89352, which is invalid:

expected dependent Jira Issue OCPBUGS-89338 to target a version in 5.0.0, but it targets "5.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

yiraeChristineKim · 2026-06-17T18:21:45Z

/jira refresh

openshift-ci-robot · 2026-06-17T18:21:56Z

@yiraeChristineKim: This pull request references Jira Issue OCPBUGS-89352, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-89338 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-89338 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
bug has dependents

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

yiraeChristineKim · 2026-06-18T00:20:27Z

/test all

yiraeChristineKim · 2026-06-18T00:39:15Z

/cc @bryan-cox

yiraeChristineKim · 2026-06-18T00:39:44Z

/cc @csrwng

bryan-cox

/area ci-tooling

openshift-ci · 2026-06-18T10:45:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, yiraeChristineKim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [bryan-cox]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-merge-bot · 2026-06-18T10:45:09Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aks
/test e2e-aws
/test e2e-aws-upgrade-hypershift-operator
/test e2e-azure-self-managed
/test e2e-kubevirt-aws-ovn-reduced
/test e2e-v2-aws

yiraeChristineKim · 2026-06-18T12:49:40Z

/test e2e-aws-upgrade-hypershift-operator

yiraeChristineKim · 2026-06-18T12:50:06Z

/test e2e-aws

yiraeChristineKim · 2026-06-18T12:50:23Z

/test e2e-kubevirt-aws-ovn-reduced

yiraeChristineKim · 2026-06-18T13:08:08Z

/test e2e-aws-upgrade-hypershift-operator

yiraeChristineKim · 2026-06-18T17:55:12Z

/test e2e-aws-upgrade-hypershift-operator

yiraeChristineKim · 2026-06-18T19:21:37Z

/test e2e-aws-upgrade-hypershift-operator

bryan-cox · 2026-06-18T19:26:13Z

@yiraeChristineKim the test is broke. This PR is blocked at the moment.

I would encourage you not to just hit /retest. We recently put up a flowchart to help folks figure out if a test is broken on their side or its an infra thing - https://hypershift.pages.dev/how-to/ci/triage/presubmit-failures/

yiraeChristineKim · 2026-06-18T19:48:10Z

@bryan-cox Can we override this? We're in a hurry for the z-stream release.

yiraeChristineKim · 2026-06-18T21:39:45Z

Summary: This is a pre-existing flaky failure on the release-4.22 branch, NOT caused by PR #8756's changes.
The PR only modifies Containerfile.operator (removing the hypershift-no-cgo binary) — it touches zero Go
code or controller logic. The test's Consistently assertion (5-minute window, 1s poll) expects
MachineDeployment generations to stay unchanged after the HyperShift operator upgrade, but something on the
release-4.22 branch tip (BaseSHA 5cb8735) is causing a spurious generation bump on one of the
MachineDeployments (us-east-1a). The same failure reproduces on at least two other unrelated PRs (#8692 and
#8746) targeting release-4.22 with the same base SHA.

yiraeChristineKim · 2026-06-18T21:40:04Z

/test e2e-aws-upgrade-hypershift-operator

celebdor · 2026-06-22T13:55:33Z

/override "ci/prow/e2e-aws-upgrade-hypershift-operator"

openshift-ci · 2026-06-22T13:56:00Z

@celebdor: Overrode contexts on behalf of celebdor: ci/prow/e2e-aws-upgrade-hypershift-operator

Details

In response to this:

/override "ci/prow/e2e-aws-upgrade-hypershift-operator"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2026-06-22T13:56:06Z

@yiraeChristineKim: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

celebdor · 2026-06-22T14:34:01Z

/verified by celebdor

📦[claudi@claude43 hypershift]$ podman run --rm  -ti --entrypoint /bin/sh quay.io/redhat-user-workloads/crt-redhat-acm-tenant/hypershift-release-mce-217:on-pr-5a84196d0f34721a13adfff9f988dce84b9df140 -c "stat /usr/bin/hypershift"
"
  File: /usr/bin/hypershift
  Size: 221302456       Blocks: 432232     IO Block: 4096   regular file
Device: 60h/96d Inode: 59337267    Links: 1
Access: (0755/-rwxr-xr-x)  Uid: ( 1001/ UNKNOWN)   Gid: (    0/    root)
Access: 2026-06-17 17:20:38.000000000 +0000
Modify: 2026-06-17 17:20:38.000000000 +0000
Change: 2026-06-22 13:25:47.670519442 +0000
 Birth: 2026-06-22 13:25:46.922968014 +0000
bash: unexpected EOF while looking for matching `"'
[ble: exit 2]
📦[claudi@claude43 hypershift]$ podman run --rm  -ti --entrypoint /bin/sh quay.io/redhat-user-workloads/crt-redhat-acm-tenant/hypershift-release-mce-217:on-pr-5a84196d0f34721a13adfff9f988dce84b9df140 -c "stat /usr/bin/hypershift-no-cgo"
stat: cannot statx '/usr/bin/hypershift-no-cgo': No such file or directory
[ble: exit 1]
📦[claudi@claude43 hypershift]$ podman run --rm  -ti --entrypoint /bin/sh quay.io/redhat-user-workloads/crt-redhat-acm-tenant/hypershift-release-mce-217:on-pr-5a84196d0f34721a13adfff9f988dce84b9df140 -c "stat /usr/bin/hcp"
stat: cannot statx '/usr/bin/hcp': No such file or directory
[ble: exit 1]
📦[claudi@claude43 hypershift]$

openshift-ci-robot · 2026-06-22T14:34:13Z

@celebdor: This PR has been marked as verified by celebdor.

Details

In response to this:

/verified by celebdor

📦[claudi@claude43 hypershift]$ podman run --rm  -ti --entrypoint /bin/sh quay.io/redhat-user-workloads/crt-redhat-acm-tenant/hypershift-release-mce-217:on-pr-5a84196d0f34721a13adfff9f988dce84b9df140 -c "stat /usr/bin/hypershift"
"
 File: /usr/bin/hypershift
 Size: 221302456       Blocks: 432232     IO Block: 4096   regular file
Device: 60h/96d Inode: 59337267    Links: 1
Access: (0755/-rwxr-xr-x)  Uid: ( 1001/ UNKNOWN)   Gid: (    0/    root)
Access: 2026-06-17 17:20:38.000000000 +0000
Modify: 2026-06-17 17:20:38.000000000 +0000
Change: 2026-06-22 13:25:47.670519442 +0000
Birth: 2026-06-22 13:25:46.922968014 +0000
bash: unexpected EOF while looking for matching `"'
[ble: exit 2]
📦[claudi@claude43 hypershift]$ podman run --rm  -ti --entrypoint /bin/sh quay.io/redhat-user-workloads/crt-redhat-acm-tenant/hypershift-release-mce-217:on-pr-5a84196d0f34721a13adfff9f988dce84b9df140 -c "stat /usr/bin/hypershift-no-cgo"
stat: cannot statx '/usr/bin/hypershift-no-cgo': No such file or directory
[ble: exit 1]
📦[claudi@claude43 hypershift]$ podman run --rm  -ti --entrypoint /bin/sh quay.io/redhat-user-workloads/crt-redhat-acm-tenant/hypershift-release-mce-217:on-pr-5a84196d0f34721a13adfff9f988dce84b9df140 -c "stat /usr/bin/hcp"
stat: cannot statx '/usr/bin/hcp': No such file or directory
[ble: exit 1]
📦[claudi@claude43 hypershift]$

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-06-22T14:39:28Z

@yiraeChristineKim: Jira Issue Verification Checks: Jira Issue OCPBUGS-89352
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-89352 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This is a cherry-pick of PR #8601 onto release-4.22.

What this PR does / why we need it

Remove the hypershift-no-cgo statically compiled binary from Containerfile.operator. The non-FIPS binary causes Enterprise Contract FIPS violations in Konflux builds for MCE.

Fixes: OCPBUGS-89352
Upstream: #8601

Checklist

Subject and description added to both commit and PR

Relevant issues have been referenced

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 17, 2026

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 17, 2026

openshift-ci Bot added the do-not-merge/needs-area label Jun 17, 2026

yiraeChristineKim marked this pull request as ready for review June 17, 2026 16:11

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 17, 2026

openshift-ci Bot requested review from devguyio and jparrill June 17, 2026 16:11

openshift-ci Bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 17, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 17, 2026

openshift-ci Bot requested a review from bryan-cox June 18, 2026 00:39

openshift-ci Bot requested a review from csrwng June 18, 2026 00:39

bryan-cox approved these changes Jun 18, 2026

View reviewed changes

openshift-ci Bot added area/ci-tooling Indicates the PR includes changes for CI or tooling and removed do-not-merge/needs-area labels Jun 18, 2026

openshift-ci Bot assigned bryan-cox Jun 18, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2026

yiraeChristineKim mentioned this pull request Jun 18, 2026

OCPBUGS-89357: build(operator): drop hypershift-no-cgo from operator container images #8761

Merged

enxebre added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 22, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jun 22, 2026

openshift-merge-bot Bot merged commit e3ad989 into openshift:release-4.22 Jun 22, 2026
21 checks passed

Uh oh!

Conversation

yiraeChristineKim commented Jun 17, 2026

What this PR does / why we need it

Checklist

Uh oh!

openshift-merge-bot Bot commented Jun 17, 2026

Uh oh!

openshift-ci Bot commented Jun 17, 2026

Uh oh!

openshift-ci-robot commented Jun 17, 2026

What this PR does / why we need it

Checklist

Uh oh!

coderabbitai Bot commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

codecov Bot commented Jun 17, 2026

Codecov Report

Uh oh!

yiraeChristineKim commented Jun 17, 2026

Uh oh!

yiraeChristineKim commented Jun 17, 2026

Uh oh!

yiraeChristineKim commented Jun 17, 2026

Uh oh!

openshift-ci-robot commented Jun 17, 2026

Uh oh!

yiraeChristineKim commented Jun 17, 2026

Uh oh!

openshift-ci-robot commented Jun 17, 2026

Uh oh!

yiraeChristineKim commented Jun 17, 2026

Uh oh!

openshift-ci-robot commented Jun 17, 2026

Uh oh!

yiraeChristineKim commented Jun 18, 2026

Uh oh!

yiraeChristineKim commented Jun 18, 2026

Uh oh!

yiraeChristineKim commented Jun 18, 2026

Uh oh!

bryan-cox left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Jun 18, 2026

Uh oh!

openshift-merge-bot Bot commented Jun 18, 2026

Uh oh!

yiraeChristineKim commented Jun 18, 2026

Uh oh!

yiraeChristineKim commented Jun 18, 2026

Uh oh!

yiraeChristineKim commented Jun 18, 2026

Uh oh!

yiraeChristineKim commented Jun 18, 2026

Uh oh!

yiraeChristineKim commented Jun 18, 2026

Uh oh!

yiraeChristineKim commented Jun 18, 2026

Uh oh!

bryan-cox commented Jun 18, 2026

Uh oh!

yiraeChristineKim commented Jun 18, 2026

Uh oh!

yiraeChristineKim commented Jun 18, 2026

Uh oh!

yiraeChristineKim commented Jun 18, 2026

Uh oh!

celebdor commented Jun 22, 2026

Uh oh!

openshift-ci Bot commented Jun 22, 2026

Uh oh!

openshift-ci Bot commented Jun 22, 2026

Uh oh!

celebdor commented Jun 22, 2026

Uh oh!

openshift-ci-robot commented Jun 22, 2026

Uh oh!

coderabbitai Bot commented Jun 17, 2026 •

edited

Loading