Skip to content

OCPBUGS-13553: Trigger NodePool rollout on in-place pull secret changes #8700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vsolanki12 wants to merge 1 commit into from
Closed

OCPBUGS-13553: Trigger NodePool rollout on in-place pull secret changes #8700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/hypershift/v1beta1/hostedcluster_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,7 +675,7 @@ type HostedClusterSpec struct {
// TODO(alberto): Signal this in a condition.
// This pull secret is included in NodePool ignition/bootstrap payloads and applied to the container runtime when nodes provision.
// Changing this value will trigger a rollout for all existing NodePools in the cluster (for both replace and inplace upgrade types).
// Updating the referenced Secret's data in place (without changing this reference) does not trigger that rollout.
// Updating the referenced Secret's data in place (without changing this reference) will also trigger a rollout.
// In AWS and Azure NodePools using the Replace upgrade strategy, the Secret's data in place changes
// will still propagate the updated credentials down to the guest cluster and kubelet config.
// +required
Expand Down
2 changes: 1 addition & 1 deletion ...erated.featuregated-crd-manifests/hostedclusters.hypershift.openshift.io/AAA_ungated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5922,7 +5922,7 @@ spec:
If the reference is set but none of the above requirements are met, the HostedCluster will enter a degraded state.
This pull secret is included in NodePool ignition/bootstrap payloads and applied to the container runtime when nodes provision.
Changing this value will trigger a rollout for all existing NodePools in the cluster (for both replace and inplace upgrade types).
Updating the referenced Secret's data in place (without changing this reference) does not trigger that rollout.
Updating the referenced Secret's data in place (without changing this reference) will also trigger a rollout.
In AWS and Azure NodePools using the Replace upgrade strategy, the Secret's data in place changes
will still propagate the updated credentials down to the guest cluster and kubelet config.
properties:
Expand Down
2 changes: 1 addition & 1 deletion ...egated-crd-manifests/hostedclusters.hypershift.openshift.io/ClusterUpdateAcceptRisks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5905,7 +5905,7 @@ spec:
If the reference is set but none of the above requirements are met, the HostedCluster will enter a degraded state.
This pull secret is included in NodePool ignition/bootstrap payloads and applied to the container runtime when nodes provision.
Changing this value will trigger a rollout for all existing NodePools in the cluster (for both replace and inplace upgrade types).
Updating the referenced Secret's data in place (without changing this reference) does not trigger that rollout.
Updating the referenced Secret's data in place (without changing this reference) will also trigger a rollout.
In AWS and Azure NodePools using the Replace upgrade strategy, the Secret's data in place changes
will still propagate the updated credentials down to the guest cluster and kubelet config.
properties:
Expand Down
2 changes: 1 addition & 1 deletion ...manifests/hostedclusters.hypershift.openshift.io/ClusterVersionOperatorConfiguration.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5925,7 +5925,7 @@ spec:
If the reference is set but none of the above requirements are met, the HostedCluster will enter a degraded state.
This pull secret is included in NodePool ignition/bootstrap payloads and applied to the container runtime when nodes provision.
Changing this value will trigger a rollout for all existing NodePools in the cluster (for both replace and inplace upgrade types).
Updating the referenced Secret's data in place (without changing this reference) does not trigger that rollout.
Updating the referenced Secret's data in place (without changing this reference) will also trigger a rollout.
In AWS and Azure NodePools using the Replace upgrade strategy, the Secret's data in place changes
will still propagate the updated credentials down to the guest cluster and kubelet config.
properties:
Expand Down
2 changes: 1 addition & 1 deletion ...rated.featuregated-crd-manifests/hostedclusters.hypershift.openshift.io/ExternalOIDC.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6237,7 +6237,7 @@ spec:
If the reference is set but none of the above requirements are met, the HostedCluster will enter a degraded state.
This pull secret is included in NodePool ignition/bootstrap payloads and applied to the container runtime when nodes provision.
Changing this value will trigger a rollout for all existing NodePools in the cluster (for both replace and inplace upgrade types).
Updating the referenced Secret's data in place (without changing this reference) does not trigger that rollout.
Updating the referenced Secret's data in place (without changing this reference) will also trigger a rollout.
In AWS and Azure NodePools using the Replace upgrade strategy, the Secret's data in place changes
will still propagate the updated credentials down to the guest cluster and kubelet config.
properties:
Expand Down
2 changes: 1 addition & 1 deletion ...ests/hostedclusters.hypershift.openshift.io/ExternalOIDCWithUIDAndExtraClaimMappings.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6377,7 +6377,7 @@ spec:
If the reference is set but none of the above requirements are met, the HostedCluster will enter a degraded state.
This pull secret is included in NodePool ignition/bootstrap payloads and applied to the container runtime when nodes provision.
Changing this value will trigger a rollout for all existing NodePools in the cluster (for both replace and inplace upgrade types).
Updating the referenced Secret's data in place (without changing this reference) does not trigger that rollout.
Updating the referenced Secret's data in place (without changing this reference) will also trigger a rollout.
In AWS and Azure NodePools using the Replace upgrade strategy, the Secret's data in place changes
will still propagate the updated credentials down to the guest cluster and kubelet config.
properties:
Expand Down
2 changes: 1 addition & 1 deletion ...-crd-manifests/hostedclusters.hypershift.openshift.io/ExternalOIDCWithUpstreamParity.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6368,7 +6368,7 @@ spec:
If the reference is set but none of the above requirements are met, the HostedCluster will enter a degraded state.
This pull secret is included in NodePool ignition/bootstrap payloads and applied to the container runtime when nodes provision.
Changing this value will trigger a rollout for all existing NodePools in the cluster (for both replace and inplace upgrade types).
Updating the referenced Secret's data in place (without changing this reference) does not trigger that rollout.
Updating the referenced Secret's data in place (without changing this reference) will also trigger a rollout.
In AWS and Azure NodePools using the Replace upgrade strategy, the Secret's data in place changes
will still propagate the updated credentials down to the guest cluster and kubelet config.
properties:
Expand Down
2 changes: 1 addition & 1 deletion ...erated.featuregated-crd-manifests/hostedclusters.hypershift.openshift.io/GCPPlatform.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6351,7 +6351,7 @@ spec:
If the reference is set but none of the above requirements are met, the HostedCluster will enter a degraded state.
This pull secret is included in NodePool ignition/bootstrap payloads and applied to the container runtime when nodes provision.
Changing this value will trigger a rollout for all existing NodePools in the cluster (for both replace and inplace upgrade types).
Updating the referenced Secret's data in place (without changing this reference) does not trigger that rollout.
Updating the referenced Secret's data in place (without changing this reference) will also trigger a rollout.
In AWS and Azure NodePools using the Replace upgrade strategy, the Secret's data in place changes
will still propagate the updated credentials down to the guest cluster and kubelet config.
properties:
Expand Down
2 changes: 1 addition & 1 deletion ...ated.featuregated-crd-manifests/hostedclusters.hypershift.openshift.io/HCPEtcdBackup.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5970,7 +5970,7 @@ spec:
If the reference is set but none of the above requirements are met, the HostedCluster will enter a degraded state.
This pull secret is included in NodePool ignition/bootstrap payloads and applied to the container runtime when nodes provision.
Changing this value will trigger a rollout for all existing NodePools in the cluster (for both replace and inplace upgrade types).
Updating the referenced Secret's data in place (without changing this reference) does not trigger that rollout.
Updating the referenced Secret's data in place (without changing this reference) will also trigger a rollout.
In AWS and Azure NodePools using the Replace upgrade strategy, the Secret's data in place changes
will still propagate the updated credentials down to the guest cluster and kubelet config.
properties:
Expand Down
2 changes: 1 addition & 1 deletion ...fests/hostedclusters.hypershift.openshift.io/HyperShiftOnlyDynamicResourceAllocation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5927,7 +5927,7 @@ spec:
If the reference is set but none of the above requirements are met, the HostedCluster will enter a degraded state.
This pull secret is included in NodePool ignition/bootstrap payloads and applied to the container runtime when nodes provision.
Changing this value will trigger a rollout for all existing NodePools in the cluster (for both replace and inplace upgrade types).
Updating the referenced Secret's data in place (without changing this reference) does not trigger that rollout.
Updating the referenced Secret's data in place (without changing this reference) will also trigger a rollout.
In AWS and Azure NodePools using the Replace upgrade strategy, the Secret's data in place changes
will still propagate the updated credentials down to the guest cluster and kubelet config.
properties:
Expand Down
2 changes: 1 addition & 1 deletion ...turegated-crd-manifests/hostedclusters.hypershift.openshift.io/ImageStreamImportMode.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5923,7 +5923,7 @@ spec:
If the reference is set but none of the above requirements are met, the HostedCluster will enter a degraded state.
This pull secret is included in NodePool ignition/bootstrap payloads and applied to the container runtime when nodes provision.
Changing this value will trigger a rollout for all existing NodePools in the cluster (for both replace and inplace upgrade types).
Updating the referenced Secret's data in place (without changing this reference) does not trigger that rollout.
Updating the referenced Secret's data in place (without changing this reference) will also trigger a rollout.
In AWS and Azure NodePools using the Replace upgrade strategy, the Secret's data in place changes
will still propagate the updated credentials down to the guest cluster and kubelet config.
properties:
Expand Down
2 changes: 1 addition & 1 deletion ...turegated-crd-manifests/hostedclusters.hypershift.openshift.io/KMSEncryptionProvider.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5981,7 +5981,7 @@ spec:
If the reference is set but none of the above requirements are met, the HostedCluster will enter a degraded state.
This pull secret is included in NodePool ignition/bootstrap payloads and applied to the container runtime when nodes provision.
Changing this value will trigger a rollout for all existing NodePools in the cluster (for both replace and inplace upgrade types).
Updating the referenced Secret's data in place (without changing this reference) does not trigger that rollout.
Updating the referenced Secret's data in place (without changing this reference) will also trigger a rollout.
In AWS and Azure NodePools using the Replace upgrade strategy, the Secret's data in place changes
will still propagate the updated credentials down to the guest cluster and kubelet config.
properties:
Expand Down
2 changes: 1 addition & 1 deletion ...enerated.featuregated-crd-manifests/hostedclusters.hypershift.openshift.io/OpenStack.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6456,7 +6456,7 @@ spec:
If the reference is set but none of the above requirements are met, the HostedCluster will enter a degraded state.
This pull secret is included in NodePool ignition/bootstrap payloads and applied to the container runtime when nodes provision.
Changing this value will trigger a rollout for all existing NodePools in the cluster (for both replace and inplace upgrade types).
Updating the referenced Secret's data in place (without changing this reference) does not trigger that rollout.
Updating the referenced Secret's data in place (without changing this reference) will also trigger a rollout.
In AWS and Azure NodePools using the Replace upgrade strategy, the Secret's data in place changes
will still propagate the updated credentials down to the guest cluster and kubelet config.
properties:
Expand Down
2 changes: 1 addition & 1 deletion ...rated.featuregated-crd-manifests/hostedclusters.hypershift.openshift.io/TLSAdherence.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5945,7 +5945,7 @@ spec:
If the reference is set but none of the above requirements are met, the HostedCluster will enter a degraded state.
This pull secret is included in NodePool ignition/bootstrap payloads and applied to the container runtime when nodes provision.
Changing this value will trigger a rollout for all existing NodePools in the cluster (for both replace and inplace upgrade types).
Updating the referenced Secret's data in place (without changing this reference) does not trigger that rollout.
Updating the referenced Secret's data in place (without changing this reference) will also trigger a rollout.
In AWS and Azure NodePools using the Replace upgrade strategy, the Secret's data in place changes
will still propagate the updated credentials down to the guest cluster and kubelet config.
properties:
Expand Down
2 changes: 1 addition & 1 deletion ...ft-operator/zz_generated.crd-manifests/hostedclusters-Hypershift-CustomNoUpgrade.crd.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ...hypershift-operator/zz_generated.crd-manifests/hostedclusters-Hypershift-Default.crd.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ...erator/zz_generated.crd-manifests/hostedclusters-Hypershift-TechPreviewNoUpgrade.crd.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions docs/content/reference/aggregated-docs.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions docs/content/reference/api.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading