Skip to content

CNTRLPLANE-3632: Predictable NodePool rollout control #8698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
csrwng wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CNTRLPLANE-3632: Predictable NodePool rollout control #8698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions api/hypershift/v1beta1/nodepool_conditions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,13 @@ const (
// values preserved because override is not allowed). False when no conflicts exist or all
// conflicts are explicitly allowed via overridePolicy.
NodePoolAWSResourceTagConflictConditionType = "AWSResourceTagConflict"

// NodePoolConfigUpdatePendingConditionType signals that management-side configuration
// has changed but no rollout has been triggered. New or replaced nodes may receive the
// latest management-side configuration while existing nodes retain the previous version.
// The full configuration will converge on the next spec-driven rollout
// (e.g. release upgrade, user MachineConfig change).
NodePoolConfigUpdatePendingConditionType = "ConfigUpdatePending"
Comment thread
coderabbitai[bot] marked this conversation as resolved.
)

// PerformanceProfile Conditions
Expand Down Expand Up @@ -140,4 +147,5 @@ const (
NodePoolUnsupportedSkewReason = "UnsupportedSkew"
AWSResourceTagConflictDetectedReason = "TagConflictDetected"
AWSResourceTagNoConflictReason = "NoTagConflict"
ManagementConfigDriftReason = "ManagementConfigDrift"
)
282 changes: 177 additions & 105 deletions hypershift-operator/controllers/nodepool/capi.go
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading