Skip to content

NO-JIRA: clone ai-helpers into workspace for plugin file access - #8620

Merged
celebdor merged 1 commit into
openshift:mainfrom
bryan-cox:test-arc-runners
May 28, 2026
Merged

NO-JIRA: clone ai-helpers into workspace for plugin file access#8620
celebdor merged 1 commit into
openshift:mainfrom
bryan-cox:test-arc-runners

Conversation

@bryan-cox

@bryan-cox bryan-cox commented May 28, 2026

Copy link
Copy Markdown
Member

Summary

  • Clones ai-helpers into $GITHUB_WORKSPACE/ai-helpers instead of /tmp/ai-helpers
  • This puts plugin files within the project directory so Claude Code can read them without permission restrictions

Test plan

  • Merge and trigger /test-wif on any open PR

🤖 Generated with Claude Code

Summary by CodeRabbit

Release Notes

This release contains internal infrastructure and tooling updates with no end-user visible changes.

The container: directive requires containerMode on ARC runners which
needs anyuid SCC and a long-running process. Replace it by installing
Claude and cloning ai-helpers directly in workflow steps.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 28, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@bryan-cox: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

  • Clones ai-helpers into $GITHUB_WORKSPACE/ai-helpers instead of /tmp/ai-helpers
  • This puts plugin files within the project directory so Claude Code can read them without permission restrictions

Test plan

  • Merge and trigger /test-wif on any open PR

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Please specify an area label

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

This PR updates the .github/workflows/claude-wif-test.yaml workflow to relocate the ai-helpers plugin setup from the temporary directory to the GitHub Actions workspace. The "Set up ai-helpers plugins" step now clones openshift-eng/ai-helpers into $GITHUB_WORKSPACE/ai-helpers instead of /tmp/ai-helpers, and the generated known_marketplaces.json is updated to reference the new workspace paths for both the plugin source and install location.

Possibly related PRs

  • openshift/hypershift#8611: Both PRs modify the same .github/workflows/claude-wif-test.yaml "Set up ai-helpers plugins" step, changing how openshift-eng/ai-helpers is cloned and how known_marketplaces.json points to that path.
  • openshift/hypershift#8609: Both PRs modify the same claude-wif-test.yaml workflow around the ai-helpers setup by changing how/where ai-helpers/plugins are sourced and installed (moving away from /tmp in support of the container-based test runner).
  • openshift/hypershift#8614: Both PRs modify the same .github/workflows/claude-wif-test.yaml "Set up ai-helpers plugins" and marketplace setup by cloning openshift-eng/ai-helpers and updating the generated plugin paths (this PR switches to $GITHUB_WORKSPACE, while the retrieved PR uses /tmp).

Suggested reviewers

  • csrwng
  • Nirshal

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name Status Explanation Resolution
Stable And Deterministic Test Names ❌ Error Test test/envtest/suite_test.go uses fmt.Sprintf with variable featureSet in Ginkgo test names, violating stability requirement. Replace fmt.Sprintf test names with static strings; put dynamic values in test body. Use "should install all CRDs for feature set" instead of "should install all CRDs for feature set %q".
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically summarizes the main change: cloning ai-helpers into the workspace instead of /tmp for plugin file access, which aligns with the file modification and PR objectives.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Test Structure And Quality ✅ Passed Check not applicable: PR only modifies GitHub Actions workflow YAML, not Ginkgo test code. The custom check targets Ginkgo test code quality requirements.
Topology-Aware Scheduling Compatibility ✅ Passed The PR modifies a GitHub Actions workflow file, not Kubernetes deployment manifests, operator code, or controllers. The custom check does not apply.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR modifies a GitHub Actions workflow YAML file, not Ginkgo e2e tests. Custom check scope requires Ginkgo test declarations (It/Describe/Context/When) which are absent.
No-Weak-Crypto ✅ Passed The PR modifies only a GitHub Actions workflow YAML file that contains no cryptographic implementations, weak crypto imports (MD5/SHA1/DES/RC4/3DES/Blowfish/ECB), or insecure secret comparisons.
Container-Privileges ✅ Passed No privileged container directives found in the workflow (no privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation). PR moves away from container-based approaches.
No-Sensitive-Data-In-Logs ✅ Passed PR changes cloning location to GITHUB_WORKSPACE without introducing logging of sensitive data. Configuration is written to files via redirection, not logged. No new sensitive data exposure.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@celebdor
celebdor merged commit 164df89 into openshift:main May 28, 2026
12 of 17 checks passed
@bryan-cox

Copy link
Copy Markdown
Member Author

/test-wif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/needs-area jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants