Skip to content

NO-JIRA: bump claude max-turns to 50 in WIF test - #8619

Merged
celebdor merged 1 commit into
openshift:mainfrom
bryan-cox:test-arc-runners
May 28, 2026
Merged

NO-JIRA: bump claude max-turns to 50 in WIF test#8619
celebdor merged 1 commit into
openshift:mainfrom
bryan-cox:test-arc-runners

Conversation

@bryan-cox

@bryan-cox bryan-cox commented May 28, 2026

Copy link
Copy Markdown
Member

Summary

  • Bumps --max-turns from 1 to 50 in the WIF test workflow
  • The previous run failed with Error: Reached max turns (1) because Claude used its single turn on plugin initialization

Test plan

  • Merge and trigger /test-wif on any open PR

🤖 Generated with Claude Code

Summary by CodeRabbit

Release Notes

This release contains internal infrastructure updates only. No user-facing changes to document.

  • Chores
    • Updated testing infrastructure configuration for improved validation processes.

The container: directive requires containerMode on ARC runners which
needs anyuid SCC and a long-running process. Replace it by installing
Claude and cloning ai-helpers directly in workflow steps.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 28, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@bryan-cox: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

  • Bumps --max-turns from 1 to 50 in the WIF test workflow
  • The previous run failed with Error: Reached max turns (1) because Claude used its single turn on plugin initialization

Test plan

  • Merge and trigger /test-wif on any open PR

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Please specify an area label

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

This PR modifies the GitHub Actions workflow for testing Claude Code WIF (Workload Identity Federation) authentication. The change increases the --max-turns parameter in the "Test Claude Code" step from 1 to 50, allowing the SBOM generation test to perform more interaction turns with the Claude Code tool while maintaining the same prompt, model selection, and output capture to /tmp/claude-output.txt.

Possibly Related PRs

  • openshift/hypershift#8598: Both PRs modify the same GitHub Actions workflow claude-wif-test.yaml, specifically the "Test Claude Code" step with different parameter adjustments.

  • openshift/hypershift#8614: Both PRs modify the same Claude Code test step to generate and validate AI-SBOM output, with this PR's max-turns increase supporting the related verification logic.

  • openshift/hypershift#8600: Both PRs adjust the same Claude Code WIF test execution in the workflow, with complementary changes to test configuration and environment setup.

Suggested Reviewers

  • muraee
  • Nirshal

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name Status Explanation Resolution
No-Sensitive-Data-In-Logs ❌ Error Increasing --max-turns to 50 expands Claude output logging via tee and error cat, exposing code patterns and project details in public GitHub logs. Remove tee piping or suppress error logging to prevent exposure of sensitive project/code information in CI logs.
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: bumping the Claude max-turns parameter from 1 to 50 in the WIF test workflow.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only .github/workflows/claude-wif-test.yaml (GitHub Actions config), containing no Ginkgo tests. The custom check for stable Ginkgo test names is not applicable to this PR.
Test Structure And Quality ✅ Passed The PR modifies only a GitHub Actions workflow file (.github/workflows/claude-wif-test.yaml), not Ginkgo test code. The custom check is designed for Go test files and is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only a GitHub Actions workflow file, not Kubernetes manifests, operator code, or controllers; check does not apply.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo e2e tests are added in this PR. Only a GitHub Actions workflow config file is modified, making the IPv6 check inapplicable.
No-Weak-Crypto ✅ Passed PR only modifies GitHub Actions workflow parameter (--max-turns). No weak crypto algorithms, custom implementations, or secret comparisons are introduced.
Container-Privileges ✅ Passed Workflow file contains no privileged container configurations or privilege escalation flags. PR removes container directive per summary.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
openshift-ci Bot requested review from csrwng and devguyio May 28, 2026 11:10
@openshift-ci

openshift-ci Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2026
@celebdor
celebdor merged commit 34376ae into openshift:main May 28, 2026
12 of 17 checks passed
@bryan-cox

Copy link
Copy Markdown
Member Author

/test-wif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/needs-area jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants