OCPBUGS-89360: NO-JIRA: build(operator): drop hypershift-no-cgo from operator container images #8601
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,15 +6,11 @@ WORKDIR /hypershift | |
| COPY --chown=default . . | ||
|
|
||
| RUN make hypershift \ | ||
| && make hypershift-operator \ | ||
| && make karpenter-operator | ||
|
|
||
| FROM registry.access.redhat.com/ubi9/ubi-minimal:9.7-1777857961 | ||
| COPY --from=builder /hypershift/bin/hypershift \ | ||
|
Contributor
There was a problem hiding this comment. Why remove
Contributor
Author
There was a problem hiding this comment. We build product-cli using https://github.com/openshift/hypershift/blob/main/Containerfile.cli |
||
| /hypershift/bin/hypershift-operator \ | ||
| /hypershift/bin/karpenter-operator \ | ||
| /usr/bin/ | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why removing product-cli? Are we supposed to remove only
hypershift-no-cgo?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We build product-cli using https://github.com/openshift/hypershift/blob/main/Containerfile.cli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry but I don't understand. Can you shed more light on this? The fact that you build product-cli using that container file doesn't explain to me why you're removing
make product-cli.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean. This looks like completely unrelated to
hypershift-no-cgo. I don't see any relation. So maybe this should be sent as a separate PR with a better description?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mgencur Removing the product-cli seems unrelated but this PR is about removing non-FIPS compliant binaries that are not necessary to run the hypershift operator from the container image and the product-cli is another non-FIPS compliant binary. We deliver the product-cli in a separate CLI download container image and make it available from the cluster for users to download and use.