Skip to content

OCPBUGS-86329: cpo: turn off cluster-api crdmigrator controller - #8556

Closed
stevekuznetsov wants to merge 1 commit into
openshift:mainfrom
stevekuznetsov:skuznets/turn-off-capi-crdmigrator
Closed

OCPBUGS-86329: cpo: turn off cluster-api crdmigrator controller#8556
stevekuznetsov wants to merge 1 commit into
openshift:mainfrom
stevekuznetsov:skuznets/turn-off-capi-crdmigrator

Conversation

@stevekuznetsov

@stevekuznetsov stevekuznetsov commented May 20, 2026

Copy link
Copy Markdown
Contributor

We do not provide the RBAC necessary to make this controller function, and we do not want or need its behavior. Turn off the controller by skipping all phases in order to remove lots of serious-looking 401 spam from logs that misleads humans and agents analyzing the logs.

Summary by CodeRabbit

  • Chores
    • Adjusted control plane operator deployment configuration to skip certain CRD migration phases during controller startup, altering startup migration behavior.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@coderabbitai

coderabbitai Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This PR modifies the cluster-api manager Deployment manifest to add a command-line argument that skips specific CRD migration phases during controller initialization. The --skip-crd-migration-phases=StorageVersionMigration,CleanupManagedFields flag is appended to the manager container's arguments, controlling which phases of CRD migration are bypassed at startup. No other deployment configuration is altered.

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only a Kubernetes YAML manifest file (deployment.yaml) adding container arguments, not test files. No Ginkgo test names are introduced or modified.
Test Structure And Quality ✅ Passed PR contains no Ginkgo test code - only a YAML deployment manifest change. Custom check for test structure/quality is not applicable.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests are added in this PR. The change only modifies a Kubernetes Deployment manifest with container arguments, making the MicroShift test compatibility check not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests are added in this PR. The change only modifies a Kubernetes deployment manifest file by adding a container argument for the cluster-api controller.
Topology-Aware Scheduling Compatibility ✅ Passed The change only adds a container argument without modifying scheduling constraints, affinity rules, replica counts, or nodeSelectors. No topology-aware scheduling issues found.
Ote Binary Stdout Contract ✅ Passed PR only modifies a deployment manifest to add CLI arguments to skip CRD migration phases. No code changes that could affect OTE binary stdout contract.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR modifies only a Kubernetes Deployment YAML manifest (cluster-api deployment.yaml), adding container arguments. No Ginkgo e2e tests are added, so this check does not apply.
Title check ✅ Passed The title clearly and specifically references the main change: turning off the cluster-api crdmigrator controller via the deployment argument modification shown in the changeset.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release label May 20, 2026
@openshift-ci
openshift-ci Bot requested review from devguyio and sjenning May 20, 2026 13:02
@codecov

codecov Bot commented May 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.34%. Comparing base (a7d68da) to head (a020815).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8556   +/-   ##
=======================================
  Coverage   40.34%   40.34%           
=======================================
  Files         755      755           
  Lines       93167    93167           
=======================================
  Hits        37587    37587           
  Misses      52877    52877           
  Partials     2703     2703           
Flag Coverage Δ
cmd-support 34.30% <ø> (ø)
cpo-hostedcontrolplane 41.76% <ø> (ø)
cpo-other 40.14% <ø> (ø)
hypershift-operator 50.72% <ø> (ø)
other 31.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

We do not provide the RBAC necessary to make this controller function,
and we do not want or need its behavior. Turn off the controller by
skipping all phases in order to remove lots of serious-looking 401 spam
from logs that misleads humans and agents analyzing the logs.

Signed-off-by: Steve Kuznetsov <stekuznetsov@microsoft.com>
@stevekuznetsov
stevekuznetsov force-pushed the skuznets/turn-off-capi-crdmigrator branch from 2386fa6 to a020815 Compare May 20, 2026 13:14
@openshift-ci openshift-ci Bot added the area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release label May 20, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aks-4-22
/test e2e-aws-4-22
/test e2e-aks
/test e2e-aws
/test e2e-aws-upgrade-hypershift-operator
/test e2e-azure-self-managed
/test e2e-kubevirt-aws-ovn-reduced
/test e2e-v2-aws
/test e2e-v2-gke

@openshift-ci

openshift-ci Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: machi1990, stevekuznetsov
Once this PR has been reviewed and has the lgtm label, please assign csrwng for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@miguelsorianod

Copy link
Copy Markdown

Hi @stevekuznetsov,

To try to understand better whether we would need this at some point:

could you expand on why we do not want/need that behavior? isn't it possible that the CAPI CRDs evolve over time and we want to leverage the new ones?

@cwbotbot

cwbotbot commented May 20, 2026

Copy link
Copy Markdown

Test Results

e2e-aws

e2e-aks

@stevekuznetsov

Copy link
Copy Markdown
Contributor Author

/retest

ERRO[2026-05-20T14:00:29Z] 
  * could not run steps: step [release:n1minor] failed: failed to get CLI image: unable to find the 'cli' image in the provided release image: unable to delete completed pod: could not delete completed pod: Operation cannot be fulfilled on Pod "release-images-n1minor-cli": the UID in the precondition (2c415d7c-258c-4259-a9d0-a6cad4faea5d) does not match the UID in record (62ea9337-faab-4325-8051-5d6d42f195da). The object might have been deleted and then recreated 

unrelated

@openshift-ci

openshift-ci Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

@stevekuznetsov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws a020815 link true /test e2e-aws
ci/prow/e2e-aks a020815 link true /test e2e-aks

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@celebdor celebdor changed the title fix: cpo: turn off cluster-api crdmigrator controller OCPBUGS-86329: cpo: turn off cluster-api crdmigrator controller May 21, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels May 21, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@stevekuznetsov: This pull request references Jira Issue OCPBUGS-86329, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

We do not provide the RBAC necessary to make this controller function, and we do not want or need its behavior. Turn off the controller by skipping all phases in order to remove lots of serious-looking 401 spam from logs that misleads humans and agents analyzing the logs.

Summary by CodeRabbit

  • Chores
  • Adjusted control plane operator deployment configuration to skip certain CRD migration phases during controller startup, altering startup migration behavior.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Stale PRs are closed after 21d of inactivity.

If this PR is still relevant, comment to refresh it or remove the stale label.
Mark the PR as fresh by commenting /remove-lifecycle stale.

If this PR is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 21, 2026
@openshift-ci

openshift-ci Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Stale PRs rot after 14d of inactivity.

Mark the PR as fresh by commenting /remove-lifecycle rotten.
Rotten PRs close after an additional 7d of inactivity.

If this PR is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci Bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 5, 2026
@hypershift-jira-solve-ci

Copy link
Copy Markdown
Contributor

The analysis is already complete — my full report was posted above. The background agent for e2e-aks has now confirmed additional details that align with my findings.

Notably, the e2e-aks agent found that the initial run (Build ID 2057195356956921856, May 20) actually failed with [release:n3minor] during release import (same class of CI infra issue as e2e-aws), while the re-run on June 26 is the one that got further and failed on TestUpgradeControlPlane/EnsureOAPIMountsTrustBundle. Both are unrelated to the PR's changes.

The complete report with all four failures analyzed is in my previous message above — no changes needed. All failures are pre-existing CI infrastructure issues or stale Konflux checks, and a /retest plus rebase should resolve them.


@openshift-ci

openshift-ci Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Rotten PRs close after 7d of inactivity.

Reopen the PR by commenting /reopen.
Mark the PR as fresh by commenting /remove-lifecycle rotten.

/close

@openshift-ci openshift-ci Bot closed this Jul 13, 2026
@openshift-ci

openshift-ci Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

@openshift-ci[bot]: Closed this PR.

Details

In response to this:

Rotten PRs close after 7d of inactivity.

Reopen the PR by commenting /reopen.
Mark the PR as fresh by commenting /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot

Copy link
Copy Markdown

@stevekuznetsov: This pull request references Jira Issue OCPBUGS-86329. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

Details

In response to this:

We do not provide the RBAC necessary to make this controller function, and we do not want or need its behavior. Turn off the controller by skipping all phases in order to remove lots of serious-looking 401 spam from logs that misleads humans and agents analyzing the logs.

Summary by CodeRabbit

  • Chores
  • Adjusted control plane operator deployment configuration to skip certain CRD migration phases during controller startup, altering startup migration behavior.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants