[release-4.22] OCPBUGS-86026: Fix metrics-proxy deployment failure due to dots in volume names - #8534
Conversation
The certVolumesFromMonitors function used Secret/ConfigMap resource names directly as Kubernetes volume names. Volume names must conform to RFC 1123 DNS label rules which prohibit dots. When a ServiceMonitor references a ConfigMap named "openshift-service-ca.crt" in its TLS config, the resulting volume name is rejected by the API server. Replace dots with dashes in volume and volumeMount names while preserving the original resource name in ConfigMap/Secret source references and mount paths. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@openshift-cherrypick-robot: An error was encountered cloning bug for cherrypick for bug OCPBUGS-85763 on the Jira server at https://redhat.atlassian.net. No known errors were detected, please see the full error message for details. Full error message.
request failed. Please analyze the request body for more details. Status code: 400: {"errorMessages":[],"errors":{"customfield_10001":"Team id 'JsonData{data={avatarUrl=, id=a5267ed5-eaa8-4cd6-90e3-d0ce145dbfbf, isShared=true, isVerified=false, isVisible=true, name=[ROSA] HCP Platform, title=[ROSA] HCP Platform}}' is not valid."}}
Please contact an administrator to resolve this issue, then request a bug refresh with DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-86026, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@celebdor: This pull request references Jira Issue OCPBUGS-86026, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
The cherry-picked test used newCertVolumeTestContext and assertCertVolumeCount helpers that only exist on main. Replace with inline fakeClient and cpContext construction matching the existing test style on the release-4.22 branch. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
/jira refresh |
|
@celebdor: This pull request references Jira Issue OCPBUGS-86026, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-4.22 #8534 +/- ##
=============================================
Coverage 34.86% 34.86%
=============================================
Files 767 767
Lines 93445 93451 +6
=============================================
+ Hits 32579 32585 +6
Misses 58187 58187
Partials 2679 2679
🚀 New features to boost your workflow:
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: muraee, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified by unit-test |
|
@joshbranham: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
71b460f
into
openshift:release-4.22
|
@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-86026 Jira Issue OCPBUGS-86026 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Fix included in release 4.22.0-0.nightly-2026-05-20-020825 |
This is an automated cherry-pick of #8530
/assign joshbranham