NO-JIRA: fix(e2e): use public multi-arch image for ARM64 karpenter test - #8532
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@maxcao13: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis pull request updates the ARM64 provisioning subtest in the Karpenter e2e tests: it changes the workload image passed to testWorkloadWithImage from quay.io/hypershift/sleep:multiarch to registry.access.redhat.com/ubi10/ubi-minimal:10.1, and modifies testWorkloadWithImage to set the container command to "/bin/sh -c "sleep infinity"" so the Deployment pod stays running for the duration of the test. Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 9 | ❌ 3❌ Failed checks (3 warnings)
✅ Passed checks (9 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/e2e/karpenter_test.go`:
- Line 319: The test hardcodes the image "registry.k8s.io/pause:3.10" when
creating armWorkLoads via testWorkloadWithImage, which prevents overriding in
disconnected CI; make the image configurable by reading a test parameter or
environment variable (e.g., TEST_PAUSE_IMAGE or a test flag) and pass that value
into testWorkloadWithImage for both armWorkLoads and any similar calls, falling
back to "registry.k8s.io/pause:3.10" if the variable is unset so local runs keep
the current behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 4c05d8f1-85cd-4639-bdc5-018f09ae1cf3
📒 Files selected for processing (1)
test/e2e/karpenter_test.go
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8532 +/- ##
=======================================
Coverage 40.34% 40.34%
=======================================
Files 755 755
Lines 93167 93167
=======================================
Hits 37587 37587
Misses 52877 52877
Partials 2703 2703
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
/lgtm |
|
Scheduling tests matching the |
Test Resultse2e-aws
e2e-aks
|
|
/retest-required |
1 similar comment
|
/retest-required |
|
Wow, haven't seen that one before. /retest-required |
c4ca08f to
d1c9e6f
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/e2e/karpenter_test.go`:
- Line 319: Replace the non-deterministic UBI image tag used when creating the
ARM workload: in the call to testWorkloadWithImage that constructs armWorkLoads,
change the image string "registry.access.redhat.com/ubi9/ubi-minimal:latest" to
a pinned, specific version (e.g.,
"registry.access.redhat.com/ubi9/ubi-minimal:9.7" or a timestamped build tag) so
tests are reproducible; update only the image argument in the armWorkLoads
assignment where testWorkloadWithImage is invoked.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 995fac25-1d90-4bbf-9969-eeca78d73ec5
📒 Files selected for processing (1)
test/e2e/karpenter_test.go
|
Scheduling tests matching the |
d1c9e6f to
4cedb62
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csrwng, maxcao13 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Scheduling tests matching the |
|
/retest-required |
|
/verified by @maxcao13 |
|
@maxcao13: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
1 similar comment
|
/retest |
quay.io/hypershift/sleep:multiarch is a private image that requires auth not available in CI pull secrets, causing ImagePullBackOff. Use registry.access.redhat.com/ubi10/ubi-minimal:10.1 which is public and multi-arch. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Max Cao <macao@redhat.com>
4cedb62 to
83b7c2d
Compare
|
@maxcao13: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
Scheduling tests matching the |
|
/test e2e-aws-4-22 |
|
/test e2e-aks |
|
/test e2e-aws-4-22 |
|
/verified by @maxcao13 |
|
@maxcao13: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@maxcao13: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
quay.io/hypershift/sleep:multiarch is a private image that requires auth not available in CI pull secrets, causing ImagePullBackOff. Use registry.k8s.io/pause:3.10 which is public and multi-arch.
See rehearsals failures here: openshift/release#79262
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes
Special notes for your reviewer:
Checklist:
Summary by CodeRabbit