Skip to content

replace m4.large default with m5.large #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Jan 13, 2022
Merged

replace m4.large default with m5.large #850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/v1alpha1/nodepool_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ type KubevirtNodePoolPlatform struct {
// AWSNodePoolPlatform specifies the configuration of a NodePool when operating
// on AWS.
type AWSNodePoolPlatform struct {
// InstanceType is an ec2 instance type for node instances (e.g. m4-large).
// InstanceType is an ec2 instance type for node instances (e.g. m5.large).
InstanceType string `json:"instanceType"`

// InstanceProfile is the AWS EC2 instance profile, which is a container for an IAM role that the EC2 instance uses.
Expand Down
2 changes: 1 addition & 1 deletion cmd/cluster/aws/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ func NewCreateCommand(opts *core.CreateOptions) *cobra.Command {
opts.AWSPlatform = core.AWSPlatformOptions{
AWSCredentialsFile: "",
Region: "us-east-1",
InstanceType: "m4.large",
InstanceType: "m5.large",
RootVolumeType: "gp3",
RootVolumeSize: 120,
RootVolumeIOPS: 0,
Expand Down
2 changes: 1 addition & 1 deletion cmd/install/assets/hypershift-operator/hypershift.openshift.io_nodepools.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ spec:
type: string
instanceType:
description: InstanceType is an ec2 instance type for node
instances (e.g. m4-large).
instances (e.g. m5.large).
type: string
resourceTags:
description: "ResourceTags is an optional list of additional
Expand Down
2 changes: 1 addition & 1 deletion cmd/nodepool/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ func NewCreateCommand() *cobra.Command {
ClusterName: "example",
NodeCount: 2,
ReleaseImage: "",
InstanceType: "m4.large",
InstanceType: "m5.large",
RootVolumeType: "gp3",
RootVolumeSize: 120,
RootVolumeIOPS: 0,
Expand Down
2 changes: 1 addition & 1 deletion docs/content/reference/api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -895,7 +895,7 @@ string
</em>
</td>
<td>
<p>InstanceType is an ec2 instance type for node instances (e.g. m4-large).</p>
<p>InstanceType is an ec2 instance type for node instances (e.g. m5.large).</p>
</td>
</tr>
<tr>
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/e2e_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ func (o *options) DefaultClusterOptions() core.CreateOptions {
PullSecretFile: o.configurableClusterOptions.PullSecretFile,
ControlPlaneOperatorImage: o.configurableClusterOptions.ControlPlaneOperatorImage,
AWSPlatform: core.AWSPlatformOptions{
InstanceType: "m4.large",
InstanceType: "m5.large",
RootVolumeSize: 64,
RootVolumeType: "gp3",
AWSCredentialsFile: o.configurableClusterOptions.AWSCredentialsFile,
Expand Down