Skip to content

CNTRLPLANE-507: Add HCP finalizer to AWSEndpointService reconciler - #8499

Closed
hypershift-jira-solve-ci[bot] wants to merge 4 commits into
openshift:mainfrom
hypershift-community:fix-CNTRLPLANE-507
Closed

hypershift-jira-solve-ci[bot] wants to merge 4 commits into
openshift:mainfrom
hypershift-community:fix-CNTRLPLANE-507

fix(awsprivatelink): handle NotFound when removing HCP finalizer

a2f22c7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 10, 2026 in 1s

43.59% (+0.08%) compared to 8b5103a

View this Pull Request on Codecov

43.59% (+0.08%) compared to 8b5103a

Details

Codecov Report

❌ Patch coverage is 77.77778% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.59%. Comparing base (8b5103a) to head (a2f22c7).
⚠️ Report is 31 commits behind head on main.

Files with missing lines Patch % Lines
...ollers/awsprivatelink/awsprivatelink_controller.go 77.77% 29 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8499      +/-   ##
==========================================
+ Coverage   43.50%   43.59%   +0.08%     
==========================================
  Files         771      771              
  Lines       95722    95786      +64     
==========================================
+ Hits        41648    41760     +112     
+ Misses      51174    51121      -53     
- Partials     2900     2905       +5     
Files with missing lines Coverage Δ
...trollers/hostedcluster/hostedcluster_controller.go 55.18% <ø> (+0.45%) ⬆️
...ollers/awsprivatelink/awsprivatelink_controller.go 48.15% <77.77%> (+6.50%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.