Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,12 @@ func adaptDeployment(cpContext component.WorkloadContext, deployment *appsv1.Dep
Name: "CANARY_IMAGE", Value: cpContext.UserReleaseImageProvider.GetImage("cluster-ingress-operator"),
})

if cpContext.HCP.Spec.FIPS {
util.UpsertEnvVar(c, corev1.EnvVar{
Name: "FIPS_ENABLED", Value: "true",
})
}

// For managed Azure deployments, we pass an environment variable, MANAGED_AZURE_HCP_CREDENTIALS_FILE_PATH, so
// we authenticate with Azure API through UserAssignedCredential authentication. We also mount the
// SecretProviderClass for the Secrets Store CSI driver to use; it will grab the JSON object stored in the
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
package ingressoperator

import (
"testing"

. "github.com/onsi/gomega"

hyperv1 "github.com/openshift/hypershift/api/hypershift/v1beta1"
assets "github.com/openshift/hypershift/control-plane-operator/controllers/hostedcontrolplane/v2/assets"
component "github.com/openshift/hypershift/support/controlplane-component"
"github.com/openshift/hypershift/support/testutil"
"github.com/openshift/hypershift/support/util"

corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)

func TestAdaptDeployment(t *testing.T) {
t.Parallel()

testCases := []struct {
name string
fips bool
validate func(*WithT, *corev1.Container)
}{
{
name: "When FIPS is enabled, it should set FIPS_ENABLED env var to true",
fips: true,
validate: func(g *WithT, container *corev1.Container) {
g.Expect(container.Env).To(ContainElement(corev1.EnvVar{
Name: "FIPS_ENABLED",
Value: "true",
}))
},
},
{
name: "When FIPS is not enabled, it should not set FIPS_ENABLED env var",
fips: false,
validate: func(g *WithT, container *corev1.Container) {
for _, env := range container.Env {
g.Expect(env.Name).ToNot(Equal("FIPS_ENABLED"))
}
},
},
}

for _, tc := range testCases {
t.Run(tc.name, func(t *testing.T) {
t.Parallel()
g := NewWithT(t)

hcp := &hyperv1.HostedControlPlane{
ObjectMeta: metav1.ObjectMeta{
Name: "test-hcp",
Namespace: "test-namespace",
},
Spec: hyperv1.HostedControlPlaneSpec{
FIPS: tc.fips,
},
}

cpContext := component.WorkloadContext{
HCP: hcp,
UserReleaseImageProvider: testutil.FakeImageProvider(),
}

deployment, err := assets.LoadDeploymentManifest(ComponentName)
g.Expect(err).ToNot(HaveOccurred())

err = adaptDeployment(cpContext, deployment)
g.Expect(err).ToNot(HaveOccurred())

container := util.FindContainer(ComponentName, deployment.Spec.Template.Spec.Containers)
g.Expect(container).ToNot(BeNil(), "ingress-operator container should exist")

tc.validate(g, container)
})
}
}
Loading