Skip to content

CNTRLPLANE-3233: ci(gha): add release-4.22 branch to GitHub Actions workflows - #8217

Merged
celebdor merged 1 commit into
openshift:mainfrom
bryan-cox:add-gha-422
Apr 13, 2026
Merged

CNTRLPLANE-3233: ci(gha): add release-4.22 branch to GitHub Actions workflows#8217
celebdor merged 1 commit into
openshift:mainfrom
bryan-cox:add-gha-422

Conversation

@bryan-cox

@bryan-cox bryan-cox commented Apr 13, 2026

Copy link
Copy Markdown
Member

Summary

  • Add release-4.22 to the branch triggers for all applicable GitHub Actions workflows so PRs targeting that branch get the same CI checks as main
  • Replace hardcoded git fetch origin main:main in lint workflow with dynamic github.base_ref reference
  • sync-community-fork.yaml excluded (only relevant for main)

Updated workflows: codespell, cpo-container-sync, docs-preview, envtest-kube, envtest-ocp, gitlint, lint, test, verify

Resolves: CNTRLPLANE-3233

Test plan

  • Verify GHA workflows trigger on PRs targeting release-4.22
  • Verify GHA workflows still trigger on PRs targeting main
  • Verify lint job correctly fetches the base branch ref

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflow configurations to enable automated testing, verification, linting, and documentation processes on the release-4.22 branch in addition to the main development branch.

Add the release-4.22 branch to all applicable GHA workflow triggers so
PRs and pushes to that branch receive the same CI coverage as main.

Updated workflows: codespell, cpo-container-sync, docs-preview,
envtest-kube, envtest-ocp, gitlint, lint, test, and verify.

The lint workflow's hardcoded `git fetch origin main:main` is replaced
with a dynamic `github.base_ref` reference so it works correctly for
PRs targeting any configured branch.

sync-community-fork is excluded as it is only relevant for main.

Resolves: CNTRLPLANE-3233

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@coderabbitai

coderabbitai Bot commented Apr 13, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Multiple GitHub Actions workflows were updated to expand their trigger conditions. Each workflow now includes the release-4.22 branch alongside main in their branches filter for push, pull_request, or pull_request_target events. The affected workflows are: codespell, cpo-container-sync, docs-preview, envtest-kube, envtest-ocp, gitlint, lint, test, and verify. Additionally, the lint workflow was updated to dynamically use the PR base branch reference instead of a hardcoded main branch in its git fetch command.

🚥 Pre-merge checks | ✅ 10
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed PR modifies only GitHub Actions workflow files without changing any Ginkgo test code, making the stable test names check not applicable.
Test Structure And Quality ✅ Passed This custom check reviews Ginkgo test code quality, but the PR contains only GitHub Actions workflow configuration changes with no test code files modified.
Microshift Test Compatibility ✅ Passed PR only modifies GitHub Actions workflow files in .github/workflows/ directory. No new Ginkgo e2e test code (It(), Describe(), Context(), When(), etc.) has been added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR modifies only GitHub Actions workflow YAML files without adding new Ginkgo e2e tests, making SNO Test Compatibility check not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only GitHub Actions workflow files to extend CI/CD triggers to release-4.22 branch; contains no deployment manifests, operator code, or Kubernetes scheduling configurations.
Ote Binary Stdout Contract ✅ Passed PR only modifies GitHub Actions workflow YAML configuration files, not executable application code. OTE Binary Stdout Contract check targets process-level code entry points.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No Go test files in diff; PR only modifies GitHub Actions workflow YAML files for release-4.22 branch CI triggers.
Title check ✅ Passed The title accurately and specifically describes the main change: adding release-4.22 branch support to GitHub Actions workflows.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci

openshift-ci Bot commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
openshift-ci Bot requested review from csrwng and devguyio April 13, 2026 12:57
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2026
@bryan-cox bryan-cox changed the title ci(gha): add release-4.22 branch to GitHub Actions workflows CNTRLPLANE-3233: ci(gha): add release-4.22 branch to GitHub Actions workflows Apr 13, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 13, 2026
@openshift-ci-robot

openshift-ci-robot commented Apr 13, 2026

Copy link
Copy Markdown

@bryan-cox: This pull request references CNTRLPLANE-3233 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

  • Add release-4.22 to the branch triggers for all applicable GitHub Actions workflows so PRs targeting that branch get the same CI checks as main
  • Replace hardcoded git fetch origin main:main in lint workflow with dynamic github.base_ref reference
  • sync-community-fork.yaml excluded (only relevant for main)

Updated workflows: codespell, cpo-container-sync, docs-preview, envtest-kube, envtest-ocp, gitlint, lint, test, verify

Resolves: CNTRLPLANE-3233

Test plan

  • Verify GHA workflows trigger on PRs targeting release-4.22
  • Verify GHA workflows still trigger on PRs targeting main
  • Verify lint job correctly fetches the base branch ref

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
  • Updated CI/CD workflow configurations to enable automated testing, verification, linting, and documentation processes on the release-4.22 branch in addition to the main development branch.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bryan-cox

Copy link
Copy Markdown
Member Author

/area ci-tooling

@openshift-ci openshift-ci Bot added area/ci-tooling Indicates the PR includes changes for CI or tooling and removed do-not-merge/needs-area labels Apr 13, 2026

@jparrill jparrill left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification

No second-stage tests were triggered for this PR.

This can happen when:

  • The changed files don't match any pipeline_run_if_changed patterns
  • All files match pipeline_skip_if_only_changed patterns
  • No pipeline-controlled jobs are defined for the main branch

Use /test ? to see all available tests.

@jparrill

Copy link
Copy Markdown
Contributor

/verified by Github Actions

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 13, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@jparrill: This PR has been marked as verified by Github Actions.

Details

In response to this:

/verified by Github Actions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@celebdor
celebdor merged commit 72647a4 into openshift:main Apr 13, 2026
9 of 10 checks passed
@bryan-cox
bryan-cox deleted the add-gha-422 branch April 13, 2026 13:10
@dgoodwin

Copy link
Copy Markdown
Contributor

This popped up as a pr without coderabbit review, any idea why? Was this opened in draft by any chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci-tooling Indicates the PR includes changes for CI or tooling jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants