Skip to content

CNTRLPLANE-3215: fix envtest GHA workflow path filters for CRD test suites - #8200

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
bryan-cox:fix-gha-envtest-paths
Apr 10, 2026
Merged

CNTRLPLANE-3215: fix envtest GHA workflow path filters for CRD test suites#8200
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
bryan-cox:fix-gha-envtest-paths

Conversation

@bryan-cox

@bryan-cox bryan-cox commented Apr 10, 2026

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Fixes the path filters in the envtest GitHub Actions workflows (envtest-kube.yaml and envtest-ocp.yaml).

The workflows were configured to trigger on changes to cmd/install/assets/hypershift-operator/tests/**, but the actual CRD test suite files live under cmd/install/assets/crds/hypershift-operator/tests/** (missing the crds/ path segment). This caused the envtest workflows to never trigger when CRD test suites were added or modified — as seen in PR #8199.

Which issue(s) this PR fixes:

Fixes CNTRLPLANE-3215

Special notes for your reviewer:

The fix is a simple path correction in both workflow files — adding the missing crds/ directory segment to the path filter.

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Summary by CodeRabbit

  • Chores
    • Updated continuous integration workflow triggers to monitor test asset changes from a reorganized location, ensuring automated testing runs appropriately.

The path filter in both envtest-kube.yaml and envtest-ocp.yaml
referenced cmd/install/assets/hypershift-operator/tests/** but the
actual test files live under cmd/install/assets/crds/hypershift-operator/tests/**.
The missing crds/ segment caused the workflows to never trigger when
CRD test suites were added or modified.

Signed-off-by: Bryan Cox <brcox@redhat.com>
Commit-Message-Assisted-by: Claude (via Claude Code)
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 10, 2026
@openshift-ci-robot

openshift-ci-robot commented Apr 10, 2026

Copy link
Copy Markdown

@bryan-cox: This pull request references CNTRLPLANE-3215 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:

Fixes the path filters in the envtest GitHub Actions workflows (envtest-kube.yaml and envtest-ocp.yaml).

The workflows were configured to trigger on changes to cmd/install/assets/hypershift-operator/tests/**, but the actual CRD test suite files live under cmd/install/assets/crds/hypershift-operator/tests/** (missing the crds/ path segment). This caused the envtest workflows to never trigger when CRD test suites were added or modified — as seen in PR #8199.

Which issue(s) this PR fixes:

Fixes CNTRLPLANE-3215

Special notes for your reviewer:

The fix is a simple path correction in both workflow files — adding the missing crds/ directory segment to the path filter.

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2026
@coderabbitai

coderabbitai Bot commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: ce202fae-a8a1-48ff-9590-bc5c270577e7

📥 Commits

Reviewing files that changed from the base of the PR and between 6a33316 and 6172bc4.

📒 Files selected for processing (2)
  • .github/workflows/envtest-kube.yaml
  • .github/workflows/envtest-ocp.yaml

📝 Walkthrough

Walkthrough

Updated GitHub Actions workflow path filters in two workflow files. The monitored directory paths changed from cmd/install/assets/hypershift-operator/tests/** to cmd/install/assets/crds/hypershift-operator/tests/** in both envtest-kube.yaml and envtest-ocp.yaml. This ensures the workflows now trigger on changes to test assets in the new CRDs directory structure instead of the previous location.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@bryan-cox

Copy link
Copy Markdown
Member Author

/area ci-tooling

@openshift-ci openshift-ci Bot added area/ci-tooling Indicates the PR includes changes for CI or tooling and removed do-not-merge/needs-area labels Apr 10, 2026
@openshift-ci-robot

openshift-ci-robot commented Apr 10, 2026

Copy link
Copy Markdown

@bryan-cox: This pull request references CNTRLPLANE-3215 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:

Fixes the path filters in the envtest GitHub Actions workflows (envtest-kube.yaml and envtest-ocp.yaml).

The workflows were configured to trigger on changes to cmd/install/assets/hypershift-operator/tests/**, but the actual CRD test suite files live under cmd/install/assets/crds/hypershift-operator/tests/** (missing the crds/ path segment). This caused the envtest workflows to never trigger when CRD test suites were added or modified — as seen in PR #8199.

Which issue(s) this PR fixes:

Fixes CNTRLPLANE-3215

Special notes for your reviewer:

The fix is a simple path correction in both workflow files — adding the missing crds/ directory segment to the path filter.

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Summary by CodeRabbit

  • Chores
  • Updated continuous integration workflow triggers to monitor test asset changes from a reorganized location, ensuring automated testing runs appropriately.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jparrill jparrill left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jparrill

Copy link
Copy Markdown
Contributor

/verified by Github Actions

@jparrill

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification

No second-stage tests were triggered for this PR.

This can happen when:

  • The changed files don't match any pipeline_run_if_changed patterns
  • All files match pipeline_skip_if_only_changed patterns
  • No pipeline-controlled jobs are defined for the main branch

Use /test ? to see all available tests.

@bryan-cox

Copy link
Copy Markdown
Member Author

/verified bypass

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 10, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@bryan-cox: The verified label has been added.

Details

In response to this:

/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bryan-cox

Copy link
Copy Markdown
Member Author

/retest

@openshift-ci

openshift-ci Bot commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 08b7a93 into openshift:main Apr 10, 2026
11 checks passed
@bryan-cox
bryan-cox deleted the fix-gha-envtest-paths branch April 10, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci-tooling Indicates the PR includes changes for CI or tooling jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants