CNTRLPLANE-3215: fix envtest GHA workflow path filters for CRD test suites - #8200
Conversation
The path filter in both envtest-kube.yaml and envtest-ocp.yaml referenced cmd/install/assets/hypershift-operator/tests/** but the actual test files live under cmd/install/assets/crds/hypershift-operator/tests/**. The missing crds/ segment caused the workflows to never trigger when CRD test suites were added or modified. Signed-off-by: Bryan Cox <brcox@redhat.com> Commit-Message-Assisted-by: Claude (via Claude Code)
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@bryan-cox: This pull request references CNTRLPLANE-3215 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bryan-cox The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughUpdated GitHub Actions workflow path filters in two workflow files. The monitored directory paths changed from ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/area ci-tooling |
|
@bryan-cox: This pull request references CNTRLPLANE-3215 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified by Github Actions |
|
/lgtm |
|
Pipeline controller notification No second-stage tests were triggered for this PR. This can happen when:
Use |
|
/verified bypass |
|
@bryan-cox: The DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
@bryan-cox: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What this PR does / why we need it:
Fixes the path filters in the envtest GitHub Actions workflows (
envtest-kube.yamlandenvtest-ocp.yaml).The workflows were configured to trigger on changes to
cmd/install/assets/hypershift-operator/tests/**, but the actual CRD test suite files live undercmd/install/assets/crds/hypershift-operator/tests/**(missing thecrds/path segment). This caused the envtest workflows to never trigger when CRD test suites were added or modified — as seen in PR #8199.Which issue(s) this PR fixes:
Fixes CNTRLPLANE-3215
Special notes for your reviewer:
The fix is a simple path correction in both workflow files — adding the missing
crds/directory segment to the path filter.Checklist:
Summary by CodeRabbit