Skip to content

CNTRLPLANE-2678: add HCPEtcdBackup controller to HyperShift Operator #8139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 3 commits into from
Apr 8, 2026
Merged

CNTRLPLANE-2678: add HCPEtcdBackup controller to HyperShift Operator #8139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7ba69a
feat(CNTRLPLANE-2678): add HCPEtcdBackup controller to HyperShift Ope…
jparrill Apr 6, 2026
a8c34f7
test(CNTRLPLANE-2678): add integration tests for HCPEtcdBackup contro…
jparrill Apr 6, 2026
b920edf
fix(CNTRLPLANE-2678): prevent rejected backup from deleting shared re…
jparrill Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions api/hypershift/v1beta1/etcdbackup_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,11 @@ const (
// BackupCompleted indicates whether the etcd backup has completed.
BackupCompleted ConditionType = "BackupCompleted"

BackupSucceededReason string = "BackupSucceeded"
BackupFailedReason string = "BackupFailed"
BackupAlreadyInProgressReason string = "BackupAlreadyInProgress"
EtcdUnhealthyReason string = "EtcdUnhealthy"
BackupSucceededReason string = "BackupSucceeded"
BackupFailedReason string = "BackupFailed"
BackupInProgressReason string = "BackupInProgress"
BackupRejectedReason string = "BackupRejected"
EtcdUnhealthyReason string = "EtcdUnhealthy"
)

// HCPEtcdBackupStorageType is the type of storage for etcd backups.
Expand Down
5 changes: 5 additions & 0 deletions api/hypershift/v1beta1/hostedcluster_conditions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,11 @@ const (
// recovery job was triggered.
EtcdRecoveryActive ConditionType = "EtcdRecoveryActive"

// EtcdBackupSucceeded bubbles up from HCP. It indicates the result of the
// most recent etcd backup. True means the last backup completed successfully;
// False means a backup is in progress or the last backup failed.

@enxebre enxebre Apr 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will we need a history like API instead of this?

@jparrill jparrill Apr 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, I'd wait for feedback from users (ROSA, ARO, self-managed) before adding a history-like API. Not sure how useful it would be to put that info in the HC when other observability tools can cover the historical view. If there's demand, we can add a status.backupHistory[] in a follow-up.

EtcdBackupSucceeded ConditionType = "EtcdBackupSucceeded"

// ClusterSizeComputed indicates that a t-shirt size was computed for this HostedCluster.
// The last transition time for this condition is used to manage how quickly transitions occur.
ClusterSizeComputed = "ClusterSizeComputed"
Expand Down
5 changes: 5 additions & 0 deletions docs/content/reference/aggregated-docs.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions docs/content/reference/api.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading