Skip to content

OCPBUGS-79502: Bump e2e AWS instance types to accommodate AutoSizingReserved - #8064

Closed
nispriha wants to merge 1 commit into
openshift:mainfrom
nispriha:njagan/bump_e2e_instance
Closed

OCPBUGS-79502: Bump e2e AWS instance types to accommodate AutoSizingReserved#8064
nispriha wants to merge 1 commit into
openshift:mainfrom
nispriha:njagan/bump_e2e_instance

Conversation

@nispriha

Copy link
Copy Markdown

What this PR does / why we need it:

AutoSizingReserved was enabled by default in OCP 4.21 (openshift/machine-config-operator#5390), which dynamically reserves system memory based on node size. On the m5.xlarge and m5.large instances used by Hypershift e2e tests, this increases system-reserved memory enough to prevent platform pods from scheduling, causing Cluster Operator degradation and test failures.

This PR bumps the instance types to the next size up to provide sufficient allocatable memory for all platform pods with AutoSizingReserved enabled.

Which issue(s) this PR fixes:

Fixes OCPBUGS-79502

Special notes for your reviewer:

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

AutoSizingReserved was enabled by default in OCP 4.21 (openshift/machine-config-operator#5390),
which dynamically reserves system memory based on node size. On the
m5.xlarge and m5.large instances used by Hypershift e2e tests, this
increases system-reserved memory enough to prevent platform pods from
scheduling, causing Cluster Operator degradation and test failures.

Bumping the instance types to the next size up provides sufficient
allocatable memory for all platform pods with AutoSizingReserved
enabled.

Ref: OCPBUGS-79502
@openshift-ci-robot

Copy link
Copy Markdown

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci

openshift-ci Bot commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 25, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@nispriha: This pull request references Jira Issue OCPBUGS-79502, which is invalid:

  • expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

What this PR does / why we need it:

AutoSizingReserved was enabled by default in OCP 4.21 (openshift/machine-config-operator#5390), which dynamically reserves system memory based on node size. On the m5.xlarge and m5.large instances used by Hypershift e2e tests, this increases system-reserved memory enough to prevent platform pods from scheduling, causing Cluster Operator degradation and test failures.

This PR bumps the instance types to the next size up to provide sufficient allocatable memory for all platform pods with AutoSizingReserved enabled.

Which issue(s) this PR fixes:

Fixes OCPBUGS-79502

Special notes for your reviewer:

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: a85f069a-b720-40fb-9183-0962ed1fe277

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added do-not-merge/needs-area area/testing Indicates the PR includes changes for e2e testing labels Mar 25, 2026
@openshift-ci

openshift-ci Bot commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nispriha
Once this PR has been reviewed and has the lgtm label, please assign sjenning for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

@nispriha: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hypershift-jira-solve-ci

Copy link
Copy Markdown
Contributor

Test Failure Analysis Complete

Job Information

  • Prow Job: Red Hat Konflux / hypershift-operator-main-on-pull-request
  • Build ID: hypershift-operator-main-on-pull-request-jvlhm
  • Pipeline Run: hypershift-operator-main-on-pull-request-jvlhm
  • Started: 2026-03-25T06:41:55Z
  • Completed: 2026-03-25T06:42:05Z (10 seconds — no build tasks executed)

Test Failure Analysis

Error

invalid result reference in pipeline task "clone-repository": "build" is not a named result returned by pipeline task "init"

Summary

This is not a test failure and is completely unrelated to the PR changes. The Konflux Tekton pipeline definition for hypershift-operator-main-on-pull-request had a misconfigured task result reference at the time PR #8064 was submitted (March 25, 2026). The clone-repository pipeline task referenced a result named "build" from the "init" task, but the init task did not declare a result with that name. This caused the pipeline to fail at validation within 10 seconds — no actual build, test, or compilation step ever ran. The PR's changes (bumping AWS e2e instance types from m5.xlarge/m5.large to m5.2xlarge/m5.xlarge) were never evaluated by this pipeline run.

Root Cause

The root cause is a transient Konflux pipeline infrastructure misconfiguration, not a code defect.

The Tekton PipelineRun hypershift-operator-main-on-pull-request-jvlhm failed during pipeline validation — before any tasks were scheduled. The pipeline definition referenced $(tasks.init.results.build) in the clone-repository task's parameters, but the init task's result list did not include a result named build. This is a Tekton pipeline authoring error in the Konflux pipeline definition maintained for the hypershift-operator-main component in the crt-redhat-acm-tenant namespace.

This has since been fixed: PR #8267 (submitted April 16, 2026) passes the same hypershift-operator-main-on-pull-request check successfully, confirming the pipeline definition was corrected between March 25 and April 16.

The two other Konflux checks on the same commit — hypershift-cli-mce-217-on-pull-request and hypershift-release-mce-217-on-pull-request — both passed successfully, further confirming this was isolated to the hypershift-operator-main pipeline definition.

Recommendations
  1. Re-trigger the check: Push a no-op commit or rebase the branch to trigger a new Konflux pipeline run. The pipeline definition has been fixed and the check should pass now.
  2. No code changes needed: The PR's changes (bumping AWS instance types in test/e2e/autoscaling_test.go, test/e2e/nodepool_rolling_upgrade_test.go, and test/e2e/util/requestserving.go) are not related to this failure in any way.
  3. If the failure persists after re-trigger: Escalate to the Konflux/Red Hat ACM tenant team responsible for the hypershift-operator-main component pipeline definitions in the crt-redhat-acm-tenant namespace.
Evidence
Evidence Detail
Error message invalid result reference in pipeline task "clone-repository": "build" is not a named result returned by pipeline task "init"
Pipeline duration 10 seconds (06:41:55–06:42:05) — failed at validation, no tasks executed
Failure scope Only hypershift-operator-main-on-pull-request failed; hypershift-cli-mce-217-on-pull-request and hypershift-release-mce-217-on-pull-request both passed on the same commit
PR changes Only test files modified: test/e2e/autoscaling_test.go, test/e2e/nodepool_rolling_upgrade_test.go, test/e2e/util/requestserving.go — instance type bumps only
Current state PR #8267 (April 16, 2026) passes hypershift-operator-main-on-pull-request successfully — pipeline definition has been fixed
Downstream checks cancelled hypershift-operator-main-enterprise-contract and hypershift-operator-enterprise-contract were cancelled because the build pipeline never produced an image

@nispriha nispriha closed this May 5, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@nispriha: This pull request references Jira Issue OCPBUGS-79502. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

What this PR does / why we need it:

AutoSizingReserved was enabled by default in OCP 4.21 (openshift/machine-config-operator#5390), which dynamically reserves system memory based on node size. On the m5.xlarge and m5.large instances used by Hypershift e2e tests, this increases system-reserved memory enough to prevent platform pods from scheduling, causing Cluster Operator degradation and test failures.

This PR bumps the instance types to the next size up to provide sufficient allocatable memory for all platform pods with AutoSizingReserved enabled.

Which issue(s) this PR fixes:

Fixes OCPBUGS-79502

Special notes for your reviewer:

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/testing Indicates the PR includes changes for e2e testing do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants