CNTRLPLANE-2678: Adapt etcd-backup command and add HO namespace manifests - #8040
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@jparrill: This pull request references CNTRLPLANE-2678 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@jparrill: This pull request references CNTRLPLANE-2678 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold This PR depends on #8010 ( |
9e1d594 to
f27d0d8
Compare
|
Scheduling tests matching the |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jparrill, sdminonne The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f27d0d8 to
0519ba4
Compare
Test Resultse2e-aws
e2e-aks
|
0519ba4 to
f33b5cd
Compare
|
Addressed reviewer comments + rebase to catch Konflux fixes |
|
@jparrill: This pull request references CNTRLPLANE-2678 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
… manifests Update the etcd-backup subcommand default cert paths to align with the fetch-etcd-certs output directory (PR openshift#8010). Add new manifest functions for HO namespace deployment: EtcdBackupJob, EtcdBackupJobServiceAccount, EtcdBackupJobRole, EtcdBackupJobRoleBinding, EtcdBackupNetworkPolicy. Preserve backward compatibility with existing EtcdBackupCronJob and EtcdBackupServiceAccount. Ref: CNTRLPLANE-2678 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Juan Manuel Parrilla Madrid <jparrill@redhat.com>
f33b5cd to
49f78fb
Compare
49f78fb to
1d910b0
Compare
mgencur
left a comment
There was a problem hiding this comment.
Looks good, just a few minor things.
…lows Add integration tests that validate the etcd backup process against a live management cluster. Two test scenarios are covered: - HO namespace flow: creates cross-namespace RBAC, NetworkPolicy, and a Job using fetch-etcd-certs (PR openshift#8010) + etcdctl snapshot + etcdutl verify as a mock of the future HCPEtcdBackup controller. - HCP namespace flow (legacy): creates a Job directly in the HCP namespace mounting etcd-client-tls and etcd-ca as volumes. Both tests verify snapshot integrity via etcdutl snapshot status. Ref: CNTRLPLANE-2678 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Juan Manuel Parrilla Madrid <jparrill@redhat.com>
1d910b0 to
1ffbb61
Compare
|
/lgtm |
|
Scheduling tests matching the |
|
/retest-required |
|
I have tested the changes in this PR, it looks good to me, the test plan and report is attached in the linked Jira comment. One query about the
|
|
/verified by @gaol I will tag the |
|
@gaol: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@jparrill: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
…ackup CNTRLPLANE-2678: Adapt etcd-backup command and add HO namespace manifests
|
/jira backport release-4.21,release-4.20 |
|
@jparrill: Missing required branches for backport chain:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira backport release-4.22,release-4.21,release-4.20 |
|
@jparrill: The following backport issues have been created: Queuing cherrypicks to the requested branches to be created after this PR merges: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-ci-robot: #8040 failed to apply on top of branch "release-4.20": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@openshift-ci-robot: #8040 failed to apply on top of branch "release-4.21": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@openshift-ci-robot: #8040 failed to apply on top of branch "release-4.22": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Adjust code from PRs openshift#8010, openshift#8017, openshift#8040 to compile on release-4.21: - etcd-upload: migrate S3TransferAPI from transfermanager v0.1 API (PutObject/PutObjectInput) to v0.2 API (UploadObject/UploadObjectInput) resolved by go mod tidy on this branch. Regenerate mock accordingly. - etcd-backup: fix mapToTags to use url.Values for proper URL-encoding of S3 object tag keys/values (bug exposed by backported tests). - go.mod/vendor: add aws-sdk-go-v2 direct dependencies (config, s3, transfermanager) and Azure azblob SDK required by etcd-upload, then run go mod tidy + go mod vendor. Ref: CNTRLPLANE-2678 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Juan Manuel Parrilla Madrid <jparrill@redhat.com>
Summary
etcd-backupCPO subcommand to work when the backup Job runs from the HO namespace, aligning cert paths with thefetch-etcd-certssubcommand from PR CNTRLPLANE-2678: Add fetch-etcd-certs CPO subcommand for HCPEtcdBackup #8010.etcd-backup(upload responsibility moves to a separateetcd-uploadstep).EtcdBackupJob,EtcdBackupJobServiceAccount,EtcdBackupJobRole,EtcdBackupJobRoleBinding,EtcdBackupNetworkPolicy.EtcdBackupCronJobandEtcdBackupServiceAccount.Dependencies
fetch-etcd-certssubcommand)Related PRs
Test plan
etcd-backupcommand flags and defaultsmake verifypassesHow to run integration tests
KUBECONFIG=/path/to/management-cluster/kubeconfig \ ETCD_BACKUP_TEST_HCP_NAMESPACE=clusters-my-hcp \ go test -tags integration -v -timeout 10m ./test/integration/oadp/backup/...Ref: CNTRLPLANE-2678
🤖 Generated with Claude Code