fix: add --self-signed-webhook-certs for non-OpenShift clusters - #8000
Closed
bryan-cox wants to merge 10 commits into
Closed
fix: add --self-signed-webhook-certs for non-OpenShift clusters#8000bryan-cox wants to merge 10 commits into
bryan-cox wants to merge 10 commits into
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (251)
📒 Files selected for processing (6)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis pull request updates configuration and dependencies: ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bryan-cox The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
area/api
Member
Author
|
/test e2e-aws |
openshift-ci
Bot
added
area/hypershift-operator
Member
Author
|
/test e2e-aks |
openshift-ci
Bot
added
area/platform/gcp
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.golangci.yml (1)
61-64: Narrow this SA1019 exclusion to v1beta1-only imports.The regex
sigs.k8s.io/cluster-api/(.*)is overly broad. It suppresses deprecation warnings for v1beta2 packages (which are not deprecated), utility packages likesigs.k8s.io/cluster-api/util, and other non-v1beta1 imports. This can hide actionable deprecations outside the v1beta1 migration window.Update the pattern to match only v1beta1 packages:
Proposed narrowing
- text: 'SA1019: "sigs.k8s.io/cluster-api/(.*)" is deprecated: This package is deprecated and is going to be removed when support for v1beta1 will be dropped.' + text: 'SA1019: "sigs.k8s.io/cluster-api/.*v1beta1.*" is deprecated'🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.golangci.yml around lines 61 - 64, The SA1019 exclusion pattern in .golangci.yml is too broad; update the regex that currently matches "sigs.k8s.io/cluster-api/(.*)" to only target v1beta1 imports (e.g. replace with a pattern like "^sigs\\.k8s\\.io/cluster-api/.*/v1beta1(/.*)?$") so it only suppresses deprecation warnings for v1beta1 packages; modify the SA1019 entry under the linters block in .golangci.yml accordingly and preserve the rest of the YAML structure.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.golangci.yml:
- Around line 61-64: The SA1019 exclusion pattern in .golangci.yml is too broad;
update the regex that currently matches "sigs.k8s.io/cluster-api/(.*)" to only
target v1beta1 imports (e.g. replace with a pattern like
"^sigs\\.k8s\\.io/cluster-api/.*/v1beta1(/.*)?$") so it only suppresses
deprecation warnings for v1beta1 packages; modify the SA1019 entry under the
linters block in .golangci.yml accordingly and preserve the rest of the YAML
structure.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 44ea1637-73ad-4185-8fea-19a5de6a55d0
⛔ Files ignored due to path filters (278)
api/go.sumis excluded by!**/*.sumapi/vendor/github.com/emicklei/go-restful/v3/.travis.ymlis excluded by!**/vendor/**api/vendor/github.com/emicklei/go-restful/v3/CHANGES.mdis excluded by!**/vendor/**api/vendor/github.com/emicklei/go-restful/v3/README.mdis excluded by!**/vendor/**api/vendor/github.com/emicklei/go-restful/v3/curly.gois excluded by!**/vendor/**api/vendor/github.com/emicklei/go-restful/v3/custom_verb.gois excluded by!**/vendor/**api/vendor/github.com/emicklei/go-restful/v3/doc.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/jsonpointer/.cliff.tomlis excluded by!**/vendor/**api/vendor/github.com/go-openapi/jsonpointer/.gitignoreis excluded by!**/vendor/**api/vendor/github.com/go-openapi/jsonpointer/.golangci.ymlis excluded by!**/vendor/**api/vendor/github.com/go-openapi/jsonpointer/CONTRIBUTORS.mdis excluded by!**/vendor/**api/vendor/github.com/go-openapi/jsonpointer/LICENSEis excluded by!**/vendor/**api/vendor/github.com/go-openapi/jsonpointer/NOTICEis excluded by!**/vendor/**api/vendor/github.com/go-openapi/jsonpointer/README.mdis excluded by!**/vendor/**api/vendor/github.com/go-openapi/jsonpointer/SECURITY.mdis excluded by!**/vendor/**api/vendor/github.com/go-openapi/jsonpointer/errors.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/jsonpointer/pointer.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/jsonreference/.cliff.tomlis excluded by!**/vendor/**api/vendor/github.com/go-openapi/jsonreference/.editorconfigis excluded by!**/vendor/**api/vendor/github.com/go-openapi/jsonreference/.golangci.ymlis excluded by!**/vendor/**api/vendor/github.com/go-openapi/jsonreference/CONTRIBUTORS.mdis excluded by!**/vendor/**api/vendor/github.com/go-openapi/jsonreference/NOTICEis excluded by!**/vendor/**api/vendor/github.com/go-openapi/jsonreference/README.mdis excluded by!**/vendor/**api/vendor/github.com/go-openapi/jsonreference/SECURITY.mdis excluded by!**/vendor/**api/vendor/github.com/go-openapi/jsonreference/internal/normalize_url.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/jsonreference/reference.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/.codecov.ymlis excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/.golangci.ymlis excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/.mockery.ymlis excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/README.mdis excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/SECURITY.mdis excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/cmdutils/LICENSEis excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/cmdutils/cmd_utils.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/cmdutils/doc.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/cmdutils_iface.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/conv/LICENSEis excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/conv/convert.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/conv/convert_types.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/conv/doc.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/conv/format.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/conv/sizeof.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/conv/type_constraints.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/conv_iface.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/convert.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/convert_types.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/doc.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/errors.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/file.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/fileutils/LICENSEis excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/fileutils/doc.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/fileutils/file.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/fileutils/path.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/fileutils_iface.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/go.workis excluded by!**/*.work,!**/vendor/**api/vendor/github.com/go-openapi/swag/go.work.sumis excluded by!**/*.sum,!**/vendor/**api/vendor/github.com/go-openapi/swag/initialism_index.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/json.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/jsonname/LICENSEis excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/jsonname/doc.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/jsonname/name_provider.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/jsonname_iface.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/jsonutils/LICENSEis excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/jsonutils/README.mdis excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/jsonutils/adapters/doc.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/jsonutils/adapters/ifaces/doc.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/jsonutils/adapters/ifaces/ifaces.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/jsonutils/adapters/ifaces/registry_iface.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/jsonutils/adapters/registry.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/jsonutils/adapters/stdlib/json/adapter.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/jsonutils/adapters/stdlib/json/doc.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/jsonutils/adapters/stdlib/json/lexer.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/jsonutils/adapters/stdlib/json/ordered_map.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/jsonutils/adapters/stdlib/json/pool.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/jsonutils/adapters/stdlib/json/register.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/jsonutils/adapters/stdlib/json/writer.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/jsonutils/concat.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/jsonutils/doc.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/jsonutils/json.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/jsonutils/ordered_map.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/jsonutils_iface.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/loading/LICENSEis excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/loading/doc.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/loading/errors.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/loading/json.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/loading/loading.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/loading/options.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/loading/yaml.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/loading_iface.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/mangling/BENCHMARK.mdis excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/mangling/LICENSEis excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/mangling/doc.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/mangling/initialism_index.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/mangling/name_lexem.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/mangling/name_mangler.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/mangling/options.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/mangling/pools.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/mangling/split.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/mangling/string_bytes.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/mangling/util.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/mangling_iface.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/name_lexem.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/net.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/netutils/LICENSEis excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/netutils/doc.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/netutils/net.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/netutils_iface.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/split.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/stringutils/LICENSEis excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/stringutils/collection_formats.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/stringutils/doc.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/stringutils/strings.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/stringutils_iface.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/typeutils/LICENSEis excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/typeutils/doc.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/typeutils/types.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/typeutils_iface.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/util.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/yaml.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/yamlutils/LICENSEis excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/yamlutils/doc.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/yamlutils/errors.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/yamlutils/ordered_map.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/yamlutils/yaml.gois excluded by!**/vendor/**api/vendor/github.com/go-openapi/swag/yamlutils_iface.gois excluded by!**/vendor/**api/vendor/github.com/google/gnostic-models/extensions/extension.protois excluded by!**/vendor/**api/vendor/github.com/google/gnostic-models/openapiv2/OpenAPIv2.protois excluded by!**/vendor/**api/vendor/github.com/google/gnostic-models/openapiv3/OpenAPIv3.protois excluded by!**/vendor/**api/vendor/github.com/google/gnostic-models/openapiv3/annotations.protois excluded by!**/vendor/**api/vendor/github.com/josharian/intern/README.mdis excluded by!**/vendor/**api/vendor/github.com/josharian/intern/intern.gois excluded by!**/vendor/**api/vendor/github.com/josharian/intern/license.mdis excluded by!**/vendor/**api/vendor/github.com/mailru/easyjson/LICENSEis excluded by!**/vendor/**api/vendor/github.com/mailru/easyjson/buffer/pool.gois excluded by!**/vendor/**api/vendor/github.com/mailru/easyjson/jlexer/bytestostr.gois excluded by!**/vendor/**api/vendor/github.com/mailru/easyjson/jlexer/bytestostr_nounsafe.gois excluded by!**/vendor/**api/vendor/github.com/mailru/easyjson/jlexer/error.gois excluded by!**/vendor/**api/vendor/github.com/mailru/easyjson/jlexer/lexer.gois excluded by!**/vendor/**api/vendor/github.com/mailru/easyjson/jwriter/writer.gois excluded by!**/vendor/**api/vendor/github.com/pkg/errors/.gitignoreis excluded by!**/vendor/**api/vendor/github.com/pkg/errors/.travis.ymlis excluded by!**/vendor/**api/vendor/github.com/pkg/errors/LICENSEis excluded by!**/vendor/**api/vendor/github.com/pkg/errors/Makefileis excluded by!**/vendor/**api/vendor/github.com/pkg/errors/README.mdis excluded by!**/vendor/**api/vendor/github.com/pkg/errors/appveyor.ymlis excluded by!**/vendor/**api/vendor/github.com/pkg/errors/errors.gois excluded by!**/vendor/**api/vendor/github.com/pkg/errors/go113.gois excluded by!**/vendor/**api/vendor/github.com/pkg/errors/stack.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/.golangci.ymlis excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/Makefileis excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/Makefile.commonis excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/arp.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/buddyinfo.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/cmdline.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/cpuinfo.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/cpuinfo_armx.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/cpuinfo_loong64.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/cpuinfo_mipsx.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/cpuinfo_others.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/cpuinfo_ppcx.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/cpuinfo_riscvx.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/cpuinfo_s390x.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/cpuinfo_x86.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/crypto.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/doc.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/fs.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/fs_statfs_notype.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/fs_statfs_type.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/fscache.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/internal/fs/fs.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/internal/util/parse.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/internal/util/readfile.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/internal/util/sysreadfile.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/internal/util/sysreadfile_compat.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/internal/util/valueparser.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/ipvs.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/kernel_hung.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/kernel_random.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/loadavg.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/mdstat.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/meminfo.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/mountinfo.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/mountstats.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/net_conntrackstat.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/net_dev.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/net_dev_snmp6.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/net_ip_socket.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/net_protocols.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/net_route.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/net_sockstat.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/net_softnet.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/net_tcp.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/net_tls_stat.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/net_udp.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/net_unix.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/net_wireless.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/net_xfrm.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/netstat.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/nfnetlink_queue.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/proc.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/proc_cgroup.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/proc_cgroups.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/proc_environ.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/proc_fdinfo.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/proc_interrupts.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/proc_io.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/proc_limits.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/proc_maps.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/proc_netstat.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/proc_ns.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/proc_psi.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/proc_smaps.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/proc_snmp.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/proc_snmp6.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/proc_stat.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/proc_statm.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/proc_status.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/proc_sys.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/schedstat.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/slab.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/softirqs.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/stat.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/swaps.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/thread.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/vm.gois excluded by!**/vendor/**api/vendor/github.com/prometheus/procfs/zoneinfo.gois excluded by!**/vendor/**api/vendor/gopkg.in/evanphx/json-patch.v4/README.mdis excluded by!**/vendor/**api/vendor/gopkg.in/evanphx/json-patch.v4/patch.gois excluded by!**/vendor/**api/vendor/gopkg.in/yaml.v3/LICENSEis excluded by!**/vendor/**api/vendor/gopkg.in/yaml.v3/NOTICEis excluded by!**/vendor/**api/vendor/gopkg.in/yaml.v3/README.mdis excluded by!**/vendor/**api/vendor/gopkg.in/yaml.v3/apic.gois excluded by!**/vendor/**api/vendor/gopkg.in/yaml.v3/decode.gois excluded by!**/vendor/**api/vendor/gopkg.in/yaml.v3/emitterc.gois excluded by!**/vendor/**api/vendor/gopkg.in/yaml.v3/encode.gois excluded by!**/vendor/**api/vendor/gopkg.in/yaml.v3/parserc.gois excluded by!**/vendor/**api/vendor/gopkg.in/yaml.v3/readerc.gois excluded by!**/vendor/**api/vendor/gopkg.in/yaml.v3/resolve.gois excluded by!**/vendor/**api/vendor/gopkg.in/yaml.v3/scannerc.gois excluded by!**/vendor/**api/vendor/gopkg.in/yaml.v3/sorter.gois excluded by!**/vendor/**api/vendor/gopkg.in/yaml.v3/writerc.gois excluded by!**/vendor/**api/vendor/gopkg.in/yaml.v3/yaml.gois excluded by!**/vendor/**api/vendor/gopkg.in/yaml.v3/yamlh.gois excluded by!**/vendor/**api/vendor/gopkg.in/yaml.v3/yamlprivateh.gois excluded by!**/vendor/**api/vendor/k8s.io/kube-openapi/pkg/validation/spec/ref.gois excluded by!**/vendor/**api/vendor/modules.txtis excluded by!**/vendor/**api/vendor/sigs.k8s.io/structured-merge-diff/v6/schema/elements.gois excluded by!**/vendor/**api/vendor/sigs.k8s.io/structured-merge-diff/v6/typed/remove.gois excluded by!**/vendor/**cmd/install/assets/cluster-api-provider-aws/infrastructure.cluster.x-k8s.io_awsclusters.yamlis excluded by!cmd/install/assets/**/*.yamlcmd/install/assets/cluster-api-provider-aws/infrastructure.cluster.x-k8s.io_awsmachinepools.yamlis excluded by!cmd/install/assets/**/*.yamlcmd/install/assets/cluster-api-provider-aws/infrastructure.cluster.x-k8s.io_awsmachines.yamlis excluded by!cmd/install/assets/**/*.yamlcmd/install/assets/cluster-api-provider-aws/infrastructure.cluster.x-k8s.io_awsmachinetemplates.yamlis excluded by!cmd/install/assets/**/*.yamlcmd/install/assets/cluster-api-provider-azure/infrastructure.cluster.x-k8s.io_azureclusters.yamlis excluded by!cmd/install/assets/**/*.yamlcmd/install/assets/cluster-api-provider-azure/infrastructure.cluster.x-k8s.io_azuremachinetemplates.yamlis excluded by!cmd/install/assets/**/*.yamlcmd/install/assets/cluster-api-provider-gcp/infrastructure.cluster.x-k8s.io_gcpclusters.yamlis excluded by!cmd/install/assets/**/*.yamlcmd/install/assets/cluster-api-provider-gcp/infrastructure.cluster.x-k8s.io_gcpclustertemplates.yamlis excluded by!cmd/install/assets/**/*.yamlcmd/install/assets/cluster-api-provider-gcp/infrastructure.cluster.x-k8s.io_gcpmachines.yamlis excluded by!cmd/install/assets/**/*.yamlcmd/install/assets/cluster-api-provider-gcp/infrastructure.cluster.x-k8s.io_gcpmachinetemplates.yamlis excluded by!cmd/install/assets/**/*.yamlcmd/install/assets/cluster-api-provider-ibmcloud/infrastructure.cluster.x-k8s.io_ibmpowervsclusters.yamlis excluded by!cmd/install/assets/**/*.yamlcmd/install/assets/cluster-api-provider-ibmcloud/infrastructure.cluster.x-k8s.io_ibmpowervsclustertemplates.yamlis excluded by!cmd/install/assets/**/*.yamlcmd/install/assets/cluster-api-provider-ibmcloud/infrastructure.cluster.x-k8s.io_ibmpowervsimages.yamlis excluded by!cmd/install/assets/**/*.yamlcmd/install/assets/cluster-api-provider-ibmcloud/infrastructure.cluster.x-k8s.io_ibmvpcclusters.yamlis excluded by!cmd/install/assets/**/*.yamlcmd/install/assets/cluster-api-provider-ibmcloud/infrastructure.cluster.x-k8s.io_ibmvpcclustertemplates.yamlis excluded by!cmd/install/assets/**/*.yamlcmd/install/assets/cluster-api-provider-ibmcloud/infrastructure.cluster.x-k8s.io_ibmvpcmachines.yamlis excluded by!cmd/install/assets/**/*.yamlcmd/install/assets/cluster-api-provider-kubevirt/infrastructure.cluster.x-k8s.io_kubevirtclustertemplates.yamlis excluded by!cmd/install/assets/**/*.yamlcmd/install/assets/cluster-api-provider-openstack/infrastructure.cluster.x-k8s.io_openstackclusters.yamlis excluded by!cmd/install/assets/**/*.yamlcmd/install/assets/cluster-api-provider-openstack/infrastructure.cluster.x-k8s.io_openstackclustertemplates.yamlis excluded by!cmd/install/assets/**/*.yamlcmd/install/assets/cluster-api/addons.cluster.x-k8s.io_clusterresourcesetbindings.yamlis excluded by!cmd/install/assets/**/*.yamlcmd/install/assets/cluster-api/addons.cluster.x-k8s.io_clusterresourcesets.yamlis excluded by!cmd/install/assets/**/*.yamlcmd/install/assets/cluster-api/cluster.x-k8s.io_clusterclasses.yamlis excluded by!cmd/install/assets/**/*.yamlcmd/install/assets/cluster-api/cluster.x-k8s.io_clusters.yamlis excluded by!cmd/install/assets/**/*.yamlcmd/install/assets/cluster-api/cluster.x-k8s.io_machinedeployments.yamlis excluded by!cmd/install/assets/**/*.yamlcmd/install/assets/cluster-api/cluster.x-k8s.io_machinedrainrules.yamlis excluded by!cmd/install/assets/**/*.yamlcmd/install/assets/cluster-api/cluster.x-k8s.io_machinehealthchecks.yamlis excluded by!cmd/install/assets/**/*.yamlcmd/install/assets/cluster-api/cluster.x-k8s.io_machinepools.yamlis excluded by!cmd/install/assets/**/*.yamlcmd/install/assets/cluster-api/cluster.x-k8s.io_machines.yamlis excluded by!cmd/install/assets/**/*.yamlcmd/install/assets/cluster-api/cluster.x-k8s.io_machinesets.yamlis excluded by!cmd/install/assets/**/*.yamlcmd/install/assets/cluster-api/ipam.cluster.x-k8s.io_ipaddressclaims.yamlis excluded by!cmd/install/assets/**/*.yamlcmd/install/assets/cluster-api/ipam.cluster.x-k8s.io_ipaddresses.yamlis excluded by!cmd/install/assets/**/*.yaml
📒 Files selected for processing (22)
.golangci.ymlDockerfileMakefileapi/go.modcmd/cluster/core/dump.gocmd/install/assets/assets.gocmd/install/assets/hypershift_operator.gocmd/install/install.gocmd/install/install_test.gocontrib/gomaxprocs-webhook/Dockerfilecontrol-plane-operator/controllers/hostedcontrolplane/v2/kas/kubeconfig.gocontrol-plane-operator/hostedclusterconfigoperator/api/scheme.gocontrol-plane-operator/hostedclusterconfigoperator/controllers/globalps/globalps.gocontrol-plane-operator/hostedclusterconfigoperator/controllers/globalps/globalps_test.gocontrol-plane-operator/hostedclusterconfigoperator/controllers/globalps/setup.gocontrol-plane-operator/hostedclusterconfigoperator/controllers/inplaceupgrader/inplaceupgrader.gocontrol-plane-operator/hostedclusterconfigoperator/controllers/inplaceupgrader/inplaceupgrader_test.gocontrol-plane-operator/hostedclusterconfigoperator/controllers/inplaceupgrader/setup.gocontrol-plane-operator/hostedclusterconfigoperator/controllers/machine/machine.gocontrol-plane-operator/hostedclusterconfigoperator/controllers/machine/machine_test.gocontrol-plane-operator/hostedclusterconfigoperator/controllers/machine/setup.gocontrol-plane-operator/hostedclusterconfigoperator/controllers/node/node.go
Member
Author
|
/test e2e-aks |
Member
Author
|
/test e2e-aws |
Test Resultse2e-aws
Failed TestsTotal failed tests: 8
... and 3 more failed tests e2e-aks
|
- Upgrade all CAPI modules to 1.11. - Update changed import paths - Silence depreciation linter errors - Update make cluster-api goal.
CAPI 1.11 defaults to v1beta2 storage. Override to v1beta1 for HyperShift compatibility. Signed-off-by: Borja Clemente <bclement@redhat.com>
Signed-off-by: Borja Clemente <bclement@redhat.com>
Signed-off-by: Borja Clemente <bclement@redhat.com>
Remove the temporary hardocded CAPI image overrides now that hypershift supports CAPI 1.11 Signed-off-by: Borja Clemente <bclement@redhat.com>
For conversion to work, the CAPI provider needs to be able to access CRDs cluster-wide to list available versions. Signed-off-by: Borja Clemente <bclement@redhat.com>
Update TestScaleFromZero to support both CAPI 1.11+ native Status.Capacity and pre-1.11 annotation-based capacity information. In CAPI 1.11, cluster-api-provider-aws now populates Status.Capacity directly on AWSMachineTemplate, making the workaround annotations unnecessary. The HyperShift controller detects this and skips setting annotations when Status.Capacity is present. The test now: - First checks AWSMachineTemplate.Status.Capacity (CAPI 1.11+) - Falls back to MachineDeployment annotations (pre-CAPI 1.11) - Logs the capacity source for debugging This makes the test backward compatible and fixes the failure in PR openshift#7590.
Setting the MinReadySeconds default to 0 explicitly on the nodepool controller causes infinite reconciliaiton due to a lossy v1beta1 -> v1beta2 conversion and flipping value between 0 and nil. Removing the explicit setting should not have any other side effect since the zero value of the field is the same. Signed-off-by: Borja Clemente <bclement@redhat.com>
CAPI 1.11 requires conversion webhooks (v1beta1<->v1beta2) which need TLS certificates. On OpenShift, service-ca provisions these automatically. On AKS/GKE, no service-ca exists, so the operator pods fail to start because the manager-serving-cert secret is never created. This adds a --self-signed-webhook-certs flag that generates a self-signed CA and serving certificate at install time, creates the secret directly, and sets caBundle on CRDs instead of relying on service-ca annotation injection. Also removes the dead EnableConversionWebhook flag (HyperShift CRD conversion for v1alpha1 is no longer needed since v1alpha1 was removed) and makes EnableWebhook always true since CAPI 1.11 conversion webhooks are always required. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
CAPI 1.11 moved api/v1beta1 to api/core/v1beta1. The version.go and version_test.go files were added to main after the CAPI 1.11 branch point and use the old import path. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
bryan-cox
force-pushed
the
capi-1.11-self-signed-certs
branch
from
March 18, 2026 16:26
caafbf6 to
4c468f0
Compare
Member
Author
|
/test e2e-aws |
Member
Author
|
/test e2e-aks |
Contributor
|
@bryan-cox: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Member
Author
|
/close |
Contributor
|
@bryan-cox: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP - Just testing a change on top of Borja's PR
Summary
--self-signed-webhook-certsflag tohypershift installthat generates a self-signed CA + serving cert at install time for CAPI CRD conversion webhooksmanager-serving-certsecret directly and setscaBundleon CRDsEnableConversionWebhookflag (HyperShift v1alpha1 CRD conversion is no longer needed)EnableWebhookalways true since CAPI 1.11 conversion webhooks are always requiredContext
CAPI 1.11 introduces v1beta2 alongside v1beta1. CRD storage is overridden to v1beta1 for backward compat, but CAPI 1.11 controllers use v1beta2 internally — this requires conversion webhooks. On AKS/GKE without this fix, removing
--enable-conversion-webhook=falsecauses the operator pods to fail because themanager-serving-certsecret is never created (no service-ca).Depends on: #7590 (CAPI 1.11 bump)
Follow-up needed: openshift/release PR to add
--self-signed-webhook-certsto AKS/GKE install commandsTest plan
go build ./cmd/install/...compiles cleanlygo build ./test/integration/framework/...compiles cleanlygo test ./cmd/install/...passesgo vet ./cmd/install/... ./test/integration/framework/...passeshypershift install --render --self-signed-webhook-certsproduces correct output (CRDs with caBundle, manager-serving-cert Secret, no service-ca annotations)hypershift install --render(without flag) produces correct output (CRDs with inject-cabundle annotation, service-ca annotations on Service)--self-signed-webhook-certsSummary by CodeRabbit