Make HostedControlPlane delete more robust - #8
Merged
Conversation
openshift-ci-robot
added
the
approved
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csrwng, derekwaynecarr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
zanetworker
pushed a commit
to zanetworker/hypershift
that referenced
this pull request
Sep 28, 2021
Add ability to wait for resource deletion
4 tasks
6 tasks
cblecker
added a commit
to cblecker/hypershift
that referenced
this pull request
May 29, 2026
Move E2E_ADDITIONAL_PULL_SECRET_FILE registration to the central env var catalog (Standard openshift#8) and replace defer with DeferCleanup for Ginkgo abort/timeout safety. Assisted-by: Claude:claude-sonnet-4-6
YamunadeviShanmugam
pushed a commit
to YamunadeviShanmugam/hypershift
that referenced
this pull request
Jun 5, 2026
Move E2E_ADDITIONAL_PULL_SECRET_FILE registration to the central env var catalog (Standard openshift#8) and replace defer with DeferCleanup for Ginkgo abort/timeout safety. Assisted-by: Claude:claude-sonnet-4-6
dhgautam99
pushed a commit
to dhgautam99/hypershift
that referenced
this pull request
Jun 9, 2026
Move E2E_ADDITIONAL_PULL_SECRET_FILE registration to the central env var catalog (Standard openshift#8) and replace defer with DeferCleanup for Ginkgo abort/timeout safety. Assisted-by: Claude:claude-sonnet-4-6
4 tasks
hypershift-jira-solve-ci Bot
pushed a commit
to hypershift-community/hypershift
that referenced
this pull request
Jul 9, 2026
The router's adaptConfig function lists existing Route objects to generate the HAProxy ConfigMap. When the router was registered early in the component list (position openshift#8), components that create Routes — ignition-server (openshift#35) and metrics-proxy (openshift#38) — had not yet run during the first reconcile pass. This caused the initial HAProxy config to miss ignition and metrics-proxy backends, routing ignition requests to the KAS default backend and failing NodePool ignition. Move the router component to after metricsproxyv2 (the last route-creating component) so that all Routes exist when the router config is generated. This reduces the race window between router config generation and route creation, though the informer cache update from watch events is still async so the ordering is not a hard guarantee. Signed-off-by: OpenShift CI Bot <ci-bot@redhat.com>
YamunadeviShanmugam
pushed a commit
to YamunadeviShanmugam/hypershift
that referenced
this pull request
Jul 27, 2026
Move E2E_ADDITIONAL_PULL_SECRET_FILE registration to the central env var catalog (Standard openshift#8) and replace defer with DeferCleanup for Ginkgo abort/timeout safety. Assisted-by: Claude:claude-sonnet-4-6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hosted control plane controller can get stuck deleting resources if certain resources have already been deleted or their CRD is no longer present. This change ignores those errors when deleting a hosted control plane.