NO-JIRA: Add CodeRabbit config to exclude autogenerated files by enxebre · Pull Request #7905 · openshift/hypershift

enxebre · 2026-03-10T12:37:00Z

Summary

Adds a .coderabbit.yaml configuration file modeled after openshift/api's config
Excludes all autogenerated files from CodeRabbit code reviews to reduce noise and focus reviews on human-written code
Excluded patterns include:
- vendor/ and api/vendor/ directories
- zz_generated* files (deepcopy, CRD manifests, swagger docs, etc.)
- client/ directory (generated clientsets, informers, listers)
- cmd/install/assets/**/*.yaml (generated CRD install assets)
- karpenter-operator/controllers/karpenter/assets/*.yaml (generated Karpenter CRDs)
- *_mock.go files (mockgen generated)
- *.pb.go / *.pb.gw.go / generated.proto (protobuf generated)
- docs/content/reference/api.md and aggregated-docs.md (generated API docs)
- cmd/infra/aws/delegating_client.go (generated delegating client)
- *_string.go files (stringer generated)

Test plan

Verify CodeRabbit picks up the config on subsequent PRs
Confirm autogenerated files are no longer reviewed by CodeRabbit

🤖 Generated with Claude Code

Summary by CodeRabbit

Chores
- Added configuration file to establish code review automation settings and exclude certain file types from analysis.

Adds a .coderabbit.yaml configuration file that excludes all autogenerated files from CodeRabbit code reviews. This includes vendor directories, generated deepcopy/CRD/client/mock/protobuf files, generated API docs, and other mechanically produced code that is not suitable for automated review. Modeled after openshift/api's .coderabbit.yaml configuration. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

openshift-ci-robot · 2026-03-10T12:37:04Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

coderabbitai · 2026-03-10T12:37:35Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro

Run ID: db62669e-ec64-4198-9dbf-12a0277128e2

📥 Commits

Reviewing files that changed from the base of the PR and between 5ed331f and 86c2351.

📒 Files selected for processing (1)

.coderabbit.yaml

📝 Walkthrough

Walkthrough

A new .coderabbit.yaml configuration file is added to define code-review automation. It configures inheritance, a "chill" review profile with toggles for summaries, walkthroughs, and statuses, extensive path_filters to exclude generated/vendor/mocks/clients/protobufs/CRDs/docs/testdata and related files, enables golangci-lint and gitleaks as tools, and configures a knowledge_base with code_guidelines (targeting AGENTS.md and related files) plus a local learnings scope.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and accurately summarizes the main change: adding a CodeRabbit configuration file to exclude autogenerated files from reviews.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names	✅ Passed	Pull request only modifies `.coderabbit.yaml` configuration file with no Ginkgo test code patterns present.
Test Structure And Quality	✅ Passed	The PR only introduces a .coderabbit.yaml configuration file with no Ginkgo test code, making this check not applicable to the PR's scope.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci-robot · 2026-03-10T12:39:00Z

@enxebre: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

Adds a .coderabbit.yaml configuration file modeled after openshift/api's config

Excludes all autogenerated files from CodeRabbit code reviews to reduce noise and focus reviews on human-written code

Excluded patterns include:

vendor/ and api/vendor/ directories

zz_generated* files (deepcopy, CRD manifests, swagger docs, etc.)

client/ directory (generated clientsets, informers, listers)

cmd/install/assets/**/*.yaml (generated CRD install assets)

karpenter-operator/controllers/karpenter/assets/*.yaml (generated Karpenter CRDs)

*_mock.go files (mockgen generated)

*.pb.go / *.pb.gw.go / generated.proto (protobuf generated)

docs/content/reference/api.md and aggregated-docs.md (generated API docs)

cmd/infra/aws/delegating_client.go (generated delegating client)

*_string.go files (stringer generated)

Test plan

Verify CodeRabbit picks up the config on subsequent PRs

Confirm autogenerated files are no longer reviewed by CodeRabbit

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-03-10T12:39:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [enxebre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.coderabbit.yaml:
- Around line 14-54: The path_filters entry "!client/**" excludes the client
package from sparse-checkout which breaks tooling and linting for files
importing client packages; remove or modify the "!client/**" filter in the
path_filters section so CodeRabbit and golangci-lint can fetch client/**, or
alternatively refactor the callers in test/integration/, hypershift-operator/,
control-plane-operator/, and control-plane-pki-operator/ to stop importing
client packages (clientsets, informers, apply configurations) so the exclusion
is safe; update the .coderabbit.yaml tools.golangci-lint settings only after
ensuring the client/** dependency is either included or eliminated.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 8477d4b2-c12d-4604-8f5a-4f681dd06ed1

📥 Commits

Reviewing files that changed from the base of the PR and between 08198a1 and 5ed331f.

📒 Files selected for processing (1)

.coderabbit.yaml

muraee · 2026-03-10T12:42:46Z

missing exclusion for test textures under /testdata

bryan-cox · 2026-03-10T12:39:55Z

+language: en-US
+reviews:
+  profile: chill
+  high_level_summary: false


Do we not find value in this?

bryan-cox · 2026-03-10T12:41:07Z

+  profile: chill
+  high_level_summary: false
+  review_status: true
+  commit_status: true


This and line 8 default to true already.

bryan-cox · 2026-03-10T12:41:17Z

+  commit_status: true
+  collapse_walkthrough: true
+  changed_files_summary: false
+  sequence_diagrams: false


Do we not find value in this?

bryan-cox · 2026-03-10T12:42:42Z

+
+    # Generated stringer files
+    - "!**/*_string.go"
+  tools:


We should add gitleaks

bryan-cox · 2026-03-10T12:43:25Z

+knowledge_base:
+  code_guidelines:
+    enabled: true
+    filePatterns:


Do we not want to include the hypershift sme files here too?

bryan-cox · 2026-03-10T12:43:56Z

/area ci-tooling

- Enable high_level_summary and sequence_diagrams - Remove review_status and commit_status (already default to true) - Add gitleaks tool - Include .claude/agents/*.md and .cursor/rules/*.mdc in knowledge_base code guidelines filePatterns Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

enxebre · 2026-03-10T12:47:43Z

/label tide/merge-method-squash

Test fixture files under testdata/ are not meaningful to review as they are static test inputs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

bryan-cox · 2026-03-10T12:54:07Z

/lgtm
/verified bypass

openshift-ci-robot · 2026-03-10T12:54:19Z

@bryan-cox: The verified label has been added.

Details

In response to this:

/lgtm
/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-03-10T12:55:41Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aks
/test e2e-aws
/test e2e-aws-upgrade-hypershift-operator
/test e2e-kubevirt-aws-ovn-reduced
/test e2e-v2-aws

openshift-ci · 2026-03-10T15:32:18Z

@enxebre: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aks	`86c2351`	link	true	`/test e2e-aks`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci Bot added the do-not-merge/needs-area label Mar 10, 2026

enxebre changed the title ~~Add CodeRabbit config to exclude autogenerated files~~ NO-JIRA: Add CodeRabbit config to exclude autogenerated files Mar 10, 2026

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 10, 2026

openshift-ci Bot requested review from jparrill and sjenning March 10, 2026 12:39

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2026

coderabbitai Bot reviewed Mar 10, 2026

View reviewed changes

Comment thread .coderabbit.yaml

bryan-cox reviewed Mar 10, 2026

View reviewed changes

openshift-ci Bot added area/ci-tooling Indicates the PR includes changes for CI or tooling and removed do-not-merge/needs-area labels Mar 10, 2026

openshift-ci Bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 10, 2026

chore: exclude testdata directories from CodeRabbit reviews

86c2351

Test fixture files under testdata/ are not meaningful to review as they are static test inputs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 10, 2026

openshift-ci Bot assigned bryan-cox Mar 10, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2026

enxebre mentioned this pull request Mar 10, 2026

Skip hypershift e2e jobs when only .coderabbit.yaml changes openshift/release#75997

Merged

2 tasks

enxebre merged commit cc479bc into openshift:main Mar 10, 2026
17 of 21 checks passed

This was referenced Apr 17, 2026

fix(ho): make e2e HostedCluster interactions platform-aware #7724

Closed

docs: add comprehensive code review standards from 10 PRs #7397

Closed

OCPBUGS-57640: add kube-scheduler service monitor #6880

Closed

This was referenced Apr 29, 2026

OCPBUGS-60093: fix(upsert): add desired-state hash to detect spec field removals #7713

Merged

[WIP] Om phase 2 wire om reconciler #7569

Closed

API-1835: wires event handlers for informers #7559

Closed

API-1835: intro dispatcher filters #7552

Closed

This was referenced May 11, 2026

Add instrumentation for contextual logging to include service provider keys #7412

Closed

OCPBUGS-62851: feat(e2e): add check for Service and Pod Monitors #6965

Closed

CNTRLPLANE-1042: Run EnsureNetworkPolicies on Azure #6328

Closed

hypershift-jira-solve-ci Bot mentioned this pull request Jun 11, 2026

[proposal] Test Bucketing Support for HyperShift E2E Tests #6096

Closed

4 tasks

hypershift-jira-solve-ci Bot mentioned this pull request Jun 25, 2026

WIP: chore(shared-ingress): Always allow /healthz KAS endpoint when AllowdCIDRBlocks #6618

Closed

4 tasks

Uh oh!

Conversation

enxebre commented Mar 10, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by CodeRabbit

Uh oh!

openshift-ci-robot commented Mar 10, 2026

Uh oh!

coderabbitai Bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Uh oh!

openshift-ci-robot commented Mar 10, 2026

Summary

Test plan

Uh oh!

openshift-ci Bot commented Mar 10, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

muraee commented Mar 10, 2026

Uh oh!

bryan-cox Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

bryan-cox Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

bryan-cox Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

bryan-cox Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

bryan-cox Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

bryan-cox commented Mar 10, 2026

Uh oh!

enxebre commented Mar 10, 2026

Uh oh!

bryan-cox commented Mar 10, 2026

Uh oh!

openshift-ci-robot commented Mar 10, 2026

Uh oh!

openshift-ci-robot commented Mar 10, 2026

Uh oh!

Uh oh!

openshift-ci Bot commented Mar 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

enxebre commented Mar 10, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Mar 10, 2026 •

edited

Loading