Skip to content

CNTRLPLANE-2677: Add HCPEtcdBackup CRD API and feature gate #7898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 2 commits into from
Mar 18, 2026
Merged

CNTRLPLANE-2677: Add HCPEtcdBackup CRD API and feature gate #7898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d399ad1
feat(api): register HCPEtcdBackup feature gate
jparrill Mar 9, 2026
7080fce
feat(api): add HCPEtcdBackup CRD types and extend ManagedEtcdSpec wit…
jparrill Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
366 changes: 366 additions & 0 deletions api/hypershift/v1beta1/etcdbackup_types.go
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions api/hypershift/v1beta1/featuregates/featureGate-Hypershift-Default.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@
},
{
"name": "GCPPlatform"
},
{
"name": "HCPEtcdBackup"
}
],
"enabled": [
Expand Down
3 changes: 3 additions & 0 deletions api/hypershift/v1beta1/featuregates/featureGate-Hypershift-TechPreviewNoUpgrade.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@
},
{
"name": "GCPPlatform"
},
{
"name": "HCPEtcdBackup"
}
],
"version": ""
Expand Down
3 changes: 3 additions & 0 deletions api/hypershift/v1beta1/featuregates/featureGate-SelfManagedHA-Default.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@
},
{
"name": "GCPPlatform"
},
{
"name": "HCPEtcdBackup"
}
],
"enabled": [
Expand Down
3 changes: 3 additions & 0 deletions api/hypershift/v1beta1/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@
},
{
"name": "GCPPlatform"
},
{
"name": "HCPEtcdBackup"
}
],
"version": ""
Expand Down
7 changes: 7 additions & 0 deletions api/hypershift/v1beta1/hostedcluster_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1885,6 +1885,13 @@ type ManagedEtcdSpec struct {
// storage specifies how etcd data is persisted.
// +required
Storage ManagedEtcdStorageSpec `json:"storage"`

// backup defines the backup configuration for managed etcd, including

@enxebre enxebre Mar 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: might want to doc here that this is only used when an HCPEtcdBackup CR exists.

@jparrill jparrill Mar 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

// optional KMS key settings for artifact encryption in cloud storage.
// This configuration is only used when an HCPEtcdBackup CR exists.
// +optional
// +openshift:enable:FeatureGate=HCPEtcdBackup
Backup HCPEtcdBackupConfig `json:"backup,omitzero"`
}

// ManagedEtcdStorageType is a storage type for an etcd cluster.
Expand Down
257 changes: 257 additions & 0 deletions api/hypershift/v1beta1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

37 changes: 37 additions & 0 deletions api/hypershift/v1beta1/zz_generated.featuregated-crd-manifests.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading