Drop unnecessary platform check #782
Conversation
|
✔️ Deploy Preview for hypershift-docs ready! 🔨 Explore the source changes: 29a256e 🔍 Inspect the deploy log: https://app.netlify.com/sites/hypershift-docs/deploys/61b88772cd01630009b070cf 😎 Browse the preview: https://deploy-preview-782--hypershift-docs.netlify.app |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
enxebre
force-pushed
the
reduce-platform-skew
branch
from
29a256e to
179136d
Compare
enxebre
force-pushed
the
reduce-platform-skew
branch
from
179136d to
1c8bae0
Compare
|
This change assumes that Not saying it is a bad assumption. Just want to make sure it is one we are intentional about. |
Right. I think it's a fair assumption from a domain space pov and the fact we have different types for it is an implementation detail we choose for programming convenience, let me know if you think otherwise. |
|
/test e2e-aws |
|
/lgtm |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@enxebre: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
4 participants
Drop unnecessary platform check.