Kubevirt platform #779
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| package kubevirt | ||
|
|
||
| import ( | ||
| "context" | ||
| "errors" | ||
| "fmt" | ||
| "os" | ||
| "os/signal" | ||
| "syscall" | ||
|
|
||
| apifixtures "github.com/openshift/hypershift/api/fixtures" | ||
| "github.com/openshift/hypershift/cmd/cluster/core" | ||
| "github.com/spf13/cobra" | ||
| utilrand "k8s.io/apimachinery/pkg/util/rand" | ||
| ) | ||
|
|
||
| func NewCreateCommand(opts *core.CreateOptions) *cobra.Command { | ||
| cmd := &cobra.Command{ | ||
| Use: "kubevirt", | ||
| Short: "Creates basic functional HostedCluster resources for KubeVirt platform", | ||
| SilenceUsage: true, | ||
| } | ||
|
|
||
| opts.KubevirtPlatform = core.KubevirtPlatformCreateOptions{ | ||
| Memory: "4Gi", | ||
| Cores: 2, | ||
| ContainerDiskImage: "", | ||
| } | ||
|
|
||
| cmd.Flags().StringVar(&opts.KubevirtPlatform.Memory, "memory", opts.KubevirtPlatform.Memory, "The amount of memory which is visible inside the Guest OS (type BinarySI, e.g. 5Gi, 100Mi)") | ||
| cmd.Flags().Uint32Var(&opts.KubevirtPlatform.Cores, "cores", opts.KubevirtPlatform.Cores, "The number of cores inside the vmi, Must be a value greater or equal 1") | ||
|
Member
There was a problem hiding this comment.
Should we validate this below and fail otherwise? the way it's now zero would pass through right?
Contributor
Author
There was a problem hiding this comment. Added validation in |
||
| cmd.Flags().StringVar(&opts.KubevirtPlatform.ContainerDiskImage, "containerdisk", opts.KubevirtPlatform.ContainerDiskImage, "A reference to docker image with the embedded disk to be used to create the machines") | ||
|
|
||
| cmd.Run = func(cmd *cobra.Command, args []string) { | ||
| ctx, cancel := context.WithCancel(context.Background()) | ||
| sigs := make(chan os.Signal, 1) | ||
| signal.Notify(sigs, syscall.SIGINT) | ||
| go func() { | ||
| <-sigs | ||
| cancel() | ||
| }() | ||
|
|
||
| if err := CreateCluster(ctx, opts); err != nil { | ||
| log.Error(err, "Failed to create cluster") | ||
| os.Exit(1) | ||
| } | ||
| } | ||
|
|
||
| return cmd | ||
| } | ||
|
|
||
| func CreateCluster(ctx context.Context, opts *core.CreateOptions) error { | ||
| return core.CreateCluster(ctx, opts, applyPlatformSpecificsValues) | ||
| } | ||
|
|
||
| func applyPlatformSpecificsValues(ctx context.Context, exampleOptions *apifixtures.ExampleOptions, opts *core.CreateOptions) (err error) { | ||
| if opts.KubevirtPlatform.APIServerAddress == "" { | ||
| if opts.KubevirtPlatform.APIServerAddress, err = core.GetAPIServerAddressByNode(ctx); err != nil { | ||
| return err | ||
| } | ||
| } | ||
|
|
||
| if opts.NodePoolReplicas > -1 { | ||
| // TODO (nargaman): replace with official container image, after RFE-2501 is completed | ||
| // As long as there is no official container image | ||
| // The image must be provided by user | ||
| // Otherwise it must fail | ||
| if opts.KubevirtPlatform.ContainerDiskImage == "" { | ||
| return errors.New("the container disk image for the Kubevirt machine must be provided by user (\"--containerdisk\" flag)") | ||
| } | ||
| } | ||
|
|
||
| if opts.KubevirtPlatform.Cores < 1 { | ||
| return errors.New("the number of cores inside the machine must be a value greater or equal 1") | ||
| } | ||
|
|
||
| infraID := opts.InfraID | ||
| if len(infraID) == 0 { | ||
| infraID = fmt.Sprintf("%s-%s", opts.Name, utilrand.String(5)) | ||
| } | ||
| exampleOptions.InfraID = infraID | ||
| exampleOptions.BaseDomain = "example.com" | ||
|
|
||
| exampleOptions.Kubevirt = &apifixtures.ExampleKubevirtOptions{ | ||
| APIServerAddress: opts.KubevirtPlatform.APIServerAddress, | ||
| Memory: opts.KubevirtPlatform.Memory, | ||
| Cores: opts.KubevirtPlatform.Cores, | ||
| Image: opts.KubevirtPlatform.ContainerDiskImage, | ||
| } | ||
| return nil | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi, in the future we might need to reconsider RunStrategy. When we use runStrategy: Always, it means that the kubevirt VM could crash and recover with a new IP. If we need to avoid that, we'll have to consider a way to support runStrategy:Manual.
This is fine for now. Just be aware that there are likely some issues for us to follow up on here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I would even consider changing it in kubevirt itself, so that we restart the VMI in-place. Rescheduling has a lot of overhead. All other k8s controllers avoid that and restart in-place. Potentially has impact on how professional your monitoring has to be though.