Added None platform to ReconcileInfrastructure #771
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: eranco74 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
/lgtm |
enxebre
reviewed
Dec 9, 2021
| case hyperv1.IBMCloudPlatform: | ||
| infra.Status.PlatformStatus = &configv1.PlatformStatus{} | ||
| infra.Status.PlatformStatus.Type = configv1.IBMCloudPlatformType | ||
| case hyperv1.NonePlatform: |
Member
There was a problem hiding this comment.
Please just set
infra.Status.PlatformStatus.Type = configv1.PlatformType(hcp.Spec.Platform.Type)
for any case, no need to discriminate by platform.
Contributor
Author
|
Closing, this code is part of #764 that fix more issues with none platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kube-controller-manager keeps logging this error when HyperShift HostedCluster platform is none:
This error leads to worker nodes not getting any pods scheduled (not even SDN) and resulting worker nodes stuck with NotREady status.