CNTRLPLANE-625: Add support for custom trust bundle for AWS API endpoints

[hypershift-jira-solve-ci]

What this PR does / why we need it:

This PR ensures the additionalTrustBundle CA certificates are synced to the guest cluster's cloud-provider-config ConfigMap for AWS clusters, enabling the CCCMO's trusted_ca_bundle_controller to pick up custom CA certificates for AWS API endpoints.

Changes:

1. AWS cloud-provider-config sync (resources.go): Added an AWSPlatform case to reconcileCloudConfig() that:

   • Syncs the AWS cloud provider config from the control plane to the guest cluster's cloud-provider-config ConfigMap in openshift-config
   • Includes the additionalTrustBundle CA data under the ca-bundle.pem key (the key expected by CCCMO)
   • Cleans up ca-bundle.pem when additionalTrustBundle is unset

2. Infrastructure CloudConfig for AWS (infrastructure.go): Sets Spec.CloudConfig.Name and Spec.CloudConfig.Key on the Infrastructure CR for AWS, allowing the kube-cloud-config controller and CCCMO to locate the cloud provider configuration.

3. Unit tests: Added tests for both the cloud config reconciliation and the Infrastructure CR changes.

Which issue(s) this PR fixes:

Fixes https://issues.redhat.com/browse/CNTRLPLANE-625

Special notes for your reviewer:

The additionalTrustBundle was already synced to the guest cluster as a user-ca-bundle ConfigMap, but it was not included in the cloud-provider-config ConfigMap. The CCCMO's trusted_ca_bundle_controller looks specifically for a ca-bundle.pem key in the synced cloud-config ConfigMap. This pattern is already implemented for OpenStack, and this PR extends it to AWS.

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

🤖 Generated with Claude Code via /jira-solve [CNTRLPLANE-625](https://issues.redhat.com//browse/CNTRLPLANE-625) origin

Always review AI generated responses prior to use.

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@hypershift-jira-solve-ci[bot]: This pull request references CNTRLPLANE-625 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:

This PR ensures the additionalTrustBundle CA certificates are synced to the guest cluster's cloud-provider-config ConfigMap for AWS clusters, enabling the CCCMO's trusted_ca_bundle_controller to pick up custom CA certificates for AWS API endpoints.

Changes:

1. AWS cloud-provider-config sync (resources.go): Added an AWSPlatform case to reconcileCloudConfig() that:

• Syncs the AWS cloud provider config from the control plane to the guest cluster's cloud-provider-config ConfigMap in openshift-config
• Includes the additionalTrustBundle CA data under the ca-bundle.pem key (the key expected by CCCMO)
• Cleans up ca-bundle.pem when additionalTrustBundle is unset

2. Infrastructure CloudConfig for AWS (infrastructure.go): Sets Spec.CloudConfig.Name and Spec.CloudConfig.Key on the Infrastructure CR for AWS, allowing the kube-cloud-config controller and CCCMO to locate the cloud provider configuration.

3. Unit tests: Added tests for both the cloud config reconciliation and the Infrastructure CR changes.

Which issue(s) this PR fixes:

Fixes https://issues.redhat.com/browse/CNTRLPLANE-625

Special notes for your reviewer:

The additionalTrustBundle was already synced to the guest cluster as a user-ca-bundle ConfigMap, but it was not included in the cloud-provider-config ConfigMap. The CCCMO's trusted_ca_bundle_controller looks specifically for a ca-bundle.pem key in the synced cloud-config ConfigMap. This pattern is already implemented for OpenStack, and this PR extends it to AWS.

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

🤖 Generated with Claude Code via /jira-solve [CNTRLPLANE-625](https://issues.redhat.com//browse/CNTRLPLANE-625) origin

Always review AI generated responses prior to use.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

• do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@hypershift-jira-solve-ci[bot]: This pull request references CNTRLPLANE-625 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:

This PR ensures the additionalTrustBundle CA certificates are synced to the guest cluster's cloud-provider-config ConfigMap for AWS clusters, enabling the CCCMO's trusted_ca_bundle_controller to pick up custom CA certificates for AWS API endpoints.

Changes:

1. AWS cloud-provider-config sync (resources.go): Added an AWSPlatform case to reconcileCloudConfig() that:

• Syncs the AWS cloud provider config from the control plane to the guest cluster's cloud-provider-config ConfigMap in openshift-config
• Includes the additionalTrustBundle CA data under the ca-bundle.pem key (the key expected by CCCMO)
• Cleans up ca-bundle.pem when additionalTrustBundle is unset

2. Infrastructure CloudConfig for AWS (infrastructure.go): Sets Spec.CloudConfig.Name and Spec.CloudConfig.Key on the Infrastructure CR for AWS, allowing the kube-cloud-config controller and CCCMO to locate the cloud provider configuration.

3. Unit tests: Added tests for both the cloud config reconciliation and the Infrastructure CR changes.

Which issue(s) this PR fixes:

Fixes https://issues.redhat.com/browse/CNTRLPLANE-625

Special notes for your reviewer:

The additionalTrustBundle was already synced to the guest cluster as a user-ca-bundle ConfigMap, but it was not included in the cloud-provider-config ConfigMap. The CCCMO's trusted_ca_bundle_controller looks specifically for a ca-bundle.pem key in the synced cloud-config ConfigMap. This pattern is already implemented for OpenStack, and this PR extends it to AWS.

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

🤖 Generated with Claude Code via /jira-solve [CNTRLPLANE-625](https://issues.redhat.com//browse/CNTRLPLANE-625) origin

Always review AI generated responses prior to use.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hi @hypershift-jira-solve-ci[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hypershift-jira-solve-ci[bot]
Once this PR has been reviewed and has the lgtm label, please assign devguyio for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bryan-cox]

/close

duplicate PR

[openshift-ci]

@bryan-cox: Closed this PR.

Details

In response to this:

/close

duplicate PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.