CNTRLPLANE-1894: Add multiarch validation test for override images by hypershift-jira-solve-ci[bot] · Pull Request #7674 · openshift/hypershift

hypershift-jira-solve-ci · 2026-02-06T13:05:32Z

What this PR does / why we need it:

Adds a Go test to validate that all CPO override images referenced in overrides.yaml have multiarch support (at least amd64 and arm64 architectures in their manifest lists).

Override images need to support both AMD64 and ARM64 architectures to work across different platforms. Currently, there's no automated validation to ensure override images contain both architectures. This test catches misconfigured images early before deployment.

How it works:

Parses the embedded overrides.yaml to extract all unique CPO image references (deduplicated)
Uses skopeo inspect --raw to fetch each image's manifest
Validates the manifest is a manifest list containing at least amd64 and arm64 entries
Reports clear per-image errors for any images lacking required architectures
Gracefully skips if skopeo is not installed (safe for local make test)

Unit tests included:

TestCollectUniqueOverrideImages - validates image deduplication across platforms
TestCollectUniqueOverrideImagesWithNilPlatform - handles nil platform configs
TestCollectUniqueOverrideImagesTrimsWhitespace - handles trailing whitespace in YAML
TestParseMultiarchManifest - validates multiarch manifest parsing
TestParseSingleArchManifest - validates single-arch detection
TestOverrideImagesHaveMultiarchSupport - integration test (requires skopeo)

Which issue(s) this PR fixes:

Fixes CNTRLPLANE-1894

Special notes for your reviewer:

The TestOverrideImagesHaveMultiarchSupport test requires skopeo to be installed. It will skip gracefully when skopeo is not available.
CI integration to trigger this test via run_if_changed: (/overrides\.yaml$) would be a follow-up in the openshift/release repository.
This is complementary to but separate from the full ARO HCP override deployment test (CNTRLPLANE-1893).

Checklist:

Subject and description added to both, commit and PR.
Relevant issues have been referenced.
This change includes docs.
This change includes unit tests.

🤖 Generated with Claude Code via /jira-solve [CNTRLPLANE-1894](https://issues.redhat.com//browse/CNTRLPLANE-1894) origin

Always review AI generated responses prior to use.

openshift-ci-robot · 2026-02-06T13:05:35Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci-robot · 2026-02-06T13:05:37Z

@hypershift-jira-solve-ci[bot]: This pull request references CNTRLPLANE-1894 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target either version "4.22." or "openshift-4.22.", but it targets "openshift-4.21" instead.

Details

In response to this:

What this PR does / why we need it:

Adds a Go test to validate that all CPO override images referenced in overrides.yaml have multiarch support (at least amd64 and arm64 architectures in their manifest lists).

Override images need to support both AMD64 and ARM64 architectures to work across different platforms. Currently, there's no automated validation to ensure override images contain both architectures. This test catches misconfigured images early before deployment.

How it works:

Parses the embedded overrides.yaml to extract all unique CPO image references (deduplicated)

Uses skopeo inspect --raw to fetch each image's manifest

Validates the manifest is a manifest list containing at least amd64 and arm64 entries

Reports clear per-image errors for any images lacking required architectures

Gracefully skips if skopeo is not installed (safe for local make test)

Unit tests included:

TestCollectUniqueOverrideImages - validates image deduplication across platforms

TestCollectUniqueOverrideImagesWithNilPlatform - handles nil platform configs

TestCollectUniqueOverrideImagesTrimsWhitespace - handles trailing whitespace in YAML

TestParseMultiarchManifest - validates multiarch manifest parsing

TestParseSingleArchManifest - validates single-arch detection

TestOverrideImagesHaveMultiarchSupport - integration test (requires skopeo)

Which issue(s) this PR fixes:

Fixes CNTRLPLANE-1894

Special notes for your reviewer:

The TestOverrideImagesHaveMultiarchSupport test requires skopeo to be installed. It will skip gracefully when skopeo is not available.

CI integration to trigger this test via run_if_changed: (/overrides\.yaml$) would be a follow-up in the openshift/release repository.

This is complementary to but separate from the full ARO HCP override deployment test (CNTRLPLANE-1893).

Checklist:

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

This change includes docs.

This change includes unit tests.

🤖 Generated with Claude Code via /jira-solve [CNTRLPLANE-1894](https://issues.redhat.com//browse/CNTRLPLANE-1894) origin

Always review AI generated responses prior to use.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-02-06T13:05:45Z

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Excluded labels (none allowed) (1)

do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🔍 Trigger a full review

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

hypershift-jira-solve-ci · 2026-02-06T13:05:46Z

/auto-cc

openshift-ci · 2026-02-06T13:06:17Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hypershift-jira-solve-ci[bot]
Once this PR has been reviewed and has the lgtm label, please assign csrwng for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2026-02-06T13:06:18Z

Hi @hypershift-jira-solve-ci[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

bryan-cox · 2026-02-06T14:12:32Z

+	return architectures, nil
+}
+
+func TestCollectUniqueOverrideImages(t *testing.T) {


How is this unit test even helpful? It doesn't seem helpful to me when considering the Jira ticket you are trying to solve.

If this is a helpful unit test, please provide empirical evidence as to why it is.

You're right — this unit test for collectUniqueOverrideImages doesn't directly validate what CNTRLPLANE-1894 is about. The Jira ticket calls for validating that override images have multiarch support (amd64 + arm64), which is what TestOverrideImagesHaveMultiarchSupport does. This helper test only exercises a trivial deduplication function and doesn't provide meaningful regression protection or empirical value beyond what the integration test already covers.

I'll remove these helper unit tests (TestCollectUniqueOverrideImages, TestCollectUniqueOverrideImagesWithNilPlatform, TestCollectUniqueOverrideImagesTrimsWhitespace) and keep the focus on what the ticket actually requires.

AI-assisted response via Claude Code

bryan-cox · 2026-02-06T14:13:03Z

+	))
+}
+
+func TestCollectUniqueOverrideImagesWithNilPlatform(t *testing.T) {


Same comment as - https://github.com/openshift/hypershift/pull/7674/changes#r2774356870

Agreed — same reasoning applies here. Will remove this test along with the others.

AI-assisted response via Claude Code

bryan-cox · 2026-02-06T14:13:11Z

+	g.Expect(images[0]).To(Equal("quay.io/example/image@sha256:abc"))
+}
+
+func TestCollectUniqueOverrideImagesTrimsWhitespace(t *testing.T) {


Same comment as - https://github.com/openshift/hypershift/pull/7674/changes#r2774356870

Agreed — same reasoning applies here. Will remove this test along with the others.

AI-assisted response via Claude Code

bryan-cox · 2026-02-06T14:14:35Z

hypershift-jira-solve-ci - Did you try to test this? You should be able to trigger the pj-rehearse job from openshift/release here on this PR. You can look at our docs in the hypershift repo if you need more context on how to do this.

bryan-cox · 2026-02-06T14:14:48Z

/ok-to-test

openshift-ci · 2026-02-06T15:15:40Z

@hypershift-jira-solve-ci[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify	`f8721fe`	link	true	`/test verify`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

hypershift-jira-solve-ci · 2026-02-06T17:03:54Z

@bryan-cox Thank you for the feedback. No, the pj-rehearse job was not triggered from openshift/release for this PR. The unit tests were validated locally with go test, but the full CI integration test (TestOverrideImagesHaveMultiarchSupport, which requires skopeo) was not validated through the rehearse pipeline.

I've also removed the three helper unit tests (TestCollectUniqueOverrideImages, TestCollectUniqueOverrideImagesWithNilPlatform, TestCollectUniqueOverrideImagesTrimsWhitespace) per your inline review feedback — they don't add meaningful value for validating what CNTRLPLANE-1894 requires.

Will push the updated commit shortly after verifying the changes pass locally.

AI-assisted response via Claude Code

Override images need to support both AMD64 and ARM64 architectures to work across different platforms. Currently, there's no automated validation to ensure override images contain both architectures in their manifest lists. This test catches misconfigured images early before deployment. The test: - Parses overrides.yaml to extract all unique CPO image references - Uses skopeo to inspect each image's manifest list - Validates that each image has at least amd64 and arm64 architectures - Skips gracefully if skopeo is not installed (safe for local dev) - Reports clear per-image errors for any missing architectures Ref: CNTRLPLANE-1894 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

hypershift-jira-solve-ci · 2026-02-06T17:17:47Z

@bryan-cox Update: The helper unit tests have been removed and the updated commit has been pushed. The remaining tests (TestParseMultiarchManifest, TestParseSingleArchManifest, and TestOverrideImagesHaveMultiarchSupport) all pass locally.

Regarding testing via pj-rehearse — since this test requires skopeo and gracefully skips when it's not available, the unit test CI job (ci/prow/unit) passes. The ci/prow/verify failure appears to be unrelated to this PR's changes (verify passes locally). A /retest should confirm.

AI-assisted response via Claude Code

bryan-cox · 2026-02-25T12:53:55Z

Closing PR - reverting Jira ticket to backlog

bryan-cox · 2026-02-25T12:58:10Z

/close

openshift-ci · 2026-02-25T12:59:34Z

@bryan-cox: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 6, 2026

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 6, 2026

openshift-ci Bot added the do-not-merge/needs-area label Feb 6, 2026

openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 6, 2026

openshift-ci Bot added area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release and removed do-not-merge/needs-area labels Feb 6, 2026

openshift-ci Bot requested review from bryan-cox and devguyio February 6, 2026 13:06

bryan-cox reviewed Feb 6, 2026

View reviewed changes

openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 6, 2026

hypershift-jira-solve-ci Bot force-pushed the fix-CNTRLPLANE-1894 branch from f8721fe to de4cb10 Compare February 6, 2026 17:14

bryan-cox mentioned this pull request Feb 9, 2026

fix: jira-agent posts /auto-cc to wrong PR due to head -1 URL extraction openshift/release#74612

Merged

2 tasks

openshift-ci Bot closed this Feb 25, 2026

Uh oh!

Conversation

hypershift-jira-solve-ci Bot commented Feb 6, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does / why we need it:

How it works:

Unit tests included:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist:

Uh oh!

openshift-ci-robot commented Feb 6, 2026

Uh oh!

openshift-ci-robot commented Feb 6, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does / why we need it:

How it works:

Unit tests included:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist:

Uh oh!

coderabbitai Bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

hypershift-jira-solve-ci Bot commented Feb 6, 2026

Uh oh!

openshift-ci Bot commented Feb 6, 2026

Uh oh!

openshift-ci Bot commented Feb 6, 2026

Uh oh!

bryan-cox Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

hypershift-jira-solve-ci Bot Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

bryan-cox Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

hypershift-jira-solve-ci Bot Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

bryan-cox Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

hypershift-jira-solve-ci Bot Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

bryan-cox commented Feb 6, 2026

Uh oh!

bryan-cox commented Feb 6, 2026

Uh oh!

openshift-ci Bot commented Feb 6, 2026

Uh oh!

hypershift-jira-solve-ci Bot commented Feb 6, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hypershift-jira-solve-ci Bot commented Feb 6, 2026

Uh oh!

bryan-cox commented Feb 25, 2026

Uh oh!

bryan-cox commented Feb 25, 2026

Uh oh!

openshift-ci Bot commented Feb 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hypershift-jira-solve-ci Bot commented Feb 6, 2026 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Feb 6, 2026 •

edited by openshift-ci Bot

Loading

coderabbitai Bot commented Feb 6, 2026 •

edited

Loading

hypershift-jira-solve-ci Bot commented Feb 6, 2026 •

edited by openshift-ci Bot

Loading