Skip to content

HPCASE-206:Add TLSAdherence feature gate - #7635

Closed
richardsonnick wants to merge 1 commit into
openshift:mainfrom
richardsonnick:feature-gate/tlsadherence
Closed

richardsonnick wants to merge 1 commit into
openshift:mainfrom
richardsonnick:feature-gate/tlsadherence

Conversation

@richardsonnick

@richardsonnick richardsonnick commented Feb 4, 2026

Copy link
Copy Markdown

What this PR does / why we need it:

Adds the TLSAdherence feature gate entry to HyperShift's feature gate configuration files.
This is a sibling PR to openshift/api#2680 which adds a new tlsAdherence field to the APIServer config resource. Since HyperShift embeds configv1.APIServerSpec in the HostedCluster types 1, we need to ensure this new field is properly gated at the TechPreview level to prevent accidental GA exposure.
The feature gate is added as:

  • Disabled in *-Default.yaml files (matching standalone OCP Default behavior)
  • Enabled in *-TechPreviewNoUpgrade.yaml files (matching standalone OCP TechPreview behavior)

Which issue(s) this PR fixes:

Fixes N/A
Related:
openshift/api#2680
openshift/enhancements#1910

Special notes for your reviewer:

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 4, 2026
@openshift-ci-robot

openshift-ci-robot commented Feb 4, 2026

Copy link
Copy Markdown

@richardsonnick: This pull request references HPCASE-206 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:

Adds the TLSAdherence feature gate entry to HyperShift's feature gate configuration files.
This is a sibling PR to openshift/api#2680 which adds a new tlsAdherence field to the APIServer config resource. Since HyperShift embeds configv1.APIServerSpec in the HostedCluster types 1, we need to ensure this new field is properly gated at the TechPreview level to prevent accidental GA exposure.
The feature gate is added as:

  • Disabled in *-Default.yaml files (matching standalone OCP Default behavior)
  • Enabled in *-TechPreviewNoUpgrade.yaml files (matching standalone OCP TechPreview behavior)

Which issue(s) this PR fixes:

Fixes N/A
Related:
openshift/api#2680
openshift/enhancements#1910

Special notes for your reviewer:

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 4, 2026
@openshift-ci

openshift-ci Bot commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot

openshift-ci-robot commented Feb 4, 2026

Copy link
Copy Markdown

@richardsonnick: This pull request references HPCASE-206 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:

Adds the TLSAdherence feature gate entry to HyperShift's feature gate configuration files.
This is a sibling PR to openshift/api#2680 which adds a new tlsAdherence field to the APIServer config resource. Since HyperShift embeds configv1.APIServerSpec in the HostedCluster types 1, we need to ensure this new field is properly gated at the TechPreview level to prevent accidental GA exposure.
The feature gate is added as:

  • Disabled in *-Default.yaml files (matching standalone OCP Default behavior)
  • Enabled in *-TechPreviewNoUpgrade.yaml files (matching standalone OCP TechPreview behavior)

Which issue(s) this PR fixes:

Fixes N/A
Related:
openshift/api#2680
openshift/enhancements#1910

Special notes for your reviewer:

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the area/api Indicates the PR includes changes for the API label Feb 4, 2026
@openshift-ci

openshift-ci Bot commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: richardsonnick
Once this PR has been reviewed and has the lgtm label, please assign sjenning for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

@richardsonnick: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/api Indicates the PR includes changes for the API do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants