NO-JIRA: fix(e2e): TestNodePoolAutoscalingScaleFromZero for 4.20 and later only - #7556
Conversation
|
@sjenning: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughAdds a runtime version check to the TestNodePoolAutoscalingScaleFromZero test, gating execution to require platform version 4.2.0 or later via e2eutil.AtLeast(). The test will be skipped on earlier versions. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes ✨ Finishing touches
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sjenning The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow/e2e-aks |
|
/hold for payload testing |
|
@sjenning: Overrode contexts on behalf of sjenning: ci/prow/e2e-aks, ci/prow/e2e-aks-4-21, ci/prow/e2e-aws, ci/prow/e2e-aws-upgrade-hypershift-operator, ci/prow/e2e-kubevirt-aws-ovn-reduced DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4.19 and earlier to not support this.
b900400 to
5547d92
Compare
|
/override ci/prow/e2e-aks |
|
@sjenning: Overrode contexts on behalf of sjenning: ci/prow/e2e-aks, ci/prow/e2e-aks-4-21, ci/prow/e2e-aws, ci/prow/e2e-aws-upgrade-hypershift-operator, ci/prow/e2e-kubevirt-aws-ovn-reduced DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/payload-job periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aws-ovn |
|
@sjenning: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c2e40110-f659-11f0-8afd-856a095e640c-0 |
|
/override ci/prow/e2e-aws-4-21 |
|
@sjenning: Overrode contexts on behalf of sjenning: ci/prow/e2e-aws-4-21 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/verified bypass |
|
@sjenning: The DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold cancel |
4.19 and earlier do not support this.
Urgent fix as all 4.19 and earlier periodic e2es are permafailing.
https://prow.ci.openshift.org/?job=periodic-ci-openshift-hypershift-release-*-periodics-e2e-aws-ovn
Triggered by openshift/release#72805. Before this PR, the test was being skipped.
Note
Restricts the scale-from-zero e2e to supported versions to avoid failures on older releases.
e2eutil.AtLeast(t, e2eutil.Version420)at the start ofTestNodePoolAutoscalingScaleFromZeroso the test runs only on 4.20+.Written by Cursor Bugbot for commit 5547d92. This will update automatically on new commits. Configure here.