Skip to content

NO-JIRA: fix(e2e): TestNodePoolAutoscalingScaleFromZero for 4.20 and later only - #7556

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
sjenning:fix-e2e-scale-zero
Jan 21, 2026
Merged

NO-JIRA: fix(e2e): TestNodePoolAutoscalingScaleFromZero for 4.20 and later only#7556
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
sjenning:fix-e2e-scale-zero

Conversation

@sjenning

@sjenning sjenning commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

4.19 and earlier do not support this.

Urgent fix as all 4.19 and earlier periodic e2es are permafailing.

https://prow.ci.openshift.org/?job=periodic-ci-openshift-hypershift-release-*-periodics-e2e-aws-ovn

Triggered by openshift/release#72805. Before this PR, the test was being skipped.


Note

Restricts the scale-from-zero e2e to supported versions to avoid failures on older releases.

  • Adds e2eutil.AtLeast(t, e2eutil.Version420) at the start of TestNodePoolAutoscalingScaleFromZero so the test runs only on 4.20+.

Written by Cursor Bugbot for commit 5547d92. This will update automatically on new commits. Configure here.

@sjenning sjenning changed the title fix(e2e): TestNodePoolAutoscalingScaleFromZero for 4.21 and later only NO-JIRA: fix(e2e): TestNodePoolAutoscalingScaleFromZero for 4.21 and later only Jan 20, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 20, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@sjenning: This pull request explicitly references no jira issue.

Details

In response to this:

4.20 and earlier to not support this.

Urgent fix as all 4.20 and earlier periodic e2es are permafailing.

https://prow.ci.openshift.org/?job=periodic-ci-openshift-hypershift-release-*-periodics-e2e-aws-ovn

Triggered by openshift/release#72805. Before this PR, the test was being skipped.


[!NOTE]
Cursor Bugbot is generating a summary for commit b900400. Configure here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

Adds a runtime version check to the TestNodePoolAutoscalingScaleFromZero test, gating execution to require platform version 4.2.0 or later via e2eutil.AtLeast(). The test will be skipped on earlier versions.

Changes

Cohort / File(s) Summary
Test version gating
test/e2e/autoscaling_test.go
Added runtime check e2eutil.AtLeast(t, e2eutil.Version420) to gate TestNodePoolAutoscalingScaleFromZero test execution to version 4.2.0+.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the area/testing Indicates the PR includes changes for e2e testing label Jan 20, 2026
@openshift-ci

openshift-ci Bot commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Jan 20, 2026
@openshift-ci
openshift-ci Bot requested review from devguyio and enxebre January 20, 2026 23:38
@sjenning

Copy link
Copy Markdown
Contributor Author

/override ci/prow/e2e-aks
/override ci/prow/e2e-aks-4-21
/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-upgrade-hypershift-operator
/override ci/prow/e2e-kubevirt-aws-ovn-reduced

@sjenning

sjenning commented Jan 20, 2026

Copy link
Copy Markdown
Contributor Author

/hold

for payload testing

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2026
@openshift-ci

openshift-ci Bot commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

@sjenning: Overrode contexts on behalf of sjenning: ci/prow/e2e-aks, ci/prow/e2e-aks-4-21, ci/prow/e2e-aws, ci/prow/e2e-aws-upgrade-hypershift-operator, ci/prow/e2e-kubevirt-aws-ovn-reduced

Details

In response to this:

/override ci/prow/e2e-aks
/override ci/prow/e2e-aks-4-21
/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-upgrade-hypershift-operator
/override ci/prow/e2e-kubevirt-aws-ovn-reduced

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sjenning

Copy link
Copy Markdown
Contributor Author

/override ci/prow/e2e-aks
/override ci/prow/e2e-aks-4-21
/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-upgrade-hypershift-operator
/override ci/prow/e2e-kubevirt-aws-ovn-reduced

@openshift-ci

openshift-ci Bot commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

@sjenning: Overrode contexts on behalf of sjenning: ci/prow/e2e-aks, ci/prow/e2e-aks-4-21, ci/prow/e2e-aws, ci/prow/e2e-aws-upgrade-hypershift-operator, ci/prow/e2e-kubevirt-aws-ovn-reduced

Details

In response to this:

/override ci/prow/e2e-aks
/override ci/prow/e2e-aks-4-21
/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-upgrade-hypershift-operator
/override ci/prow/e2e-kubevirt-aws-ovn-reduced

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sjenning

Copy link
Copy Markdown
Contributor Author

/payload-job periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aws-ovn

@openshift-ci

openshift-ci Bot commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

@sjenning: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c2e40110-f659-11f0-8afd-856a095e640c-0

@sjenning

Copy link
Copy Markdown
Contributor Author

/override ci/prow/e2e-aws-4-21

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Comment thread test/e2e/autoscaling_test.go
@openshift-ci

openshift-ci Bot commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

@sjenning: Overrode contexts on behalf of sjenning: ci/prow/e2e-aws-4-21

Details

In response to this:

/override ci/prow/e2e-aws-4-21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sjenning sjenning changed the title NO-JIRA: fix(e2e): TestNodePoolAutoscalingScaleFromZero for 4.21 and later only NO-JIRA: fix(e2e): TestNodePoolAutoscalingScaleFromZero for 4.20 and later only Jan 20, 2026
@sjenning

Copy link
Copy Markdown
Contributor Author

/verified bypass

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 21, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@sjenning: The verified label has been added.

Details

In response to this:

/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sjenning

Copy link
Copy Markdown
Contributor Author

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2026
@sjenning sjenning added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 157b47d into openshift:main Jan 21, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Indicates the PR includes changes for e2e testing jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants