NO-JIRA: test(autoscaling): make GPU annotation optional in scale-from-zero test

[jhjaggars]

What this PR does / why we need it:

This PR fixes a test failure in TestNodePoolAutoscalingScaleFromZero that was failing when testing with non-GPU instance types.

The test unconditionally expected the machine.openshift.io/GPU annotation to be present on the MachineDeployment. However, the scale-from-zero controller only sets this annotation when the instance type has GPUs (see hypershift-operator/controllers/nodepool/scale_from_zero.go:126-132). When testing with non-GPU instances (like m5.large), the GPU annotation is intentionally not set, causing the test to fail.

Changes:

1. Removed mandatory GPU annotation check - The test now only requires vCPU, memoryMb, and labels annotations (which are always set)
2. Updated logging to gracefully handle missing GPU annotation in log output

Which issue(s) this PR fixes:

Fixes test failures seen in openshift/release#72805 which enables scale-from-zero testing in CI.

Special notes for your reviewer:

• The controller behavior is correct - verified from CI artifacts that vCPU, memoryMb, and labels annotations are properly set
• GPU annotation is correctly omitted for non-GPU instances per the implementation in scale_from_zero.go
• make staticcheck passes

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs. (N/A - test-only change)
• This change includes unit tests. (N/A - fixes existing e2e test)

[coderabbitai]

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

• do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

GPU capacity annotation check in MachineDeployment verification is now optional. When absent, a default fallback string is applied, and log output uses this computed value instead of the raw annotation.

Changes

Cohort / File(s)	Summary
GPU Annotation Optionality test/e2e/autoscaling_test.go	Made GPU capacity annotation optional with fallback default value "none (non-GPU instance)" for logging when annotation is missing; updated log output to use computed value instead of raw annotation

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[bryan-cox]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, jhjaggars

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [bryan-cox]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bryan-cox]

/lgtm cancel

[LiangquanLi930]

/retest-required

[LiangquanLi930]

/lgtm

[jhjaggars]

/retest

[jhjaggars]

/verified via e2e tests later

[openshift-ci-robot]

@jhjaggars: /verified later <@username> requires at least one GitHub @username to be specified (it can be a comma delimited list). It indicates the engineer(s) that will be performing the verification. See https://docs.ci.openshift.org/docs/architecture/jira/#premerge-verification for more information.

Details

In response to this:

/verified via e2e tests later

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jhjaggars]

/verified @jhjaggars via e2etest later

[openshift-ci-robot]

@jhjaggars: /verified later <@username> requires at least one GitHub @username to be specified (it can be a comma delimited list). It indicates the engineer(s) that will be performing the verification. See https://docs.ci.openshift.org/docs/architecture/jira/#premerge-verification for more information.

Details

In response to this:

/verified @jhjaggars via e2etest later

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jhjaggars]

/verified later @jhjaggars

[openshift-ci-robot]

@jhjaggars: This PR has been marked to be verified later by @jhjaggars.

Details

In response to this:

/verified later @jhjaggars

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[bryan-cox]

/lgtm

Just rebased

[jhjaggars]

/retest

[jhjaggars]

/retest

[LiangquanLi930]

/test e2e-aws-4-21

[openshift-ci]

@jhjaggars: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@jhjaggars: This pull request explicitly references no jira issue.

Details

In response to this:

What this PR does / why we need it:

This PR fixes a test failure in TestNodePoolAutoscalingScaleFromZero that was failing when testing with non-GPU instance types.

The test unconditionally expected the machine.openshift.io/GPU annotation to be present on the MachineDeployment. However, the scale-from-zero controller only sets this annotation when the instance type has GPUs (see hypershift-operator/controllers/nodepool/scale_from_zero.go:126-132). When testing with non-GPU instances (like m5.large), the GPU annotation is intentionally not set, causing the test to fail.

Changes:

1. Removed mandatory GPU annotation check - The test now only requires vCPU, memoryMb, and labels annotations (which are always set)
2. Updated logging to gracefully handle missing GPU annotation in log output

Which issue(s) this PR fixes:

Fixes test failures seen in openshift/release#72805 which enables scale-from-zero testing in CI.

Special notes for your reviewer:

• The controller behavior is correct - verified from CI artifacts that vCPU, memoryMb, and labels annotations are properly set
• GPU annotation is correctly omitted for non-GPU instances per the implementation in scale_from_zero.go
• make staticcheck passes

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs. (N/A - test-only change)
• This change includes unit tests. (N/A - fixes existing e2e test)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.