CNTRLPLANE-2205: feat(aws): enable shared role in e2e - #7400
Conversation
This commit enables the use of a shared role on AWS for all test clusters except TestUpgradeControlPlane, which continues to verify the use individual roles. This test cluster was also choosen to avoid having to do complex filtering for z-stream releases that do not contain the required HCCO fix.
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
WalkthroughThe pull request adds AWS platform-specific configuration for the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to 📒 Files selected for processing (2)
🧰 Additional context used📓 Path-based instructions (1)**⚙️ CodeRabbit configuration file
Files:
🧬 Code graph analysis (2)test/e2e/control_plane_upgrade_test.go (1)
test/e2e/util/options.go (1)
🔇 Additional comments (3)
Comment |
|
/hold until #7383 is accepted into both a 4.20 |
openshift-ci
Bot
added
the
do-not-merge/hold
|
/test e2e-aws |
openshift-ci
Bot
added
the
area/testing
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sjenning The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
sjenning
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@sjenning: This pull request references CNTRLPLANE-2205 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
|
@sjenning: This pull request references CNTRLPLANE-2205 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified by e2e |
openshift-ci-robot
added
the
verified
|
@sjenning: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@sjenning: This pull request references CNTRLPLANE-2205 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Looks like it was added into these releases: I think we can remove the hold. Let this to you @sjenning. |
|
/lgtm |
sjenning
added
the
acknowledge-critical-fixes-only
|
/override okd-scos-images |
|
/hold cancel |
openshift-ci
Bot
removed
the
do-not-merge/hold
|
@sjenning: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/okd-scos-images |
|
@sjenning: Overrode contexts on behalf of sjenning: ci/prow/okd-scos-images DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-aks |
|
/override ci/prow/e2e-aks Two runs flaked on different tests |
|
@sjenning: Overrode contexts on behalf of sjenning: ci/prow/e2e-aks DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/okd-scos-images |
|
@sjenning: Overrode contexts on behalf of sjenning: ci/prow/e2e-aks, ci/prow/okd-scos-images DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@sjenning: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
This commit enables the use of a shared role on AWS for all test clusters 4.20 and newer, except TestUpgradeControlPlane, which continues to verify the use individual roles. This test cluster was also chosen to avoid having to do complex filtering for z-stream releases that do not contain the required HCCO fix.
#7383
Note
Enable AWS shared IAM role for e2e clusters by default (gated to 4.20+), while the control plane upgrade test continues to use individual roles.
test/e2e/util/options.go):SharedRole: trueby default; auto-disable for versions< 4.20.0due to HCCO fix requirement.PublicOnlybehavior toggle for versions< 4.16.0.test/e2e/control_plane_upgrade_test.go):clusterOpts.AWSPlatform.SharedRole = falseto validate individual roles during upgrade.Written by Cursor Bugbot for commit 99bef30. This will update automatically on new commits. Configure here.