Skip to content

feat(aws): enable shared IAM role in e2e - #7334

Closed
sjenning wants to merge 2 commits into
openshift:mainfrom
sjenning:e2e-shared-role
Closed

feat(aws): enable shared IAM role in e2e#7334
sjenning wants to merge 2 commits into
openshift:mainfrom
sjenning:e2e-shared-role

Conversation

@sjenning

@sjenning sjenning commented Dec 4, 2025

Copy link
Copy Markdown
Contributor

Enable the use of a single shared IAM role for all test clusters except TestCreateCluster.

Follow on for #7331

@openshift-ci

openshift-ci Bot commented Dec 4, 2025

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 4, 2025
@coderabbitai

coderabbitai Bot commented Dec 4, 2025

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Excluded labels (none allowed) (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@sjenning

sjenning commented Dec 4, 2025

Copy link
Copy Markdown
Contributor Author

/test e2e-aws

@openshift-ci openshift-ci Bot added area/testing Indicates the PR includes changes for e2e testing and removed do-not-merge/needs-area labels Dec 4, 2025
@openshift-ci

openshift-ci Bot commented Dec 4, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2025
@sjenning

sjenning commented Dec 4, 2025

Copy link
Copy Markdown
Contributor Author

/test verify

Enable the use of a single shared IAM role for all
test clusters except TestCreateCluster.
Original commit that introduced the shared role did not include
handling for using ROSA managed policies.  The commit adds code
to handle it.
@sjenning

sjenning commented Dec 4, 2025

Copy link
Copy Markdown
Contributor Author

/test e2e-aws-minimal

@openshift-ci openshift-ci Bot added area/cli Indicates the PR includes changes for CLI area/platform/aws PR/issue for AWS (AWSPlatform) platform labels Dec 4, 2025
@openshift-ci

openshift-ci Bot commented Dec 4, 2025

Copy link
Copy Markdown
Contributor

@sjenning: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws 18916a0 link true /test e2e-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sjenning sjenning closed this Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cli Indicates the PR includes changes for CLI area/platform/aws PR/issue for AWS (AWSPlatform) platform area/testing Indicates the PR includes changes for e2e testing do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant